Avoids instantiation of the widget when searchings using the search box
only to find nothing.
Change-Id: Id335de7f6cc2168d38905afe42b07e509c70f791
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Amends a68352f013.
This is getting in the way, it does not look needed, and it is lost
in history why it ever was.
Change-Id: I68ebdafc78e3259c73c64364607aef6eb74d2869
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If you link to the internal Sqlite library you link actually twice. That
leads to strange bugs because you have an uninitialized object file. The
static linking workaround is now moved to cmake.
Change-Id: I51d966a623a18486ce5870d898999f3ce139f092
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
..especially when using data driven tests. In this case
we add an intermediate before the first data tag result
which apparently never got automatically expanded.
Change-Id: I282a57444b8014877c7a0e9f67c11c05ba1d06a5
Reviewed-by: David Schulz <david.schulz@qt.io>
Big files are loaded in chunks inside a QEventLoop. If follow symbol is
triggered via mouse and opens such a big file and the mouse is moved
while loading that file ClangdFollowSymbol got deleted while opening the
file in ClangdClient::followSymbol. Instead of the hard deletion just
cancel that follow symbol operation and make sure done is emitted
afterwards. The handling of that done signal takes care of the deletion
of that follow symbol operation.
Change-Id: Iba4ad6abb541186c2f26506f82fe1bc582818fca
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Remove recheckEnabled() and introduce setupSearch()
virtual method. The latter is called just once per
SearchResult instance (on first search), so we may
store the additional parameter (current project
file path) in lambda capture.
Change-Id: I7683e818bec8f1d787bdb33c573248b252b47c78
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
They are set and modified, but never read.
Change-Id: I6f21ae325e21513678f1534cd05e1a2470b9627b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Otherwise, the extension system will unnecessarily try to load them at
start-up.
Change-Id: I7a932904835cb387e3cf10924ca79a58e5f92b33
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... and use it to hard-code the result for the QtOptionPage. This
avoids instantiation QtOptionPage's widget, triggering the check
of all Qt versions.
For me that saves currently saves ~1.1 second after typing in the
option search box.
Change-Id: I6a3b335dcfdf3dceb9859684744231227a491f22
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Most prominently QmlDesigner crashed.
Some widgets have stylesheets set, and QStyleSheetStyle sometimes asks
for pixelMetric with nullptr as styleoption.
Amends c6dc54b343
Change-Id: If1264b29af83f2a489785e3c4f3e8342716ea125
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
qmakeevaluator.cpp:297:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
Change-Id: I157ba28e438b623d41dc7444c1381ecd649d3425
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The presence of a run configuration is not technically required: E.g. if
you disable auto-creation of run configurations in the settings, you
won't have any in the first place. It therefore makes little sense to
force users to keep at least one of them once they are there.
Change-Id: I2ce0379ebc43f44326db53d324d4db9e9b92ef03
Reviewed-by: hjk <hjk@qt.io>
for everyone that doesn't explicitly set the BUILD_DESIGNSTUDIO CMake
variable or the corresponding environment variable or CMake option.
Fixes: QTCREATORBUG-29238
Change-Id: Ie1959a468fc7bee0fed790b025ecdb3f49ab8f08
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
There is no advantage for an enduser to get errors on warnings because
he cannot do much about it. It is still nudging the developers to fix
the warnings.
Task-number: QTCREATORBUG-29238
Change-Id: If9f73f2766d686b119cd264ee7b3c3c9afa2c70d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
(cherry picked from commit ff2a14917f)
Reviewed-by: hjk <hjk@qt.io>
Removal of the node and references to the removed node are separate
operations done during node deletion, so the deletion must be
done inside a transaction to avoid getting multiple undo stack entries.
Fixes: QDS-10169
Change-Id: I2ef142b98cfaa60b1130ac729dd89347bb8cac13
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Do not directly expand an item directly after it had
been added to the model as its internal mappings need
to get updated.
Fixes: QTCREATORBUG-29302
Change-Id: If70d209074d97e0598bcbce061e176148751705a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
Do not warn out invalid property name if the property starts with an id
in the same component scope.
Small refactoring: Move early-return-likely elements up before any
calculations done.
Fixes: QTCREATORBUG-28468
Change-Id: I2cbdbc24af42f126db0bbd6027ebe4f96d9c199f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: hjk <hjk@qt.io>
According to hard-coded list. This should come from the manifest file in
the future.
Follow-up of qtdoc/4e38729111989dbb738042d4a8beb35d01b77fe1
Change-Id: If46383e1cf8e44c2a52ca5a458c497495e132639
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The property type of the shader source property is url, so use that
instead of bytearray type.
Fixes: QDS-9721
Change-Id: I244ed455f83e3f70d130a6085b9af083ee60c131
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Amends 6836caa14c
which added a variable to app_version.h.cmake, but not to
app_version.h.in. Fix by porting qbs to use app_version.h.cmake, which
is the truth nowadays, instead of the app_version.h.in which originated
from the qmake build.
Change-Id: Ia9be53377a0bfded91ccd6ea1637eeda7fe9d5c8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The summarySettingsHaveChanged() slot takes a (too?) long time, so at
least make sure we don't call it repeatedly while setting up the page.
Task-number: QTCREATORBUG-29290
Change-Id: Id010c41739a1381212731bb7638d6db87081c3b6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This patch:
unifies lookup for the first qml file to open;
increases number of possible fallback options;
adds missing implementations to some methods in QmlBuildSystem.
Task-number: QDS-9984
Change-Id: Ib282b1fca8b0564fe80f00e3d9ffe82c1a15c540
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
