After starting Qt Creator with the Beautifier plugin, turning its
automatic format on save option on, and restarting Qt Creator _without_
the Beautifier plugin, clang format was no longer formatting on save.
The clang format based formatting is supposed to be disabled if
- the Beautifier plugin is enabled, and
- its automatic format on save option is enabled.
Fix the check for the first condition, the plugin can be present but
disabled, explicitly check if it is enabled.
Change-Id: I5c9c270dd47ceec665aebca5b613f0c4a5357d72
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Otherwise the request to exit from Qt Creator would be missed,
making QtC hang on exit while waiting for the stub to exit.
Fixes: QTCREATORBUG-15749
Change-Id: I26dfa2c8aa358c8d7ad662ef806f459d1bbb6ec2
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Instead of putting everything into one big target there are now
libraries which are used by the tests.
Change-Id: I15727924f76b5cb600b7e533e7a6b8701dba81e0
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Qt Creator <= 10 accidentally wrote the default terminal into the
settings on macOS instead of leaving the values empty. So the change
from "openTerminal.py" to just "Terminal.app" might not be correctly
reflected in the settings.
Make sure that the terminal setting is removed in all cases, if it is
set to the default.
Amends f003234510
Change-Id: I9d099999f55b4003ac6e7f4a4b679b893eaffc90
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Get rid of a few .toFileInfo() and related calls.
Change-Id: I85a384848294e045fe07f621f06ebb17e567b444
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
The passed Group root element is a recipe with
a full description on how to execute the tasks
and how to handle finished tasks.
We have already virtual methods / setters called like:
deployRecipe, refreshRecipe, reloadRecipe. So, the
common "recipe" is kind of consistent.
Fix typos in warnings.
Addresses the 11th point in the task below.
Task-number: QTCREATORBUG-28741
Change-Id: I1c80f4838b6a3e5ed113eaf8e42b59746d098efe
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Preedits on linux can often contain more than one character.
Also changes the painting from white on black to painting with
just an underline.
Change-Id: I6769217ca80cf131aa3fb96b20e23b717f591467
Reviewed-by: David Schulz <david.schulz@qt.io>
... into its only users. Wasn't so useful as originally thought.
Task-number: QTCREATORBUG-29168
Change-Id: Ic10bc29d829f4abfb7bfa6e6d0aecff82ba4538e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Some warning / error messages of qmlsc/qmllint tools were not handled
by any of the output parsers and hence no CompileTask were created to
handle those output, like pushing those warnings into Issues pane. This
was also causing incorrect formatting of CompileOutput messages.This is
not an issue for MsvcParser because there a fallback task is created for
"Error" and "Warning" lines.
Introduce a fallback mechanism in QtParsers to handle qmltooling output
and add test.
Fixes: QTCREATORBUG-28720
Change-Id: I6d0de6bc8b6869c6ea80b72018a4acb7decc8b6d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Unlikely to make a difference in practice, but removes so unwanted
.toString/.exists.
Change-Id: I32c037aa87bb13cecb5b783fe0b36850e163f9c5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
In CMake projects, initially the project name is the directory name
that is later changed to the name defined in the project file. If
the user had expanded the project when it was still in its original
name, it would be left in the expand data as is, causing the project
to be expanded every time it is re-opened.
Fixed by checking if the name had changed and then re-inserting
possible expanded data with the new name.
Fixes: QTCREATORBUG-28681
Change-Id: I3b914fd0ae916205c86a6bd79cab5d57499d4d33
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
There is already a lock by an other transaction so we don't need this
anymore.
Change-Id: I0f97c41e2a680344e05fec3d02c199108e599a3a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
ShortCutMap::addShortCut did assert if the keysequence was empty.
Changed Q_ASSERT to QTC_ASSERT to not crash.
Change-Id: Ib03e21bb00ab989e00d5c3de68b52b84c6eb2360
Reviewed-by: David Schulz <david.schulz@qt.io>
Deployment was not working for subdirectories.
Path was not correct in projectInfo.importPaths.maybeInsert.
Change-Id: I4fd8a08ef6182c52963d6d76a700f4687abd9730
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
... by typeId().
Change-Id: Ib617db774cec2c23ac58bcd39d99a59f9820f443
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Linker-time-optimization flag should not have any effect on clangd,
so we may remove it from the compiler command line by default when
feeding clangd with the source files. gcc supports the
optimization level that should be applied for the relative binaries.
The level can be specified as the number N following by the -flto=[N]
argument. clangd meanwhile doesn't know about this option and throws
the 'Unsupported argument '1' to option '-flto=' error.
Task-number: QTMCU-163
Change-Id: I540438d8f4d006261e4cfda2bbba91984352db9d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We are not opening a webbrowser, so the old icon
might be misleading.
Change-Id: Ib782c80474b8d669684695a86913dfb4fbb84b49
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Qt Creator 10.0 may have saved "openTerminal.py" in its settings.
We don't used that anymore, so we convert it to Terminal.app.
Fixes: QTCREATORBUG-29246
Change-Id: Ifc67e6e7bbc7af5dfaf6703b3bd34ded847c5013
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
There is no advantage for an enduser to get errors on warnings because
he cannot do much about it. It is still nudging the developers to fix
the warnings.
Task-number: QTCREATORBUG-29238
Change-Id: If9f73f2766d686b119cd264ee7b3c3c9afa2c70d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
I think we introduced that because we had no valid checks in the methods
but exceptions. But after we check for every method for validity we
don't need it anymore. It would fix
093a842650 in a more optimal way. Needs
good testing!
Change-Id: I99b712c6526711836a760f3bb4031d4a9d51b935
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Remove useless lookups and make the code more clear. An enumeration
instead of virtual functions defines now the property type.
Change-Id: I5dc8704bdb24553e7b9c818562ea1c8de8ae2153
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
This message was mainly added for the QmlDesigner and DesignStudio.
It might be a valid warning under circumstances, but it may also
prevent valid use cases.
Turn it off by default and enable it for the QmlDesigner parts.
Fixes: QTCREATORBUG-29088
Change-Id: Id2c76efdf3fa419cfce71ad89360927241d41ac8
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
We copied QShortCutMap into Qtc to allow us tight control over which shortcuts
are "enabled" while the focus is inside a terminal, and the keyboard is "locked"
to the Terminal. Locked here means that except for a select few, all key presses
are send directly to the terminal and cannot be used to activate other actions.
Change-Id: I96cddf753033c0f4e7d806b20085bb4755853117
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Caching the graphics pipeline to disk improves puppet reset speed
somewhat when there are complicated 3d scenes.
Task-number: QTBUG-103802
Change-Id: I49b4f1031ab79bb5f660578e3d82806675f468dc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
