Avoids the attempt to start the client if nodejs cannot be
found.
Change-Id: I3783280120ca754291a92b3308c1192906facd08
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Fixes tst_build_new_project, tst_CCOM02 et al.
tst_tasks_handling fails which might be an actual issue, reported in:
Task-number: QTCREATORBUG-29209
Change-Id: I5eae54df27d8ba8f441e5b9c4acdaa2b41716245
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Inserting the name for the "commit" operation into messages relies on a
certain sentence structure and doesn't work with translations. Same for
"optional" error messages. Use different complete messages for the
different cases instead.
Avoid explicit line endings, use automatic word wrap instead.
Add some quotes and full stops.
Fix message with plural.
Don't use %n for constant number (inline in message with assert).
Improve confusing tool tip for instant blame.
Change-Id: Ic8453763279753ebd5898858951acddcf311e6e4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
The output stream should be flushed in order to forward containing data
and clear the stream buffer.
Task-number: QDS-9871
Change-Id: Iec9903a8afb98f3b9d03a9b9c4de67b6bfe3d35b
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This patch also includes a small update to skip creating 'shaderTool'
object in the json container if it doesn't exist in the qmlproject
file.
Task-number: QDS-9969
Change-Id: I1b8639c5e0a57aa77cbd417b51d57c1f4910613a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The stored container iterator, after container is modified,
may be already invalidated. Avoid storing the iterators and
do the search again after potential container modification.
Use QHash instead of QMap for faster insertions / lookups.
Amends 0135c47849
Change-Id: I0a4641d3b410836a5b3b9be252059e4e37fa94e3
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
The model is now deleting and changing the dependencies by itself. That
has the advantage of consistency. So if a node is now removed all the
dependecies will be deleted changing in the same way.
Task-number: QDS-9766
Change-Id: I1edf9ce172e51b9f52b62612ed2bb7386bf5b221
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
... for the case where the first line with semantic tokens has multiple
tokens.
This was not considered in the algorithm and uncovered by
d6f5d07639.
Also improve variable names and comments.
Fixes: QTCREATORBUG-29218
Change-Id: I0a1927c21edd70a3a91efc902e7e6ad2c734c91f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
For '.' properties we have to replace '.' with '_'. In any
case we have to set the instance value after the property
was removed back to the default value.
Task-number: QDS-9934
Change-Id: I0e52e40ccfdf976d53be90030c010cf131e9eca8
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
- Change an external link to point to the English language version
- Fix capitalization of product names
- Add a period to the end of a tooltip
Change-Id: Ia46709db9911c0a3bfad252db2ffe0b3f7e5f2d7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Amends 3dcdbe9069
Using the theme's PalettePlaceholderText only works for themes that
explicitly set it. Grab it from the application palette instead, which
is correct for all themes.
Observable by typing something into Locator and removing the typed text
again.
Change-Id: Iee7f900275ab7bcb37d87a2f7acddfee55fe9f79
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Rationale:
1. More descriptive.
2. More consistent with a planned new finishAllAndError policy.
3. Limits the possibilities of making a conflict with std::optional.
Change-Id: I5155630188e4b699e6c18b13a101e0e2d4fe98f2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Use QString instead of FilePath.
Rename the diffRecipe into copyRecipe.
Add some code that constructs the tree, connects to its done signal
and starts the tree.
Change-Id: I40e1c4784c736347682071b3e3e99db599ce102a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This usually is not a good idea, but might be useful for the embedded
terminal widgets.
Change-Id: Ifeeb47a38596ee789a503f3c7030da5a464569c5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The Qml*Node were never designed as a virtual interface but as handles.
Change-Id: I238476d7e8f40e9fdd672917aee7f06d832ddfd3
Reviewed-by: Burak Hancerli <burak.hancerli@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
If the parent is visible, we always want to show the child as well.
The previous implementation would always assume the row number to be a
top-level entry, leading to seemingly random behavior if any sort of
filtering was active.
Amends 778d7a9819.
Change-Id: I354c1b07929c45034a7d24b4c31f986ddd01c877
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This allows us to also port the link in the resource tooltip to
markdown.
Change-Id: Iec0e19ff68db76290139e457694485222f0a38f3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The database has to be locked because otherwise it is not thread save.
Because Sqlite connections are already called in different threads this
has to be enforced. The easiest way to lock a database is to put it in a
transaction.
It should be ok without locking so long the connection is only called
from one thread but I prefer to enforce it because I have already seen
code was preparing a statement not on initialization stage where it is
highly unlikely that there is more than one thread pre connection but in
the middle of the code. Because preparing is much more expensive than a
lock I prefer to enfore a lock here.
Change-Id: Id0b47f8d615a6697bb807392cafbe976bdd37233
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
A id with value zero is now invalid. So we offset the id value by minus
one. We had to check if the id is valid before adding it too.
Change-Id: I433772da0358ec48970313d89ea0b56e21f635e4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We need to set the range before the value, otherwise we
end up using the default maximum of 99 when setting it.
Change-Id: I93de2cade3c2884dab64f04a52b2d3e3db98e1c4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
There are many callback which do not control the flow and want to be
called for all steps. For that case we assume that a callback without a
return value will continue always.
Change-Id: I706123f2c425ac8c937d4d60ab977dae5ea9b030
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
