Not obviously better in this case, but I'd like to centralize
searching on the FilePath side.
Change-Id: I27cec97c0590cf27c3659b3aa262b86439670679
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... instead of having one. AspectContainer are de-factor (q)objects
with "fat" properties, conceptionally not much different from QObject
itself, so there's not real need to differentiate between the QObject
interface and the (forwarded) aspectcontainer interface.
As a side-effect, this saves one QObject base object per instance.
Change-Id: I6eefe739b3aebcef1ece196ff8d70aa36738997b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
A variation that does not stop on the first found item.
Useful for auto-detection scenarios.
Use "WithAnySuffix" as default to cover .cmd and .bat etc.
Change-Id: I48f36eff06699c046e34c8e2646546bcff20ae8b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This reverts commit ffd0f7306b.
Reason for revert: Breaks build. Revert is temporary, will be reapplied
after I6eefe739b3aebcef1ece196ff8d70aa36738997b is in
Change-Id: I5029f710656fb89eeaf65b55742678938f249aeb
Reviewed-by: hjk <hjk@qt.io>
Expose the factory, that's how most other places are organized.
Change-Id: Ia6e088b70a6c5ee3b18b67e852619e922c95f781
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
The HTML generator adds it automatically and qdoc warns about it.
Change-Id: I3917d7d23b16446e28ce7bfeb8f9195f21efd7fc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The qdoc command for arguments/parameters is \a. It is enough to
place it somewhere in the text to make qdoc happy.
Change-Id: I164fbd63277787a68b0216ad3fbbed768b975d91
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Case sensitive / case insensitive were set the wrong way around.
Change-Id: I7ed689684972aae5f6b1af2f35d9fd72d2df71e9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Calling displayProposal might spawn another eventloop that potentially
deletes the processor before the async proposal handler finished.
Fixes: QTCREATORBUG-28989
Change-Id: I3a8ddb9180cb7737a37ea39dc59d922e83615ed6
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Was broken in an impressive number of ways by latest Design Studio
merge.
Change-Id: I25f56827074a8c16a1a9c18884e1f63e8eaf6ef1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Remove unneeded #include and an unused variable that was scheduled for
removal for a while.
Change-Id: I5ec82a302ed20f14d46c665325cde7dccc9e3361
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Move the generic parts to session manager and let the project manager
save its parts separately via SessionManager::setSessionValue.
Change-Id: Iec2e81ea2488a15efc7333adb2b327761afdf274
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Avoid the detour through Environment::search* by copying and adapting
some code. Long term the Environment::search* functions may go
as FilePath is generally a better entry point into the remote
world nowadays.
Change-Id: I352d6fb68292d76f29a3454a786322bfe081d53d
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This removes the need to manual 'registerAspect' calls in most cases.
Whether the containers owns the registered aspects or just references
them is still determined by AspectContainer::setOwnsSubAspects()
Change-Id: Iadd17c919287f625bf5eb4964de4149d4da5a0f9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Add copy and move constructor ... to adhere to rule of five.
Change-Id: Ib56c229b45df2304694b51b4aa51aea8a20073d9
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
... also for place holder text. While this omission was apparently
intentional, the opposite behavior was used in the Beautifier settings,
arguably being a better standard as this makes clear to the user
that the pre-selected placeholder value won't be ok to use.
Change-Id: Iaf15b1351de929dee57329efdf18d7e831b4f8bc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
As a node or property is removed there are now callbacks to generate
node, properties and expressions which should removed or adapt too.
Task-number: QDS-9766
Change-Id: I6d842006a6282af00ff644ffaa0f3102e14f13fa
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
To fix a qdoc warning. However, qdoc cannot find the function to
bind these docs to in any header file.
Change-Id: I86b88bbd9e6f0731f8f79587981c46b720b4a91f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The notation was causing QDoc errors, and according to the developer
this is more like a comment to other developers than documentation.
Change-Id: Ibbf3f64252f164c361315f8ecf16e3422703bb1c
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Is useful when project contains large amount of targets and you have
to switch between them more or less often. Change also applies to other
tree views in selector but they are less likely to contain large
row counts.
Change-Id: Ic2cd920335adeef618d85202b3347a4cd042871c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
