- StudioStyle is implemented as an independent style dedicated to
QmlDesigner.
- QmlDesigner style part is removed from ManhattanStyle.
- Buttons are handled in StudioStyle.
- An standard palette is defined for StudioStyle.
- StudioStyle is applied to the application by QmlDesignerBasePlugin.
Task-number: QDS-9274
Change-Id: Id0a9040d82b6228a8fb215a416a916be116542bc
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
We used to run
{filePath("sed"), {"-e 's/.*: [[:xdigit:]]*:\\([[:xdigit:]]\\{4\\}\\).*/\\1/g' /proc/net/tcp*"}
on the device side but doesn't pass quoting on double-remote setups.
Chicken out by using a simpler for now command.
Change-Id: I7794f803d185bd4b6b717d85c01cc250cc66f1eb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
We very often want to remove a Qobject in a scope but because it has a
parent it can be deleted earlier. So using std::unique_ptr can lead to
double deletion. UniqueObjectPtr can track if a pointer is already
deleted. So no double deletion is possible but we still delete the
object in that scope. UniqueObjectPtr is based on std::unique_ptr but
uses a QPointer as internal pointer representation.
Because QPointer is not convertable you cannot cast from one type to
an other(QTBUG-112464). Because of that UniqueObjectInternalPointer
derives from QPointer and adds a conversion constructor.
Change-Id: I2c7707489f6db836cc5db2463efa8c33932b6455
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... only when there's a hope for it to help.
Change-Id: I0b7215af371515a1eec8420fdf59e60037584941
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If we cannot resolve an expression in the proper context,
we fallback to the root context.
The current context should be always a child of the root context,
but there are issues reported to be fixed by this.
Change-Id: I3f91641ea10fd0fa3bf22a93455e291013f5acc1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
DockerDevice::ensureReachable returned false in case a path was
already mounted.
Change-Id: I7b378a063dfe5380a1ead648f89911f2225c6338
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Closes the Terminal pane once the last terminal is closed.
Opening the pane again will also open a new Terminal.
Change-Id: I2f822b0058b26506250c784357ba522f29fd4078
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
When a user created a new folder with the same name as an existing
folder in that same location, the folder was not automatically
expanded.
Task-number: QDS-8866
Change-Id: I82ec4303a30d8f810417deea68b487e1b55833d5
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
This plugin depends on yaml-cpp, which enables exception handling on MSVC,
so the PCH is inconsistent.
Change-Id: Id098ea115d71d787192319a6fd0ef7f2addd7ec6
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Also, now delayed the finish part by 200ms so that 100% progress would
be visible to the user.
Task-number: QDS-9562
Change-Id: Ie8f87ff70770b206256d4dbf0c08227723067eeb
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Cloning the document that is needed to track the changes for the
language server is 3 times slower than just getting the whole original
document content and create a new QTextDocument with that content.
Presumably some additional information gets cloned that is not needed
for just the content tracking.
Change-Id: I4a7002b2ac97563f01dc3a67351b9363e9cc7b3f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The parent of the tool and status bar are widgets in icore. So they are
not deleted at the same time as the rest of the qmldesigner plugin. So
the connections are still there and you get dangling pointer. Deleting
them with plugin prevents this dangling connections.
Change-Id: I489d18c037c67ce34326651e693e74c4d951c261
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Replaces two duplicated pin.xpm in the pinnable debugger tooltip and the
qmleditorwidgets with the new icon.
Change-Id: I57b7adc5c0b92ffdf01da12dd832482d739cb86e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data
Change-Id: I35b981e544c66f818089b9e2d511a1b36ca86bfd
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
When clicking outside any view that has sections and a section's
context-menu is visible, it is now closed.
Fixes: QDS-9564
Change-Id: I73cd3a9754c5a18360427525a2a943c2c549e83f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
After the changes that made the texture icons downloadable, hovering
over the download button of a texture no longer showed metadata. The
reason is that the structure of the json metadata file changed a bit
-- now we have a top item with children "version" and "file_items".
Task-number: QDS-9575
Change-Id: Ib41d7871e3b3c0a0c759de5d0277c3ee7c974d4f
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
If internet is down, or, for some reason, the URLs are inaccessible,
then we should still show the existing materials and textures.
Task-number: QDS-9582
Change-Id: Ic9516c7bc00a37d1c3cd31643749f51a217bf317
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
The file node can be null if a new file was just added.
This worked before the 10.0 merge, but could be timing related.
In any case the check is good practice.
Task-number: QDS-9584
Change-Id: Ic01b763c6ba4466832316a454a12ccbdc1a6cc64
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The nullptr does crash. We can use a proper QmlJSQuickFixAssistInterface
created from the editor instead.
Task-number: QDS-9573
Change-Id: I5ea2792acb311c37e1005ff039ed7110503dfb4f
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The delegate triggers a commit and close already when
the focus is switched. So, the additional calls will
end up in a warning deep inside QAbstractItemView
and not processed.
Get rid of the obsolete calls and the warnings.
Change-Id: Ic27f6b1aa0b73f4bb82b0878650d8ae8ae8f87d2
Reviewed-by: hjk <hjk@qt.io>
