Commit Graph

68765 Commits

Author SHA1 Message Date
Henning Gruendl
224a2564d6 QmlDesigner: Remove option from restart list
Change-Id: I3bb28e8b65beddd96d757673f375021207a83ca2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-24 10:09:23 +00:00
Henning Gruendl
7613710727 ADS: Enable minimumSizeHint from content
* Fix minimumSizeHint handling
* Set DockWidget to not force scroll area
* Set background color on dock widgets
* Add setting to activate/deactivate minimumSizeHint handling
* Fix missing ADS changes from last merge
* Fix ADS comments

Task-number: QDS-10925
Change-Id: I7e8e0d2e7c3f9ee6636a2dc0796f6bd1fff3b2ee
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 10:09:11 +00:00
Miikka Heikkinen
3caac7bc67 QmlDesigner: Update icon gizmo positions on split toggle
Fixes: QDS-11021
Change-Id: I40472bd7c5766e5cf12782b760618371fddc3cc8
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-24 09:53:12 +00:00
Cristian Adam
5e3d14e2e9 CMakePM: Allow CMAKE_SYSROOT to be taken from the CMake preset probe
One could have a toolchainfile that sets the CMAKE_SYSROOT. We need to
be able to read the value later, and not just from the CMake Presets
cmakeCache array.

Task-number: QTCREATORBUG-29643
Change-Id: I63697219195b043813516c8214329ce583dc0676
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-24 09:13:50 +00:00
Christian Stenger
ddffbe676d Help: Do not allow opening temporary in Help mode
In case we have no documentation for an "F1 help request"
we display some temporary with a small hint. Disallow opening
this inside the Help mode to avoid triggering an open request
which ends up in a system dialog trying to open the temporary
local file.

Fixes: QTCREATORBUG-29371
Change-Id: If61c37eb2576cf6f9dcc70b58527a66b284b30f0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-24 08:15:50 +00:00
Eike Ziller
f811edf4a2 Help: Fix text of View > Show Left Sidebar check item
The text should never be "Hide Left Sidebar", because it is a checked
item. Just set the tooltip, like done in coreplugin/navigationwidget.cpp

Task-number: QTCREATORBUG-27733
Change-Id: I0cda56712724a69cb08411e62be57b88909416fe
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-10-24 08:10:05 +00:00
Leena Miettinen
1d64d764ac Clangd: Edit tooltip text for "Header/source switch mode" field
Use the phrasing "tends to find false positives" instead of
"has some bugs".

Add </p> at the ends of paragraph elements.

Change-Id: Ie524f2615625b52bf2de5b66b8938f49e3d0255f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-24 08:01:13 +00:00
Eike Ziller
bed9ed55c4 EditorManager: Native dialogs on macOS can't change their buttons
In this case we try to add a menu to a button.
"Native" is the default, so explicitly request a non-native message
box.

This is the message box that pops up e.g. when trying to open an
empty file foo.ui (the widget designer rejects to open it, Qt Creator provides the option to open with a different editor in the error dialog).

Task-number: QTBUG-118419
Change-Id: Iab3ee14593a55c2056303cfa16b99cea25893522
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-10-24 07:51:01 +00:00
Christian Stenger
f401d51a66 McuSupport: Fix dependencies and tests
There is nowadays a hard dependency on QmlJSTools as there is
need to access its QmlJSModelManager.
Beside this adapt the tests to reflect the Key / QString changes
happened inside the settings to avoid crashing the tests.

Change-Id: I71cd0457e5f567da28cc089b514655418bd60b7d
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-24 05:18:54 +00:00
Jarek Kobus
4645c713d2 GenericDeployStep: Fix rsync step
Don't use a copy of m_files for mkdirTask(), as m_files is
modified by the running recipe. So, when the recipe is prepared,
the m_files doesn't contain the right data, yet.

This is going to be refactored in master, as it seems the
isDeploymentNecessary() operating on mutable internals
is confusing.

Fixes: QTCREATORBUG-29609
Change-Id: I3f34584ffd9486322e8b26f95ac72b96a9306f8b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-23 15:31:59 +00:00
Christian Kandeler
8da7d88e3a ProjectExplorer: Fix restoring project dependencies
Amends d6fe357d81.

Fixes: QTCREATORBUG-29796
Change-Id: I7788b4e5c2477bb3edf9764b08cfa344a5e9c9c0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-23 12:52:53 +00:00
Miikka Heikkinen
ea7aca28c7 QmlDesigner: Store 3D split view camera angles per split
Splits 1-3 default to axis oriented views.

Fixes: QDS-10996
Change-Id: I111c9b76ae335f8630eeae5e51bbefb2e702f6df
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-23 12:18:33 +00:00
Alessandro Portale
76bcd85f21 WebAssembly: Avoid soft assert on toolchain auto detection
Windows only: When toolchains get restored on startup,
WebAssemblyToolChain would try to add MinGW to an environment. That
env is used for querying the compiler version. In order to find MinGW,
the MinGW toolchain is queried from ToolChainManager. But since the
ToolChainManager is not yet loaded at this moment, we get a QTC_CHEK
assert from ToolChainManager::toolChain.

This change prevents querying the ToolChainManager before it is loaded.
The compiler version can successfully be determined without MinGW in
path.

Whether we really need to query compiler versions that early is another
question outside the scope of this change.

Change-Id: I46edbb80edc58d7465e90e99f7f8381708f704a1
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-23 10:12:50 +00:00
Tim Jenßen
09f13dea04 QrCodeGenerator: enable by default
BUILD_DESIGNSTUDIO was introduced to have all
commercial plugins as a developer while
programming.
In packages its depending on which plugin goes
to which license and we did not had that for
libraries.

Change-Id: Ib02b166ea756c939e19f625c76207c07729f38bc
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-10-21 07:27:07 +00:00
Cristian Adam
423315178a CMakePM: Fix display of header / source files
Qt Creator will display the header / source files based on the
sourceDirectory of the target as base directory.

The source_group(TREE <dir>) will result CMake in making a source group
named "TREE" which should not be displayed in the project view.

Amends 9280f7f757

Fixes: QTCREATORBUG-23942
Fixes: QTCREATORBUG-29105
Change-Id: Ib71ffcc559376ea1596a5b21cb7e7fa779bd8d79
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 17:15:43 +00:00
Leena Miettinen
61088bba69 Fix UI text capitalization, punctuation, and phrasing
Change-Id: I41951660a464601063e5cedd417db2cb7cd37e44
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 14:55:38 +00:00
Alessandro Portale
76f082186e Android: Fix build dir for Qt6/CMake + changed LIBRARY_OUTPUT_DIRECTORY
The "proper" build directory is required during different stages of the
Android application deployment. For example in order to determine the
input .json file for the androiddeployqt launch.

If the CMake target has a modified LIBRARY_OUTPUT_DIRECTORY property, an
incorrect build directory was determined. This change adds a hack which
in such case (and only for Qt6 + CMake) tries to find the right build
directory, which also contains the .json file.

Fixes: QTCREATORBUG-26479
Change-Id: I24342f696aed7a322030eb9310d3ca71bcada81c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2023-10-20 14:08:56 +00:00
Cristian Adam
aef415a25d CMakePM: clang-tidy fix for 'move-const-arg'
See https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-
tidy/checks/performance/move-const-arg.html

Change-Id: Ic20445321286fdcb8b02e1b2cf170e0fe60fd1fd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:40 +00:00
Cristian Adam
55cccfa59e CMakePM: clang-tidy fix for 'no-automatic-move'
See https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-
tidy/checks/performance/no-automatic-move.html

Change-Id: If265c9b0e2aea49e5923f079cd621e10bb958286
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:34 +00:00
Cristian Adam
69815af272 CMakePM: clang-tidy fix for 'performance-implicit-conversion-in-loop'
Change-Id: I67e5adad19a3454986381c5548bbe96cf1cc1e6a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:28 +00:00
Cristian Adam
43121fa574 CMakePM: clang-tidy fix for 'perf*-unnecessary-copy-initialization'
Change-Id: I9c407f7254328e7278096239f6f3946c34e873d5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:20 +00:00
Cristian Adam
60de12efd2 CMakePM: clang-tidy fix for "performance-unnecessary-value-param"
Change-Id: Ia22d7c3fe6c29a5e0999145b6c4b281818dd72bf
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 13:57:15 +00:00
Aleksei German
6fcd0debe4 QmlDesigner: Improve percent Gradient support
- Changes default gradient units to Percents
- Adds percentage support to Radius properties
- Moves instanceValue checks into PropertyData
- Moves binding string assembly into PropertyData

Task-number: QDS-10942
Change-Id: I952aafa60e3b2e3221f74e5571516c2d4cbe7c02
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-20 13:39:10 +00:00
Ali Kianian
104a45a461 QmlDesigner: Add table buttons for adding rows and columns
Task-number: QDS-11003
Change-Id: I573921ab6f57d7854658086a46051c8650e5b23a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-10-20 13:15:31 +00:00
Christian Stenger
531fe36ac5 CMakePM: Silence warning
This is not handling the respective role correctly, just
silencing the warning. No change in current functionality.

Change-Id: Icd904941d5fc496d66b8e1eb7eec0031840f519d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-10-20 12:51:45 +00:00
Jarek Kobus
19511eaf1a BuildManager: Don't stop the run control being started
Fixes: QTCREATORBUG-29689
Change-Id: I65b5b6e94176ae2dcf09374755b4c3d70e844a3c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-20 12:43:48 +00:00
Cristian Adam
3d77369e4c ClangTools: Fix clang-tidy documentationUrl for version 17.x.x
Amends 51a650f30b

Fixes: QTCREATORBUG-29782
Change-Id: I4ce740900beb718d9628c35042b3467ec23de8d3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-10-20 12:05:14 +00:00
Amr Essam
96dfdfc0b7 QmlDesigner: Fix some parsing issues in effect maker
Task-number: QDS-10987
Change-Id: Ifeb42f9e04ba39ddaa45a03b60eb12ce1652c61a
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-10-20 11:45:44 +00:00
David Schulz
a18ea390e1 LanguageClient: Fix crashed client restart condition
Change-Id: I4b0195a512b6b1dcbcc6fd02f6014a27b4606ea0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-20 10:47:44 +00:00
David Schulz
5f45c36b6f TextEditor: do not scroll to cursor postion on select all
Since Qt 6.5.1 QPlainTextEdit::selectAll emits correctly
cursorPositionChanged on selectAll which calls some multitextcursor
update code on our side. Avoid setting the cursor back to the
QPlainTextEdit in this update code by setting the expected
MultiTextCursor before calling selectAll.

Fixes: QTCREATORBUG-29763
Change-Id: I77f05ac40a9dd126efcd72089a699c908c68da21
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-20 10:47:34 +00:00
hjk
fe129cc0c4 CMake: Reduce number of FilePath conversions in fileapidataextractor.cpp
Change-Id: If143843782b0bfdbdd68ab1a387d0feabfb60a33
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-20 10:27:57 +00:00
Miikka Heikkinen
3d53bd6b80 QmlDesigner: Fix quaternion compare in OriginGizmo in 3D view
Change-Id: Icefb7fb75e8dfd229a9b13028fa8f00f774be68b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-10-20 10:20:18 +00:00
Ludovic Le Brun
26b2a755a8 Fix install .so plugins
Remove the period from the file extension .so because the completeSuffix function of the FilePath class does not return the first period of the extension.

Change-Id: Ifd850e54337c399d6440b6ad765c3b23df9ed330
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-20 10:08:34 +00:00
Burak Hancerli
ab2c25d52a QmlProject: Absolute files paths are ignored
This patch fixes issues with adding files to the project by
providing the absolute paths in the .qmlproject file.

- If a directory is given without an explicit file list,
then that directory wil be searched recursively.
- If explicit file list given without a directory, then each
file will be added to the project separately.
- If both provided, then each file wil be prefixed with given
directory, and added project separately.

Task-number: QDS-10636
Change-Id: Ia13964ce2b3f6364d1def1aa71e20ec29f6f3542
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-20 10:08:24 +00:00
Cristian Adam
32b6e6309e CMakePM: Remove remainders of extraGenerator
It was not possible to set the toolset for Visual Studio 2022 generator.

Amends 4f26d802ca

Change-Id: I56caf9c0d66812eb599646a3679602af7372f419
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-20 10:07:17 +00:00
Eike Ziller
fbe9f2c614 Docker/Tr: The state is "shut down", two words
Change-Id: I62b47e4d3f7e9a0e22a086ee8db743bb004a0ac3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-20 09:46:08 +00:00
Alessandro Portale
1824db503e Utils: Restore original default DPI rounding policy
Qt Creator 11.0.2 changed the default DPI rounding policy to
"PassThrough" for Windows. In QtC 12, there is now a setting that allows
the user to chose the policy. The default was changed to "PassThrough"
also for Linux.

This change sets the default back to the original policy "Round" which
Qt Creator used from the beginnings of HighDPI support.

Amends: 3726f0d6c1

Change-Id: I74f2310f1b5379c8dea0bf86aee965374ca2732e
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-20 09:42:29 +00:00
Eike Ziller
9df0571ff9 VCS/macOS: Fix message box when closing submit editor
When using the "Close" and "Cancel" standard buttons, it is no longer
possible to change the button text on macOS. Additionally, the behavior
on pressing <esc> is broken when using QtC in german (it should just
close the dialog == cancel, but in german it triggers "close").

Task-number: QTBUG-118241
Change-Id: Ia35e6a29cd97fb91552dc5600f91be8b8e443f39
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-20 09:08:06 +00:00
Jarek Kobus
b3109755e6 Tr: Fix some source texts
Don't use exclamation marks!
Add "the" articles (conforming to the other source texts).
Finish error sentences with dot.

Change-Id: I1faa547e2c3bae90ea900b781eccf327ea810326
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-10-20 09:07:20 +00:00
Marcus Tillmanns
3f647a4bc5 Debugger: Fix lldb fetchFullBacktrace
Change-Id: Ib0a513ecd6c0a0094797fe987aeaddc57d0b5149
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-20 07:43:06 +00:00
Christian Stenger
ada1a7b1c0 LanguageClient: Fix qbs mingw build
Change-Id: Idb7102597a9a7cdf8a8cd5cd1ce249770e559c16
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-10-20 07:03:05 +00:00
Cristian Adam
105fd8becb CMakePM: Add "share" for CMAKE_PREFIX_PATH for completion
This would allow packages from vcpkg to be found.

Change-Id: Ie0921d9ed6cfe692bc18235bfaf678ede5c98e14
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 18:55:26 +00:00
Cristian Adam
a071d4354a CMakePM: Save CMAKE_MODULE|PREFIX_PATH in cache for vcpkg
This would allow the user to see the paths set by vcpkg.

Change-Id: I6d4ed9a9c69c2296851c8f8363b78d5adb7d2723
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 18:55:17 +00:00
Cristian Adam
cdc7857572 CMakePM: Search for Config modules also in CMAKE_MODULE_PATH
This is allowed by `find_package`, and can be tested with the `fmt`
package provided by conan.

Change-Id: Ib9bf2a6cbd80b8eb322cb6d8a1a9c25af0ca4031
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-10-19 18:55:09 +00:00
Cristian Adam
b5d0c5dd36 CMakePM: Save CMAKE_PREFIX|MODULE_PATH as cache variables for conan
This way it's visible in the project settings where the Conan paths are
added.

Change-Id: I95aa59c836bf3b9ed122e9bffdd61b0dd3c7354e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 18:55:00 +00:00
Miikka Heikkinen
4f893d0a7d QmlDesigner: Fix NodeHints::isValid() checks
Evaluating some properties of NodeHints is needed even if there
is no valid model node yet, i.e. when the hints have been created
from ItemLibraryEntry.

Fixes: QDS-10997
Change-Id: I321b89167530993d793b2c7beece7037093555f0
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-10-19 14:57:14 +00:00
Ali Kianian
83c33233ff QmlDesigner: Select relevant collection and source
Task-number: QDS-10621
Change-Id: I836ca523469bce500d93b4ff0680c1ae0ef6c12c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-10-19 14:29:02 +00:00
Christian Stenger
66d94a82a3 QmlPreview: Do not act on any editor / document change
If no preview is running there is no need to process anything.
In theory the basic connections inside the plugin might be
better properly done and explicitly connected and disconnected,
but I wanted to avoid an intrusive change after the beta.
Fixes ongoing message box displaying when editing a qml file.

Kind of amends 5336fd83a0 as it
revealed this misbehavior.

Change-Id: I5081e1c7d2154e3cc75ad9da32af1b0c7f86dff2
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-10-19 13:44:28 +00:00
Jarek Kobus
b706fab6c6 Ios: Fix synchronization
This fixes the synchronization on early shutdown, e.g. when
Creator is started with "-test Ios".

Change-Id: Ia18215a090809b6095d51ee3647728b4b2ad2d5f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-10-19 13:22:24 +00:00
Eike Ziller
24ed69b2ec LanguageClient: Simplify group box title and fix "JSON"
It already under a title "Language Server", no need to repeat

Change-Id: Ib0da722dfdaede194e48fa5f0ff3948ec0f16842
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-10-19 13:00:23 +00:00