Commit Graph

67787 Commits

Author SHA1 Message Date
Alessandro Portale
6aced79f18 Android: Build fix #2
Change-Id: I1ea4d753889d3da8c357d0a388af1c04797b0759
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-09-11 11:40:41 +00:00
hjk
57f5fbbf57 ClangTools: Do not try to kill subprocesses syncronously
Task-number: QTCREATORBUG-24627
Change-Id: Iec0169335d62435c017e39f252be3d7ca470d2d4
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-09-11 11:31:01 +00:00
Alessandro Portale
651cbfece7 Android: Build fix
Change-Id: Ia5f2118971ae6a7d0c13b8ea82c146b0b678b848
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-09-11 10:50:49 +00:00
Cristian Adam
fc542c7631 Unittests: Remove external dependencies
External dependencies are targets built for Qt Creator e.g. Utils
unittest is building everything for itself.

It also fixes the MSVC building with PCH.

Change-Id: I7bca1e150f6890ea85f30efda5642f9242a7c9b5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-09-11 10:16:15 +00:00
Assam Boudjelthia
e9c9440653 Android: allow passing apps arguments via manifest on non-debug mode
Uses 00a1e5da7e1aea373a7e6be1d51e1573ff167dd8.

Task-number: QTCREATORBUG-23712
Change-Id: I9a7e134420b608815589578f3851abf150674fd3
Reviewed-by: Ville Voutilainen <ville.voutilainen@qt.io>
2020-09-11 10:00:32 +00:00
Henning Gruendl
3afc21052f QmlDesigner: Fix unintentional item reordering
Fix reordering of items in the Navigator if using shortcuts on a
SpinBox in the Property Editor.

Task-number: QDS-2738
Change-Id: Ia12d2d072c36fbb32156c9729cffd828e8747b28
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-09-11 09:47:38 +00:00
Marco Bubke
0f9010d381 QmlDesigner: Introduce multiple node instance server
For capturing data we need a atomic mechanism. So in one
process multiple node instance server can be started and
then a command is send back that a scene is created. It
can be used to ensure that captured data of views is
up to date.

Task-number: QDS-2630
Change-Id: Iea8d0b036b6384c9c1b0f91af401f2b1f1978c12
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-09-11 08:57:42 +00:00
Mahmoud Badri
29bc4801e3 QmlDesigner: Display only file names in comboboxes
Full paths are displayed in tooltips. Also add a check mark to
the selected item in the combobox's pop up.

Task-number: QDS-2405
Change-Id: I69cbd4200a73183b4e747c87e9dd8197fc650ed7
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-09-11 08:40:18 +00:00
Dominik Holland
a535196c41 Add support for multiple Qt versions in "Load QML Stack"
Enable the functionality for cdb again.

Change-Id: I75405f830dd208cc110d6682a45beedf2f4199cc
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-09-11 08:11:21 +00:00
Kai Koehne
0773a0fb66 Autotest auto tests: Fix license
No point in using a commercial-only license here.

Change-Id: Ic8f38c4a09dcfaf6c1a537bdfd97cb9eedf50dd8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-09-11 07:49:43 +00:00
Miikka Heikkinen
8dbe3fe61f QmlDesigner: Add navigator preview tooltip for images and textures
Show custom tooltip for image and texture items that shows the source
image.

Task-number: QDS-2750
Change-Id: If8c491f513d9fcada74300206d6cbc3af80c7663
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-09-11 07:38:13 +00:00
Miikka Heikkinen
0b6be2f93d QmlDesigner: Update resources file system model on model attach
Removed the update from old places.
ViewManager::attachItemLibraryView one was never called and
the other DesignDocument::updateFileName one gets called incorrectly
on any file rename, not just the currently open one.

Change-Id: I822ced6fe32dd9625d605e33046c808eb2272028
Fixes: QDS-2721
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2020-09-11 07:36:06 +00:00
Andy Shaw
e35af70d98 Android: Use c++_shared for STL as cxx_shared is not correct
This fixes a parsing problem from CMake as it will state:
"Invalid Android STL: cxx_shared." This amends
01b0d4f8f5

Change-Id: I315d36eac889ba53d76055814c6b43a453e1e2f7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2020-09-11 07:34:11 +00:00
Kai Koehne
90a4e8d3d0 Nim: Fix plugin metadata
The actual source files say it's Commercial OR GPLv3+Except, so
make the plugin information reflect this.

Change-Id: I867b3a27fb903719d30e32bf28418700f2c02bc5
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-09-11 07:24:00 +00:00
hjk
d09ea40c25 CMake: Fix several issues with the CMakeBuildStep
- Store the selection of the "Current executable" target again
  (broke apparently with 2c822ae3)
- Display the resolved target of the "Current executable" seletion
  in the command line, instead of the fixed "
   '<Current executable>' text
- Make the "Current executable" translatable
- Add a tooltip explaining what it is
- Use a Utils::TreeModel instead of a QStandardItemModel for the
  target model
- As side-effect, searching in the target view using Ctrl-F seems
  to magically work again.

Change-Id: Ia4d0913f6e586f49f74da66651a9177437dad6d9
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-09-11 05:00:04 +00:00
Christian Stenger
512c0381f3 Nim: Fix handling of project settings
Removes unused duplicate of nim specific project settings
and uses the nimble specific project settings additionally
inside nimble projects.

Change-Id: Ibbda76ab41538a0ebdf0a395503c519fcac93460
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-09-11 04:56:15 +00:00
Jeremy Ephron
495c08a3eb Debugger: Don't hardcode dumper module names
Changed the dumpermodules list to be dynamically retrieved as all
<module_name>types.py files instead of a hardcoded list. I don't know of
any reason it should be a hardcoded list, and this allows for more than
one custom extra dumper file instead of having to specify one extra one
and/or use personaltypes.py. It seems strictly better.

The code used is confirmed to be compatible with all versions of Python.

Change-Id: Ic1988961d5cb7e6523e84afdd0e6c4ed2993ac97
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-09-10 17:53:25 +00:00
Cristian Adam
b9445d5627 Clang 10 build fix
Qt Creator 4.13's code model and Clang 10 compiler complain like:

error: constexpr variable 'LocalSocketErrorFunction' must be initialized
by a constant expression

Change-Id: I9c0160823f9f3708253ebea398caae680eacab11
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-09-10 15:54:30 +00:00
Alessandro Portale
b6e4c9e133 Android: Remove some unused functions
Change-Id: I5c6549ed931b5132898abd6ce519560851838e65
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-09-10 11:38:50 +00:00
hjk
753c6812e2 Nim: Add a summary updater to NimbleBuildStep
Change-Id: I227b11ff90595b47568869b85f854350c5e90619
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-09-10 11:05:12 +00:00
hjk
da5852a3b3 ProjectExplorer: Remove ArgumentsAspect::argumentsChanged signal
The base Aspect::changed() is good enough.

Change-Id: Ib660e06cf4240198f7f73948ea0922a11568d4a2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-09-10 11:05:05 +00:00
hjk
ec75575e64 Nim: Rework NimbleTaskStep
Use StringAspects for m_taskArgs and m_taskName.

Change-Id: I69496029e3f414012c06e8217debfe2507d75cc6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-09-09 13:52:51 +00:00
Leena Miettinen
2e1eed1945 Doc: Add list to words to ignore for automatic linking
Change-Id: Idfa50889deeff64a8d97bfbb5deaf4c86a32e2bf
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2020-09-09 12:45:19 +00:00
Leena Miettinen
7b2dbc0cde Doc: Update info about exporting assets from Adobe Photoshop
- A button icon changed.
- The Asset format & scale settings were not described for
  Photoshop export

Change-Id: Ib446558ace6e7bbd417f0a78f311b5a8cee0b099
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2020-09-09 11:58:21 +00:00
Christian Kandeler
1e452f1ad3 QmakeProjectManager: Compare the right set of arguments
... when determining whether to re-run qmake.
We need to look at the effective arguments, not the user arguments.
Of course, the whole approach is still a shaky heuristic, but it should
be more correct now than it was before.

Fixes: QTCREATORBUG-24538
Change-Id: I763f8095becacde0f9549890161b8a47c6344b6b
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-09-09 11:34:23 +00:00
Leena Miettinen
d64430b882 Doc: Make "Exporting QML" topic visible in Qt Design Studio Manual
The Build > Export QML menu item is available in Qt Design Studio

Change-Id: I5f29410de5d6d13c427b9907937c4d82e111fe06
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
2020-09-09 11:32:02 +00:00
Christian Stenger
24f35037d1 LanguageClient: Fix regular expression
The match has to be a full match to avoid always validating
the full file if located at a literal.
This fixes bad performance of language clients in big files.
Amends 119a3c1ce9.

Change-Id: I7153f3d7d7125715846de7626d215093feae2908
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-09-09 10:44:05 +00:00
Christian Kandeler
d7229d4afc ProjectExplorer: Fix restoring parent toolchain
... for auto-detected clang toolchains on Windows.
We must wait until toolchain loading has finished before determining
whether the parent toolchain still exists.

Change-Id: I4d9ed3e1d7df47dd4b2b408c70d796c8972c9a54
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-09-09 09:48:34 +00:00
Vikas Pachdha
f7634fc738 Doc: Add Qt Bridge import documentation
Change-Id: Iab73c53c4f128f54ebd4938ad24d0febb8705784
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
qds/v1.6.0
2020-09-09 09:33:28 +00:00
hjk
bd31ba0e09 CMake: Slim down CMakeStep interface
Change-Id: Ia2cce411647e434a9edd7ef2b66a187bad6d8c12
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-09-09 09:18:52 +00:00
Christian Kandeler
90a18fe7fa ProjectExplorer: Fix ToolChain::isAutoDetected()
Amends d116559cd8.

Fixes: QTCREATORBUG-24545
Change-Id: I3a6c198a6ef2db91c4c3eb75721657e0c491e665
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-09-09 08:30:17 +00:00
Leena Miettinen
dd105095e9 Doc: Fix broken external links
Change-Id: Ifc167cf0e345c6d553a4224d3ea45b163fea45a8
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
2020-09-09 08:23:26 +00:00
Leena Miettinen
fad2820e24 Doc: Hide breakpoint settings from Qt Design Studio Manual
The link targets are not included in the Manual.

Task-number: QTCREATORBUG-24500
Change-Id: I1d0bd94bf41fb612b5584366c02d1ee6de74b6e1
Reviewed-by: hjk <hjk@qt.io>
2020-09-09 08:22:25 +00:00
hjk
4964d0bf81 CMake: Use StringAspect for cmake arguments
Change-Id: I18e9af5f630a2b0a11a427848368c9f980819717
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-09-09 06:50:17 +00:00
hjk
61bfd32438 ProjectExplorer: Introduce a ProjectConfiguration::kit() function
For convenience, and use it in some places.

Change-Id: I8f7cb502b37b2fbf4cf2d17cac9c6299558332dc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-09-09 06:27:21 +00:00
Eike Ziller
552a1296fe Fix crash in KSyntaxHighlighting
In contrast to QString::midRef/QStringRef::mid, QStringView::mid
crashes/asserts when being passed values that exceed the string length.

Amends 6b9cad8b05

Task-number: QTCREATORBUG-24098
Change-Id: Icc53a5dc3bcbc881e614140d4084bdea2bfab59d
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-09-09 06:23:07 +00:00
Eike Ziller
03db57f524 DiffEditor: Fix Qt6 build
QStringRef is gone. QStringView::split is not available until Qt6.
Since using a ref/view might actually have a performance impact in this
case, work around this with a typedef to the available type.

Task-number: QTCREATORBUG-24098
Change-Id: I72dcb4a9c93b73e396dfb9a2760af924db809eaf
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2020-09-09 06:03:10 +00:00
Vikas Pachdha
81b6e06448 StudioDocs: Update Photoshop bridge plugin images
Change-Id: I71d6235e7aa5eb74b73aa2303e6e01008ddd6d8c
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-09-08 17:33:07 +00:00
Christian Kandeler
58e633a8a4 CppTools: De-duplicate list of include paths
It makes more sense to handle this centrally than in all the build
system plugins.

Fixes: QTCREATORBUG-24515
Change-Id: I1c0f815d44135bcfb76ce51c67b6494a50e1de48
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-09-08 15:52:22 +00:00
Jeremy Ephron
acd33f747d Debugger: Fix crash for std::vector<bool> on LLDB
Missing call to `.integer()` for the vector's size on the LLDB (libc++)
code path leads to a garbage size value and a failed size check. Fix is
to add the missing call `value["__size_"].integer()`.

Change-Id: If2113514fec02d9de248c1b4d3b0baea4f7ee5d2
Reviewed-by: Jeremy Barenholtz <jeremyephron@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2020-09-08 14:47:45 +00:00
Christian Kandeler
e778283b08 ProjectExplorer: Filter out non-applicable toolchains
... when filling the "parent toolchain" combo box for clang on Windows.
We should not offer the user a mingw C compiler as the parent of a clang
C++ compiler. Even though it will probably work (as it's mainly there
for the sysroot), it's conceptually weird and it blows up the number of
entries for no good reason.

Change-Id: Ic920993b4ff36f8d8d095392555dc9d27f376878
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-09-08 14:04:13 +00:00
Christian Kandeler
570e452b18 ProjectExplorer: Fix ToolChainManager::isLoaded()
The presence of the accessor object does not indicate that the
toolchains have been restored, just that the restore process has
started.

Change-Id: I2ae3e3b091ebeab3ad4b401a1d8dcdb6a72e1408
Reviewed-by: hjk <hjk@qt.io>
2020-09-08 13:50:25 +00:00
Eike Ziller
d8c3487037 Help: Fix compilation with Qt6
Adapt to size type and QFont::weight() changes.

Task-number: QTCREATORBUG-24098
Change-Id: I580601433c9f81b7675b806d5eb2c55ee3060011
Reviewed-by: hjk <hjk@qt.io>
2020-09-08 13:45:53 +00:00
Miikka Heikkinen
92f9502f56 QmlDesigner: Fix image id generation for names starting with digit
Change-Id: I763e8b49d0b8dd3274bea79d61156321185706a5
Fixes: QDS-2759
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-09-08 12:59:20 +00:00
Leena Miettinen
4690f7c914 Doc: Update information about importing 2D assets using Qt Bridge
Change-Id: I2ac7ec1fe65a3e34b7174bac5fba7bbab0efa783
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-09-08 12:54:50 +00:00
Christian Stenger
158ac2d339 Nim: Fix running when building with nimble
Change-Id: I62b2eebf408119a19f0e98958e3132c16c9c6aa5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-09-08 11:58:24 +00:00
hjk
79010891e1 Debugger: Drop clang and llvm revision from LLDB version number
They are mentioned as separate lines in the lldb --version output
for self-build lldb binaries.

Change-Id: Ib0d6e46874ad5b576ac20a6aeab823d51571c0f2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-09-08 10:59:05 +00:00
Johanna Vanhatapio
34e5b2d0ab Doc: Update info about materials
Fixes: QDS-2753
Change-Id: I74eb64552af4ef0b222f8949291d7f6b34f0dbbb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
qds/v1.6.0-rc2 qds/1.6.0-rc2
2020-09-08 10:54:10 +00:00
David Schulz
44271262d9 LanguageClient: Fix crash after server shutdown
Unconditionally reset the assist provider even to a null pointer

Change-Id: Ie8f87802ab26b4a686704b792adc726a50f98bab
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-09-08 10:41:58 +00:00
David Schulz
9055cb9843 TextEditor: fix text prefix check
Change-Id: Ib4b2039fe126fd10e8a5cb8961ccec08c1d1ea7b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-09-08 10:25:24 +00:00