forked from qt-creator/qt-creator
ProjectExplorer: Remove ArgumentsAspect::argumentsChanged signal
The base Aspect::changed() is good enough. Change-Id: Ib660e06cf4240198f7f73948ea0922a11568d4a2 Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
@@ -63,7 +63,7 @@ public:
|
||||
+ ' ' + usedExecutable + ' ' + args);
|
||||
};
|
||||
|
||||
connect(argumentsAspect, &ArgumentsAspect::argumentsChanged, this, updateCommandLine);
|
||||
connect(argumentsAspect, &ArgumentsAspect::changed, this, updateCommandLine);
|
||||
connect(exeAspect, &ExecutableAspect::changed, this, updateCommandLine);
|
||||
updateCommandLine();
|
||||
}
|
||||
|
@@ -120,7 +120,7 @@ NimbleBuildStep::NimbleBuildStep(BuildStepList *parentList, Id id)
|
||||
QTC_ASSERT(buildConfiguration(), return);
|
||||
QObject::connect(buildConfiguration(), &BuildConfiguration::buildTypeChanged,
|
||||
m_arguments, &ArgumentsAspect::resetArguments);
|
||||
QObject::connect(m_arguments, &ArgumentsAspect::argumentsChanged,
|
||||
QObject::connect(m_arguments, &ArgumentsAspect::changed,
|
||||
this, &NimbleBuildStep::onArgumentsChanged);
|
||||
}
|
||||
|
||||
|
@@ -281,7 +281,7 @@ void ArgumentsAspect::setArguments(const QString &arguments)
|
||||
{
|
||||
if (arguments != m_arguments) {
|
||||
m_arguments = arguments;
|
||||
emit argumentsChanged(arguments);
|
||||
emit changed();
|
||||
}
|
||||
if (m_chooser && m_chooser->text() != arguments)
|
||||
m_chooser->setText(arguments);
|
||||
|
@@ -113,9 +113,6 @@ public:
|
||||
void setResetter(const std::function<QString()> &resetter);
|
||||
void resetArguments();
|
||||
|
||||
signals:
|
||||
void argumentsChanged(const QString &arguments);
|
||||
|
||||
private:
|
||||
void fromMap(const QVariantMap &map) override;
|
||||
void toMap(QVariantMap &map) const override;
|
||||
|
Reference in New Issue
Block a user