Most of it is only silencing a warning but one is fixing a faulty test. So
writing null values should now be working.
Change-Id: If702e1fc8176a9e0ae82a5589c719d567929202b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
* Add support for showing the dialog title of a flow decision in the
flow view.
* Add preconfigured positions for the label to be placed.
Task-number: QDS-2248
Change-Id: Ib113ac44e9bdc084d18a3a6083b767487bd9cde2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The refactoring option was not triggered if the operator definition had
a different amount of whitespace after "operator" than the declaration.
Fixes: QTCREATORBUG-6236
Change-Id: Idf6438203e28d3f1effe0a0375d6563f813a9726
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
- Variant and alias types proper support
- Extended instantiation options for Editor
Task: QDS-2264
Change-Id: I95ff24fb81ce64b4effc64803304ff2b150a7ff6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Get rid of magic configuration handling in the CMakeProjectManager.
* Use CMakeCache.txt as the sole source of truth, do not keep
a shadow copy of configuration in the .user file
* Have initial CMake arguments that are easy to edit in batch
(Fixes: QTCREATORBUG-18179) used whenever no CMakeCache.txt
file is in the build directory. These allow for any thing that
can be passed to CMake on the command line.
(Fixes: QTCREATORBUG-16296)
* Ask when changes to CMake configuration were not applied
(Fixes: QTCREATORBUG-18504)
* Run cmake with arguments effecting its configuration only when
the CMake settings are changed in the UI, run CMake without any
special arguments in all other cases.
* Get rid of the confusing dialog used to keep settings in sync between
what is in CMakeCache.txt and Creator (Fixes: QTCREATORBUG-23218)
Change-Id: I26d55be7df733f084f5691ecf7d7b4352f58b8e7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
When dragging a 3d effect from item library to navigator, if the
parent node is a View3D with SceneEnvironment, or SceneEnvironment
itself, also add the effect to the SceneEnvironment's effects list
inside the same transaction.
Change-Id: Ib7cfd312efabaabb2a1e877fa662feaeb8ee3ac6
Fixes: QDS-2200
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Order of the notifications caused obsolete imports list to be used when
possible imports list was updated, so explicitly update possible
imports on imports change handling, too.
Change-Id: Iea1ae4deecd84c35114a613098e7e5bcf2e86762
Fixes: QDS-2199
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
QmlJS resolves available libraries at its own pace on the background,
which means all possible imports are not necessarily known at the time
the model is attached.
Listen to QmlJS::ModelManagerInterface::libraryInfoUpdated to trigger
reload of document when available libraries change to keep
possible imports list up to date.
Change-Id: Id605a6ee1fe2c43735bb30c9446d2a31ef52fe99
Fixes: QDS-1592
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Each qml document has its navigator tree expand state cached at
model detach and the state is restored at subsequent mode attach on
the same document.
Change-Id: I93ff71f500abde44fcc829f53baefc40b68981f6
Fixes: QDS-2222
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Store the last active scene in global 3D tool state and restore it
when a scene is created after puppet relaunch.
Change-Id: Ie2d69f6db6798ab383c66d38b2dea7eba13adc97
Fixes: QDS-2239
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
It's sometimes hard to tell which scene is shown in 3D edit view, so
added the scene id to the upper left corner of the view.
Task-number: QDS-2239
Change-Id: I5999e41c3f92028cd9a0f79ae0c8b72263d9ce42
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
The functionality was already there, but it didn't work, because
non-invokable function was called from qml.
Change-Id: I3e814b859d6f88836476de7aca12bc929aec31d6
Fixes: QDS-2142
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
When dragging a property on itself inside a "oneline" item
Qt Creator prefixes a single whitespace even if it contains
already whitespace(s).
Change-Id: I3028d8c44d9b91d51c96a6d363e48a877a6a78da
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Change hasActiveTimeline QML context property setting to be based on
current timeline change notifications instead of timeline node
creation, as the timeline will not be valid at the time of the node
creation. That also failed to detect timeline deletion.
Also fixed the timeline logic to clear current timeline from model
when the timeline is deleted.
Change-Id: I9191300c964bc624a958003b6aa0d5d9e77ddf9a
Fixes: QDS-2139
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
MouseArea.containsMouse gets confused when the mouse input gets grabbed
by an overlapping 3D mouse area.
Change-Id: I6ee69f217d95c5e4f3f5361e14c932ce0a2feab0
Fixes: QDS-2187
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This fixes the warning that comes when using "myvec.x: 10" style of
defining qml vector*d properties.
Task-number: QDS-2189
Change-Id: If77373a4dd8483b65dd782502efb774b95844583
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Some QtQuick3D effects specify colors as vector3d. Added support for
vector3d colors to ColorEditor. Support can be enabled by setting
isVector3D property to true. The colors are still displayed as
regular "#ffffff" style color strings in the ColorEditor.
Task-number: QDS-2114
Change-Id: If62152b0351e452d753eb6da9d90cd59fe2c4c59
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
When drag-adjusting e.g. brightness or position of the object in 3D
edit view, the value ending up in property editor and qml doc didn't
always match what was displayed on 3D edit view. This happened because
ValuesModifiedCommand was compressed to 100ms intervals, but any
property changes also sent ValuesChangedCommand at 16ms interval,
which changed the instance value at backend, but not the model value.
Fixed by comparing modified value to model value instead of instance
value.
Also made the 100ms compression timer singleshot, so the backend
wouldn't be unnecessarily bombarded with ValuesModifiedCommand when
holding the mouse still while dragging.
Change-Id: If86dcd61bcf0c04735d65648e4c34d9d214c5313
Fixes: QDS-2081
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Add support for configurable size and radius of decision and wildcard
items in flow view.
Task-number: QDS-2246
Change-Id: I4198828b5e4167a03ec7836ff11dbb1add77602e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Labels went under IconGizmos, so increased the z-value to match that
of MoveGizmo label.
Change-Id: I2620db0cadfadc73808a3a9f9967aadf87c9a863
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
If timer is not restarted on each request, the update can end up
happening before the next frame has been rendered. This can happen e.g.
at puppet startup, where the delay between first request and first
frame render can easily be more than 16ms.
Change-Id: Ib9555548e8c60799c585d0ab43d0626cfa31a494
Fixes: QDS-2082
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Also changed the point light mesh to just a single camera plane ring
based on discussions with UX.
Change-Id: If9e847440570bbe87483194c0b417cf09c7084a2
Fixes: QDS-2041
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Inner cone visualization for spotlight was added, as well as drag
handles to adjust inner and outer cone angles and fade.
Fade handle adjusts fades in order: quadratic, linear, constant.
If a specific fade value is zero, the next one in list is chosen
for adjustment.
Change-Id: I921936d9782de511558bc6c24cfa0953cce494f0
Fixes: QDS-2038
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Brightness can be controlled by dragging on the brightness indicator
arrow of the light gizmo in 3D edit view.
Change-Id: I317f5ee08b59bcc0bebf3fdf59861df15ef13c84
Fixes: QDS-2039
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Directional light model was made constant size, as it doesn't have
actual physical presence.
Spot light cone now shows the cone angle correctly and the length of
the cone is calculated so that 5% of the brightness reaches the
center of the cone bottom.
Area light rectangle matches the area of the light.
Point light mesh changed to three perpendicular circles.
Same formula for size of the circles used as for spotlight length.
All light types share a common brightness indicator arrow.
Task-number: QDS-2037
Change-Id: I534dbcda9cfa2a7768c2537868ba83818979b250
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
C4065: switch statement contains 'default' but no 'case' labels
This amends commit 6079a317b9
Change-Id: I90dc72702d8b8d4c1dbcb08f78f67c8ddf9f6717
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Evidently, it's not enough to call setFocusPolicy(), one also needs to
pass a special WindowType flag.
Fixes: QTCREATORBUG-4267
Change-Id: Ic2f377aad9a859443c79b375242bed2166301a3e
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
When dragging a member inside or onto a "oneliner" item a
duplicate semicolon can appear which makes the code invalid.
Fixes: QTCREATORBUG-12560
Change-Id: Ifa824a64b951fde879625d321dfae48e167a9227
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>