Commit Graph

67787 Commits

Author SHA1 Message Date
Denis Shienkov
0c6386a548 BareMetal: Auto-detect IAR toolchain for Renesas M32C architecture
This patch implements auto-detection for the M32C toolchain,
provided by IAR Systems:

 * https://www.iar.com/iar-embedded-workbench/#!?architecture=M32C

Change-Id: I0d983f82436dc527af7cb8550e0ebe745316c698
Reviewed-by: hjk <hjk@qt.io>
2020-05-19 14:35:49 +00:00
Denis Shienkov
dc372d7d1f BareMetal: Add support for Renesas M32C architecture in GCC toolchain
This commit adds support for the M32C atchitecture:

 * https://www.renesas.com/us/en/products/microcontrollers-microprocessors/m16c.html

using GCC toolchains.

Tested auto-detection on Windows using the GCC v4.7.3 toolchain
provided from the following URL:

 * https://gnutoolchains.com/m32c-elf/

Change-Id: Iaddd69e3109a4bd81d094dcb4edab29c8b398f01
Reviewed-by: hjk <hjk@qt.io>
2020-05-19 14:35:28 +00:00
Denis Shienkov
61cb90e97a ProjectExplorer: Add support for new M32C architecture
This commit adds new ProjectExplorer::Abi::M32CArchitecture
entry for the Renesas M32C architecture:

 * https://www.renesas.com/us/en/products/microcontrollers-microprocessors/m16c.html

Change-Id: Ic6ab278e5da6992824a1427ac86a470768fcdb1f
Reviewed-by: hjk <hjk@qt.io>
2020-05-19 14:35:18 +00:00
Denis Shienkov
52336bae08 Move splitString() method to base ToolChainConfigWidget
Change-Id: I382b5ad33e167356be19260454934940ae6d2d96
Reviewed-by: hjk <hjk@qt.io>
2020-05-19 14:35:00 +00:00
Orgad Shaneh
af455fa40c Git: Fix upstream status for branches with slash
Like wip/foo

Change-Id: Ia2816660f7878e872b2e49c4811f5893a1b8dc75
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-05-19 14:06:48 +00:00
Assam Boudjelthia
6bea157c9b Revert "Android: Also install LLDB from SDK"
This reverts commit 3e79c7da48.

Reason for revert: sdkmanager no longer offers lldb packages (a recent change from Google) instead it's provided within the latest NDK ndk;21.1.6352462.

Change-Id: If98ac86bb5086614d03f06e5f8c8e847bc65c0ed
Reviewed-by: hjk <hjk@qt.io>
2020-05-19 13:42:00 +00:00
hjk
5b2b8446b2 Android: AndroidManager code cosmetics
Change-Id: I228c29fb7dcf5d919bea3633ea235b5ae5a51a42
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 13:25:48 +00:00
The Qt Project
f0fd6282d2 Merge "Merge remote-tracking branch 'origin/4.12'" 2020-05-19 13:25:10 +00:00
hjk
5ce3059464 Android: Shuffle debug server detection code a bit
More in one place now.

Change-Id: I974c9351246ea88d8d16bcf7fb45abf763b7b7e5
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 13:24:23 +00:00
Eike Ziller
8292807e0d Merge remote-tracking branch 'origin/4.12'
Conflicts:
	src/plugins/android/androidextralibrarylistmodel.cpp

Change-Id: Ica69c24e83deff819e640dcb4c2682a554d8a2d2
2020-05-19 15:23:16 +02:00
hjk
08734e2ea0 Android: Simplify debug server upload
Change-Id: Ib5fad98e71c29e3b28c9ba206fe20a38a75a471e
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 13:17:49 +00:00
hjk
f3038bce08 Android: Search LLDB in new SDK location
Amends 3e79c7da48.

Change-Id: I6db991bc4d82000e0bb9860d85676bf1fdfb09a6
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 13:04:38 +00:00
hjk
8d3fd8d0de Android: Also try to kill lldb-server before starting
... and report upload errors.

Change-Id: I87b978290a1a6c74b63195d0e1724b1da6342b38
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2020-05-19 12:51:32 +00:00
hjk
4fb8bb9f06 Android: Consolidate error handling for not found debug servers
Change-Id: I55d0ef38cf250536e71b6828e762f51221162830
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 12:51:11 +00:00
Nikolai Kosjar
9fc2fda07e ClangTools: Remove dependency to libclang and custom clang binary
Before this change, we've invoked a custom clang binary that had clazy
statically compiled into it. The invocation also ensured that the
diagnostics were serialized to a file, so that libclang could be used
afterwards to read them.

As the clazy-standalone executable supports exporting diagnostics to a
YAML file now (just as clang-tidy) and Qt Creator ships it already, rely
on that executable alone instead of the clang/libclang combo.

While we do not depend on any clang header or library at build-time now,
the CompilerOptionsBuilder constructor still needs the CLANG_VERSION and
CLANG_RESOURCE_DIR pieces from llvm-config. This dependency should be
removed as next.

Change-Id: I4fa5753ab09008fd24bc5247b28c4836b5e8ca45
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-05-19 12:28:49 +00:00
Nikolai Kosjar
e2a68edbc1 Clang: Adapt test DiagnosticSlowTest.Text for LLVM/Clang 10
Change-Id: I99ac001d1231f14cd5cda9268d925fa442b16a35
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-05-19 12:28:17 +00:00
Andre Hartmann
79766caf52 Git: Use internal log highlighter for old git versions
Git didn't have RGB color support before version 2.3.0.
If an older version is used, fall back to the internal
log highlighter, i.e. don't disable it.

Amends commit d1b096699

Change-Id: I66f84dc4e79f7374d02f6d76c6f912c43e7f04bd
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-05-19 12:00:52 +00:00
hjk
1dc00ac125 LSP: Link fix
Change-Id: I983987e689e0f57f3243b43d64d112a2960263ec
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 11:13:32 +00:00
hjk
2962ee8e60 LSP: Parse fix
Compiles, but shows warnings in the editor about undefined
identifier. nullptr_t needs std:: over here.

Change-Id: Icba7b2e1686e44df4946340de1ba0dd1eece8e53
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 11:11:45 +00:00
Denis Shienkov
071f99875e BareMetal: Tune Keil ARM compiler using 'platform codegen flags' feature
Previously, to generate macros, we always passed by default one
target CPU as 'cortex-m0'.

Right now we have added the new text field in the Keil compiler
settings page, called "Platform codegen flags". In this field we
can specify the desired CPU target flags.

A new auto-or-manual created compiler still has the '--cpu=cortex-m0'
flag as before. The user can modify this flag for a manually added
compiler.

Also, the deprecated '-cpu' syntax replaced with the actual '--cpu'
syntax.

Change-Id: I25fb3e28460606b98ea56f1f30fe8563306a8736
Reviewed-by: hjk <hjk@qt.io>
2020-05-19 10:57:37 +00:00
hjk
d54c61b4bd Android: Simplify gdbserver upload logic a bit
Change-Id: I3b1950633ef99f1ead01edc864add8bb7f8a2031
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 10:41:58 +00:00
David Schulz
b7382bcf2e LSP: add PrepareRename request to the protocol implementation
Task-number: QTCREATORBUG-21578
Change-Id: I5bd87610d7c49f1e4a09ee1bd2221e4786a1856b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-19 10:11:01 +00:00
David Schulz
54c7b35219 LSP: support RenameClientCapabilities
Task-number: QTCREATORBUG-21578
Change-Id: Id47e275c3496f3f09b02189bcd400833b204efa7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-19 10:10:36 +00:00
David Schulz
4121eccf1e LSP: add symbol support class
Declutter the client and client manager by moving find usage and follow
symbol into this helper. This functionality was "temporary" put into the
client manager, but is more an implementation detail that shouldn't be
handled in that central place. Rename symbol will also go into this
helper class.

Task-number: QTCREATORBUG-21578
Change-Id: I56680f6ccbb8d244066561167178af7b341b8822
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-19 10:10:12 +00:00
Christian Stenger
cad625c739 Squish: Remove pastecode.xyz from tests
Service is unavailable.

Task-number: QTCREATORBUG-24002
Change-Id: I012681ec1ec1deb30387e1762fe72a877e56fa10
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2020-05-19 09:53:27 +00:00
Nikolai Kosjar
a35832385c Clang: Fix crash after cancelled completion request
Amends

  commit 755de9f86a
  Editor: delete processor after canceling

Ensure to update the bookkeeping in BackendReceiver on

  CodeAssistantPrivate::cancelCurrentRequest()

as otherwise we run into a use-after-free.

Change-Id: Ic5abdc9d743dc0b76eb050a9e3e00f85d2c5bc96
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-05-19 09:37:43 +00:00
Christian Kandeler
bd3a356ce9 ProjectExplorer: Fix soft assert in CustomParserSettings
Amends c15e09e0fe.

Change-Id: I73995f14cdb310cdffa9581efb388fe37c39229c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-19 09:28:47 +00:00
Christian Kandeler
b92c22a102 qbs build: Add project files for clang unit tests
Change-Id: I2cd02d94fb886bb49c66fa2508a63dc3480a7c23
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2020-05-19 09:26:45 +00:00
David Schulz
309702d945 Find: Add additional replace widget setter
Allows adding arbitrary widgets in front of the replace button

Change-Id: I0a9a16ca1e06c217639f458dd7946db8a43f98b1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-05-19 09:16:27 +00:00
Nikolai Kosjar
009e9d783d Clang: Fix leak in TranslationUnitUpdaterSlowTest
Change-Id: I75b349c5af80de01a2fb499b7335692eedcae6eb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-05-19 08:17:39 +00:00
Assam Boudjelthia
1af4a9c46a Correct openssl label text
The path has both qmake and cmake paths, so rephrasing...

Change-Id: Iaec72750f1223ddf4a4acf1a16d048835a7bf2cb
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-05-19 07:51:25 +00:00
hjk
709b57481e Mcu: Remove unused functions
Last and only users are gone with f08fe165ab.

Change-Id: Id5ff577ce3d1c8c47269536eca2140c9340c5b03
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-05-19 06:39:48 +00:00
Assam Boudjelthia
6b536bcbdf Android: silence assert in AndroidExtraLibraryListModel
Change-Id: I57f2f8d6df3eb2b726b7056569d5e8f809e81177
Reviewed-by: hjk <hjk@qt.io>
v4.12.1
2020-05-18 16:11:47 +00:00
Assam Boudjelthia
2c6563c69d Android: make sure to remove the adb daemon logs from devices list
Fixes: QTCREATORBUG-21797
Change-Id: I9153a5b2a0da4826179b436945fcc4616d65bb25
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2020-05-18 16:11:34 +00:00
Christian Kandeler
715dfcd3f8 CPaster: Replace pastecode.xyz with dpaste.com
The pastecode.xyz service has apparently ceased to exist.

Fixes: QTCREATORBUG-24002
Change-Id: I95fe6ec1388558d4dc176f66b166026619414e89
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-05-18 13:32:09 +00:00
Nikolai Kosjar
3d353424a6 Clang: Fix leaking skipped source ranges
...looks like this leak happens only in tests, specifically
SkippedSourceRanges.MoveAssignment:

Change-Id: Ib000217d4c360a59ea42821bea949b0afa0905b3
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-05-18 12:52:26 +00:00
Christian Kandeler
d9dd1f8d52 GCC parser: Create fewer and better issues
Consider the following compiler warning:

In file included from qgroundcontrol/libs/mavlink/include/mavlink/v2.0/
ardupilotmega/ardupilotmega.h:946,
                 from qgroundcontrol/libs/mavlink/include/mavlink/v2.0/
ardupilotmega/mavlink.h:32,
                 from qgroundcontrol/src/comm/QGCMAVLink.h:24,
                 from qgroundcontrol/src/comm/LinkInterface.h:21,
                 from qgroundcontrol/src/comm/LinkManager.h:21,
                 from qgroundcontrol/src/QGCApplication.h:27,
                 from qgroundcontrol/src/QtLocationPlugin/
QGCMapUrlEngine.cpp:19:
qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/./
mavlink_msg_vision_position_delta.h: In function ‘uint16_t
mavlink_msg_vision_position_delta_encode(uint8_t, uint8_t,
mavlink_message_t*, const mavlink_vision_position_delta_t*)’:
qgroundcontrol/libs/mavlink/include/mavlink/v2.0/ardupilotmega/./
mavlink_msg_vision_position_delta.h:138:178: warning: taking address of
packed member of ‘__mavlink_vision_position_delta_t’ may result in an
unaligned pointer value [-Waddress-of-packed-member]
  138 |     return mavlink_msg_vision_position_delta_pack(system_id,
component_id, msg, vision_position_delta->time_usec,
vision_position_delta->time_delta_usec, vision_position_delta-
>angle_delta, vision_position_delta->position_delta,
vision_position_delta->confidence);
      |
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

Before this patch, this output resulted in nine entries in the issues
pane, which defeats the purpose: The user is supposed to get a quick
overview of the build problems, but instead we basically just copied
over the contents of the compile window, which is of little help and
also slows things down by overloading the task model.
We now try harder to identify output lines that belong to the same issue
and create just one task for them. File paths are now linkified in the
detailed issue view, so that users can still navigate quickly to all
involved files.

Task-number: QTCREATORBUG-22914
Change-Id: I1aed2ffac7d363c02073ef318cb863754379cf6d
Reviewed-by: hjk <hjk@qt.io>
2020-05-18 12:34:52 +00:00
Eike Ziller
6bc59a0b95 Add documentation for Core::IContext
Change-Id: I452995fff604bc6cdea294fae8160aaa99231303
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-05-18 12:25:45 +00:00
Denis Shienkov
36598f391d BareMetal: Pass 'cpu' flag at getting predefined macros for Keil toolchain
Since Keil MDK v5.30 the 'armcc' compiler require the '-cpu' property
be set. So, as a workaround we pass the 'cortex-m0' property as default.

Change-Id: Ief80a5d128b4303250993557369c35c92d9b55db
Reviewed-by: hjk <hjk@qt.io>
2020-05-18 11:44:05 +00:00
Denis Shienkov
903f6fb75d ProjectExplorer: Parse RISC-V GCC compiler name to detect it word width
Change-Id: I291fc1ef01091391a094e7031b813f5a4afb2f2d
Reviewed-by: hjk <hjk@qt.io>
2020-05-18 11:41:38 +00:00
Leena Miettinen
625a8f3eca Doc: Fix typo "sependencies" > "dependencies"
Change-Id: I1d3f3f0bbdcff3d557038d8feca5ffe234d58314
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2020-05-18 11:37:42 +00:00
Eike Ziller
d5443cea77 CMake build: Unify handling of qtc_add_... arguments
Unify handling of EXPLICIT_MOC, SKIP_AUTOMOC, EXTRA_TRANSLATIONS

Change-Id: I9f5cbe9fe6b58ec527edd5e25008153455857ed8
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-05-18 11:19:01 +00:00
Eike Ziller
d09c453ff1 CMake build: Use some more extend_qtc_target even internally
To avoid duplication.

Change-Id: Ida6c1e17a21cfdca9208e089760287ff55bae595
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-05-18 11:18:50 +00:00
Eike Ziller
3c59d02286 CMake build: Favor qtc_exted_... with CONDITION over custom if
Change-Id: I2c575b69fb6c2535f789313234400f6f6a63a08b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-05-18 11:18:38 +00:00
Eike Ziller
3c535503cb CMake build: Avoid using extend_qtc_target directly
Also add a extend_qtc_test which checks if the test is known.

Change-Id: Idd3b3a02ac61fce2622cb8681233cfbd96a77bc4
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-05-18 11:18:26 +00:00
Eike Ziller
90612d14c7 CMake build: Move internal functions from QtCreatorAPI
Change-Id: Iade7ae7533abb8b8ed0ccba8bd246b4a734794b6
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-05-18 11:18:15 +00:00
Christian Kamm
6dc87d96b7 QmlJS: Fix bug with async typeinfo loading
There were infinite loading loops, because the unupdated LibraryInfo was
written to the ModelManager.

Change-Id: I22faf017a2c9370e97042152cddc872a3d35fb77
Reviewed-by: Christian Kamm <mail@ckamm.de>
Reviewed-by: Philip Van Hoof <philip@codeminded.be>
2020-05-18 10:27:09 +00:00
Denis Shienkov
bd5a5120cb BareMetal: Auto-detect IAR toolchain for M68K architecture
This patch implements auto-detection for the M68K (aka ColdFire)
toolchain, provided by IAR Systems:

 * https://www.iar.com/iar-embedded-workbench/#!?architecture=ColdFire

Change-Id: I4e42c4402e3982f4a7c4b1f4a4ce11220cf201c4
Reviewed-by: hjk <hjk@qt.io>
2020-05-18 10:22:14 +00:00
Denis Shienkov
0a3925494a BareMetal: Add support for M68K architecture in GCC toolchain
This commit adds support for the M68K atchitecture:

 * https://en.wikipedia.org/wiki/Motorola_68000_series

using GCC toolchains.

Tested auto-detection on Windows using the GCC v4.8.0 toolchain
provided from the following URL:

 * https://gnutoolchains.com/m68k-elf/

Change-Id: I5f1e36de240f3f53b54e0e6a8edb318746d345e7
Reviewed-by: hjk <hjk@qt.io>
2020-05-18 10:21:56 +00:00
Denis Shienkov
9e1bcd443d ProjectExplorer: Add support for new M68K architecture
This commit adds new ProjectExplorer::Abi::M68KArchitecture
entry for the M68K (aka new NXP ColdFire) architecture:

 * https://wiki.osdev.org/M68k_Overview
 * https://www.nxp.com/products/product-information/ip-block-licensing/coldfire-32-bit-processors:COLDFIRE-32-BIT-PROCESSORS

Change-Id: I84a70b2d127f207bdff5cd085890def1fe28b17d
Reviewed-by: hjk <hjk@qt.io>
2020-05-18 10:21:42 +00:00