The step list names are computed separately anyway, having an
extra preamble consisting of concatenated build list names on
one line looks unnecessary.
Change-Id: If754c6363042927210dfd09c23f2f494081f8c47
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The change 290840, made AndroidToolchain tied to an NDK location, but
when restoring a toolchain the NDK wasn't being assigned. This deduces
the NDK location from the toolchain compilerCommand().
Change-Id: I3cd936ac48570fadbec15ac1e13496706718c0ea
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
It seems that forcing sdkmanager reloadPackages is causing a duplication
in all packages and ndk listings.
Change-Id: I7e92d1c6dcec2a09db088d9596aca31a3d8b437f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This amends commit 7677e3e197368bd206dc565368cb3f33d951d092.
Change-Id: Ib07dc2a8110a8e09f43c035989d9ffa84e0427d3
Reviewed-by: André Hartmann <aha_1980@gmx.de>
- Only latest docs are registered by default
- Users can change the settings for displaying help in
the detached help window
Change-Id: Id7efb98e11eb8a27b7d01422e65ac63b860c868e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
generated with autopep8 and the introduced setup.cfg
Change-Id: I5b55a7937f2cde81be59d2b434e94ada1a4af5ab
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
- Describe the new bug filter
- Describe the new URL template custom filter type
- Update screenshots
Change-Id: I830b3953e89e97a7e5a405687915b67153412d9a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... before overwriting the current guard, retaining the
state of the current guard in the error case.
Change-Id: I45ec43d48a9a13b9b59a5bbe6415a457b974b654
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Should be at least theoretically the right one, but is mainly
done to always feed a QmakeProFileNode * to the 5-args
handleSubDirContextMenu().
In practice it does not seem to impact the current level of brokenness:
In case of Build->File with not-synchronized editors the action shows
the name of the file selected in the project view, while it actually
builds the file in the current editor.
Change-Id: I47f8f22eb80be18d1be5997a861cea89bd069d1b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
If the text cursor is visible, but in the bottom area of the editor, it
would be no longer visible after splitting. That makes the probable
"area of interest" vanish from sight.
Check that condition (visible before, but would not be visible
afterwards), and if that is the case center the text cursor in both
resulting editors.
Change-Id: I8c8dccd2d9db439c82d0aca34b8ef99fa97aa48e
Reviewed-by: David Schulz <david.schulz@qt.io>
MSVC 2015/17/19 are ABI compatible, but BaseQtVersion::validateKit()
would emit a warning when using e.g. a Qt MSVC 2017 build with an MSVC
2019 toolchain.
Change-Id: I50ba026ae7b55e052b26826076ef962f369a05a1
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
As collateral damage, use a capital C in KeilToolchain*.
Change-Id: If9d64de2108366546683144975d975d9d1727712
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If the project has a header file whose name suggests that it might
declare the base class, then add an include statement for it.
While we cannot guarantee that the include statement is resolvable as-
is, it's at least a basis for the user to adapt accordingly, while
without any include statement the class will definitely not compile.
Fixes: QTCREATORBUG-3855
Change-Id: I55ec43d58a9a13b9b59a5bbe6415a457b974b654
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
On Ubuntu 19.10 the libyaml-cpp-dev CMake config module has a broken
value for YAML_CPP_INCLUDE_DIR.
Change-Id: I5097ef656b988dda0326a15b521b92cbbdb0a390
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Only used once, and the concept is undesirable.
Change-Id: I7f28f8a20d6d1f003a6d8b18bbcfba343614625c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This enforces a linear pass through
[static] ProjectExplorerPlugin::updateRunActions
ProjectExplorerPluginPrivate::doUpdateRunAction
[emit] ProjectExplorerPluginPrivate::runActionsUpdated
instead of the previous direct emission of the signal from
user code and connecting also the internal update to it.
This is meant to simplify reasoning about execution order and
maybe to help elimimating double executation.
Change-Id: Id8cc41a46d9dec06afb5514855f2ae80560f3695
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
No need for two manager type classes talking mostly to each other.
Change-Id: I82a52385df08dc4cddac2d294661341a79b86a4d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
And when restoring editors in other ways (like from a session).
When splitting, the new editor was always scrolling to make the text
cursor visible, even if it wasn't visible in the original.
1. open editor with long contents
2. scroll away from the text cursor, so the line isn't visible
3. split and wonder
or 3. close and re-open Qt Creator, and restore the session
Our code already does set the state of the new editor to the old one,
but that state was destroyed by QPlainTextEdit::showEvent, which scrolls
on first show if text was added to the document.
So, wrap the showEvent with save/restoreState on first show.
Change-Id: I95e0b4e963ebb33d13ce020affaf7fc7f94c9257
Reviewed-by: David Schulz <david.schulz@qt.io>
Developers can use custom fonts in Qt Quick UI projects that they
create in Qt Design Studio. Additional steps are needed when
converting these projects to Qt Quick Applications.
Fixes: QTCREATORBUG-23646
Change-Id: Iebc8e6efd9683450232d1ea878925f9791536663
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
- Integrate the newest commits from the base repository
dec170ed24679fd49f9fb54af91f61146838f852
34cb2ae91790fc65ca5c0f7b81bb928de22a32e5
- Cleanup a few if statements
- Cleanup a comment
Change-Id: I158bff610f701e7a30680cfb8383f64475199bbe
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
... into the only internal caller.
The use there is dubious to some degree.
Change-Id: Icfa7437b3fdaa4dbd73fe9965a88abf4700cd3e0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Re-use an existing variable, which contains the same information.
Change-Id: I1daa6428d67f11dd2efccd43ff6bab76420236ae
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Some toolchains that were auto detected in previous sessions or version
of Creator might re-appear as manual toolchains. Thus, make sure that's
fixed. Also, make sure the name of old toolchains is updated with the
current name format.
Change-Id: I04d2145cb9c5e1e25e2bcbc21c014280bc355195
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Apparently, recent Visual Studio installations try to collect temeletry
information via powershell in vsdevcmd.bat, which interferes with our
toolchain setup process. Turn this behavior off.
Task-number: QTCREATORBUG-20886
Change-Id: Ia81652fc721119980da980c043991df27f10a10f
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
PythonPlugin depends on LanguageClient, which has a private
dependency on LanguageServerProtocol.
This fixes this error:
src/plugins/python/CMakeFiles/Python.dir/pythonrunconfiguration.cpp.obj:
In function `int LanguageServerProtocol::JsonObject::typedValue<int>(QString const&) const':
src/libs/languageserverprotocol/jsonobject.h:134:
undefined reference to `__imp__ZN22LanguageServerProtocol13fromJsonValueIiEET_RK10QJsonValue'
Change-Id: I7cacbf68a00ff9ff2a6ab9618bc6ec371247a0aa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
