Commit Graph

67787 Commits

Author SHA1 Message Date
Tobias Hunger
836bf1f379 QmlDesigner: Fix initialization of SelectionIndicator
Change-Id: Ic13236a93e78b29a73bd86590c800edb20c0cffd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-24 11:12:43 +00:00
Robert Loehning
7eda08f600 Squish: Directly click mode selector
The tooltip doesn't show up on Windows anymore unless
you manually move the mouse.

The positioning has proven to be stable, so we don't
need to double-check using the tooltip anymore.

Change-Id: I92400d1fa273d4fb6a011cdf00c3b127c06764d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 10:50:34 +00:00
Tobias Hunger
144ee4103f android: Do not crash when node is nullptr in CreateAndroidManifectWizard
Change-Id: I1988fa72be535210e50d9ed18ef9d081e6ae39ed
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2020-02-24 10:47:43 +00:00
Tobias Hunger
2e59ef8c1c Android: Consistently allow Qt version to be nullptr
Do not crash when Qt version is nullptr. This was checked for in
some places, but not in others. Not sure whether or not it is safe
to assume that Qt version is never a nullptr here, so I went for
the better-safe-than-sorry option.

Change-Id: Ief9a479ee5719204582902bfa72412145658f0c2
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2020-02-24 10:47:28 +00:00
Tobias Hunger
f8e6638069 CMakeBuildStep: Adapt variable name after moving functionality
Adapt the variable name after moving the functionality from the
BuildConfiguration to the BuildSystem.

Change-Id: I16006066841222ddd3607198413e2b55e6270c89
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:47:02 +00:00
Tobias Hunger
0dcd380865 CMakeBuildStep: Remove dead code
Change-Id: I3ba8d5ece263f19c0b129e9de81888c9016583a5
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:46:51 +00:00
Tobias Hunger
64c9c9e184 CMakeBuildStep: Document that the buildconfiguration will be non-null
Change-Id: I27be487f2a662df8cf41152d6c7ffd0f40151061
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:46:42 +00:00
Tobias Hunger
e525dea898 CMakeBuildStep: Fix message
Change-Id: I6c373639273bdce17531e3e7fe5ec0f38e62b8b3
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 10:44:39 +00:00
Knud Dollereder
06d5817076 Add the ability to modify the animation range from the curve editor
Fix a synchronization issue between timeline and curve editor when
the animation contains pinned curves

Change-Id: I89dda234063259f41d662749d696f5fc8a04f9e8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-02-24 10:11:24 +00:00
Orgad Shaneh
de5f4d1160 VCS: Fix broken annotation changes detection
isValid() is true for empty regexp...

Change-Id: I0af92574181736d5dde2ca48d3a8ab75ff6f14dc
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-24 08:32:03 +00:00
hjk
92a1d1a9ba WinRT: De-Q_OBJECT-ify deploy steps
Change-Id: Ie0ad653d7611a2db8421baed68a7dbb9d89e06a7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 08:10:28 +00:00
David Schulz
e17c96cf11 Dumper: move global enums and functions to utils
Change-Id: I11f5f0d970cd23a5fd907d33daa3cb8a441d0c58
Reviewed-by: hjk <hjk@qt.io>
2020-02-24 07:47:40 +00:00
Christian Kandeler
daa58e899d Qmake: Do not repeat build directory in warning message
The build directory line edit is right above the label containing the
message, so repeating the build dir value just widens the label
unnesessarily.

Change-Id: I650a4ce76a82582b2710a4673c134dbb4faf306e
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-24 07:17:45 +00:00
Orgad Shaneh
b2ceb7db79 Git: Open log for ranges in output window
Show doesn't make much sense.

Change-Id: I945910749fa99245469164c1a411ce39b9f4f3d4
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-24 07:13:25 +00:00
Jochen Becher
87d2df9d7b modeleditor: Improve intersection of line with polygon
Change-Id: Ie546801fadedffaef24c53ce83ce0a039e77a04a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-23 15:54:52 +00:00
Jochen Becher
db90ce21c9 modeleditor: Fix intersection of relation with component
Change-Id: Ib0a999e56f98bc2a4483583a322e107560c17dc0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-23 15:54:24 +00:00
Jochen Becher
c37ecdeaf1 modeleditor: Keep some border around the diagram scene
Change-Id: I09aeaffa0a36048c8a6c8e7787750b08e07f08d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-23 15:54:00 +00:00
Andre Hartmann
710836f222 Debugger: Fix std::optional dumper
Tested under Ubuntu Linux 18.04.1
with gcc 7.4.0 and gdb 8.1.

Started-by: Tobias B. on Jira
Fixes: QTCREATORBUG-22436
Change-Id: Id75c817f26bf16e4d93332ab24068cacbe5d9d8e
Reviewed-by: Marcel Petrick <mail@marcelpetrick.it>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2020-02-23 14:33:45 +00:00
Alessandro Portale
6e88cc33de StudioWelcome: Add the qml files to the CMake build system
Add a missing delimiter for the debug build. For the release build, we
need a .qrc file which captures the whole qml/ subtree.

Change-Id: I07fa916f6074870278c2aa90a8e4a599bf784a3d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-02-23 11:05:03 +00:00
hjk
d45e123b8e ProjectExplorer: Remove pure ProjectConfiguration::isActive function
It's never used polymorphically, and only caused an unused
implementation in BuildStep.

Change-Id: I5fbd34925788ca22960a2f522eef75be3137c67b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-02-21 17:30:15 +00:00
Cristian Adam
63b0c79a46 GitHub Actions: Add OpenSSL to resulted test artifacts
Change-Id: Ieec647abc87f87de79ef07c12378a2a32e783d8e
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 16:08:42 +00:00
Denis Shienkov
b858e58d3f Debugger: Allow to specify 'init' and 'reset' GDB commands
... in case the attaching to the remote running GDB server.

We need in this option for the bare-metal programming, because the
'Attach to Running Debug Server' option should cover functionality
of the removed 'Default' GDB server provider.

Without of this option the debugging is non-functional in a most
cases.

Change-Id: I77a37552b2c7c2e76d70dbecfe9e21f316c02534
Reviewed-by: hjk <hjk@qt.io>
2020-02-21 16:07:40 +00:00
Thomas Hartmann
af9f703dc3 QmlDesigner: Remove project explorer from navigator
This was a 'hack' to make the project explorer more accessible
and with dock widgets this is not required anymore.

Change-Id: I92b0a168a41eade2718698b9602e33550286e96f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 14:44:18 +00:00
hjk
be899de35c CMake: Move CMakeBuildStepConfigWidget definition to .cpp
Slimmer interface.

Change-Id: I34b8c172864456f67216efce7a09967c0ffec8be
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-21 14:10:15 +00:00
Thomas Hartmann
c74a3042d4 QmlProject: Add qtForMCU flag
Change-Id: Ia473fd257414f5edddc0ffcce8c913897d75f351
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 14:02:23 +00:00
Christian Kandeler
21ab7e59d7 AdvandedDockingSystem: Fix deprecation warnings
Change-Id: I21193c2b275f9c11d25eef11bdbe2931ad2ea4ff
Reviewed-by: hjk <hjk@qt.io>
2020-02-21 13:47:44 +00:00
Christian Stenger
8d71943cfa Mercurial: Fix compile for Qt5.11
Change-Id: I2ae766a76d34f0ca6e43ba6059fda82edaf0358d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-02-21 13:30:19 +00:00
hjk
b6cd57b4f9 Android: De-Q_OBJECT-ify AndroidPackageInstallationStep
Change-Id: I49a839405c8b3b61a29c79bf13620a2e98cdca2e
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 13:14:19 +00:00
hjk
f0fcc4e5c5 Android: Use timer for delayed execution
Reduce need for moc.

Change-Id: Ibbd85de60e891ca57738e44ad25e05e86ccb0c24
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 13:14:05 +00:00
hjk
16e87971cd iOS: De-Q_OBJECT-ify IosBuildStep
Change-Id: If6b32de1f359e6f18d86caa77dcd6ed311f3adbc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-21 11:49:04 +00:00
hjk
b2a31f5be8 Modeling: Fix deprecation warning
In file included from /data/dev/qt-5/qtbase/include/QtCore/qlist.h:1,
                 from /data/dev/qt-5/qtbase/include/QtCore/../../src/corelib/kernel/qobject.h:49,
                 from /data/dev/qt-5/qtbase/include/QtCore/qobject.h:1,
                 from /data/dev/qt-5/qtbase/include/QtCore/../../src/corelib/io/qiodevice.h:45,
                 from /data/dev/qt-5/qtbase/include/QtCore/qiodevice.h:1,
                 from /data/dev/qt-5/qtbase/include/QtCore/../../src/corelib/serialization/qdatastream.h:44,
                 from /data/dev/qt-5/qtbase/include/QtCore/qdatastream.h:1,
                 from /data/dev/qt-5/qtbase/include/QtCore/QDataStream:1,
                 from ./qmt/infrastructure/uid.h:30,
                 from qmt/model/melement.h:28,
                 from qmt/model/mobject.h:28,
                 from qmt/model/mobject.cpp:26:
/data/dev/qt-5/qtbase/include/QtCore/../../src/corelib/tools/qlist.h: In instantiation of ‘void QList<T>::node_construct(QList<T>::Node*, const T&) [with T = qmt::Handle<qmt::MObject>]’:
/data/dev/qt-5/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:622:13:   required from ‘void QList<T>::append(const T&) [with T = qmt::Handle<qmt::MObject>]’
./qmt/infrastructure/handles.h:162:9:   required from ‘void qmt::Handles<T>::add(const qmt::Uid&) [with T = qmt::MObject]’
qmt/model/mobject.cpp:80:23:   required from here
/data/dev/qt-5/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:471:35: warning: implicitly-declared ‘constexpr qmt::Handle<qmt::MObject>& qmt::Handle<qmt::MObject>::operator=(const qmt::Handle<qmt::MObject>&)’ is deprecated [-Wdeprecated-copy]
  471 |     else *reinterpret_cast<T*>(n) = t;
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
In file included from ./qmt/infrastructure/handles.h:28,
                 from qmt/model/mobject.h:29,
                 from qmt/model/mobject.cpp:26:
./qmt/infrastructure/handle.h:40:5: note: because ‘qmt::Handle<qmt::MObject>’ has user-provided ‘qmt::Handle<T>::Handle(const qmt::Handle<T>&) [with T = qmt::MObject]’
   40 |     Handle(const Handle &rhs) : m_uid(rhs.m_uid), m_target(rhs.m_target) { }
      |     ^~~~~~

Change-Id: I9fe85f5b46912a52d1722da0f048d4eee6171ade
Reviewed-by: Jochen Becher <jochen_becher@gmx.de>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-21 11:48:49 +00:00
hjk
1627850e81 ProjectExplorer: Un-export ProcessStep
Not used outside.

Change-Id: Ibab561d2f49ffce5b2e1d2505ef0634c802221b0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-02-21 11:48:08 +00:00
Leena Miettinen
45a575c218 Doc: Fix QDoc warnings in Core plugin Wizard classes
Task-number: QTCREATORBUG-23620
Change-Id: Ia8d27be35911378703126c1e2d06a157ce6185f0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-21 11:37:36 +00:00
hjk
1714ecf809 ProjectExplorer: Remove Task::buildConfigurationMissingTask()
It should not be possible to trigger the condition. Except for MakeStep
the function is only called from real BuildSteps, that always live in
a BuildConfiguration.

A MakeStep could live in a DeployConfiguration, but that belongs to
a Target. That target always has a BuildConfiguration in case the
project type requires one. So not having a BuildConfiguration can only
happen when the project type doesn't require one, but then the
situation is not an error that should be notified as a Task.

Change-Id: I2a5d90fdadd3916d3dae6a0fdc6e6ab2010a8111
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2020-02-21 11:11:18 +00:00
Cristian Adam
ea7d59e58a GitHub Actions: Display tests pass rate as warning annotation
Change-Id: I7d9970067b786f34fc29c82f85c5fc31f6d02704
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 10:42:46 +00:00
hjk
8b563a63d4 Nim: De-Q_OBJECT-ify NimCompilerCleanStep
Change-Id: I3fce6484b90ac540009d0e5501a4435d15f241b6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-21 09:56:03 +00:00
Leena Miettinen
5835e22793 Doc: Fix Progress Manager docs
- Fix issues that cause QDoc warnings in documented classes
- Mark undocumented classes \internal

Fixes: QTCREATORBUG-23619
Change-Id: Id1fb3ff55b89a21a65f687beccb5b4ff36747ae7
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-02-21 09:16:19 +00:00
Christian Stenger
bd428b2f13 ADS: Do not enable debug log by default
Change-Id: I9e3f9608b5710b03c3e6089b5bfa40b651a865dc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-21 09:07:52 +00:00
Eike Ziller
62aed34077 CMake: Fix build with older GCC
Change-Id: Ib606c91039a4389e7f3fbb3d9c733240106da441
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-02-21 08:58:59 +00:00
Orgad Shaneh
a83f0c5d74 VCS: Replace QRegExp with QRegularExpression in VcsBaseEditor
Change-Id: I8e8a6649e441597e29e88506d494ec69260bebd1
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-21 08:28:34 +00:00
Christian Stenger
16211cb589 TextEditor: Fix compile with Qt5.11
Change-Id: Ic704c428c0574789d6c67f9a0ddff511a4ee8b26
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-02-21 07:00:29 +00:00
Christian Stenger
e445f7aac3 ADS: Fix compile for Qt < 5.12.2 and namespaced Qt
Change-Id: I552d19b1659598d98d0ef1900c79e3c93747ffb2
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-02-21 06:59:17 +00:00
Andre Hartmann
32935591dd ExecuteFilter: Add timestamps to command outputs
By adding a new function to MessageManager.

Change-Id: Ia70d781c0398e8ce0a055ae8fc4718a9081e688f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-02-20 19:39:29 +00:00
Orgad Shaneh
b14351dab8 Git: Support case-insensitive grep/pickaxe
Change-Id: Ie3da0f5cca2bd3ffa658e3adbba0b1b86a2911d9
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-20 19:05:36 +00:00
Orgad Shaneh
6d8efefbe5 Git: Add a toggle button for filter widget
Change-Id: If9680d1fc8a06f57f995a63095ad201fc1f3156b
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-20 19:05:25 +00:00
Orgad Shaneh
2110be00ab Git: Move filter widget to GitEditor
and make it a QToolBar.

Change-Id: I6a16b1a828bfabaace8e14ef39344f7f2bac7e8a
Reviewed-by: André Hartmann <aha_1980@gmx.de>
2020-02-20 19:05:16 +00:00
Andre Hartmann
d21f72d0dd Git: Simplify action in branch view
Change-Id: Ic1a604baa7b83b7244febde776c95896b56a1467
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-02-20 18:46:13 +00:00
Assam Boudjelthia
37ff19c002 Android: update UI after downloadSdk() is done
Make sure the UI ticks are updated directly after SDK Tools package
is downloaded.

Change-Id: If1d94c624dcbc5be14246f61b197d849438d19e5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-20 17:55:53 +00:00
Assam Boudjelthia
2191bcea36 Android: avoid calling m_sdkManager->reloadPackages() twice
AndroidSettingsWidget::onSdkPathChanged() is being called then
m_sdkManager->reloadPackages(true) after it at start, that's not
necessary.

Change-Id: I6171e8a5fb765fa26aecb505ca50231c3e609b74
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-20 17:55:32 +00:00
Assam Boudjelthia
ad927dac85 Android: call cancel() instead of hide() in sdk download progressdialog
The proper use is to call cancel(), the dialog will be hiden after that.
Otherwise, it will not be cancel  and can get visible again.

Change-Id: Ifb2a00721571ce2bc8ded7c96e6b69e587020b34
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-02-20 17:55:05 +00:00