The check nowadays always succeeds, the potential failure is handled
in the normal done() handling.
Change-Id: I858633871a6b66817c795e7057964afebf79eb85
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
The issues that were worked around by these resets have been fixed.
Fixes: QDS-7009
Change-Id: I7940b55c3f3edcfdcde9ad5f41cfa1d188d2bc96
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Previously, icon generation was done at import time, but that was
wasteful, as we now have image cache backed icon generation
available for component library icons. Added the few remaining missing
bits to support icon generation for image cache and disabled the old
icon generation implementation for Qt6.
A few issues in fit algorithm for preview image generation were also
uncovered and fixed to make icons render scene in comparable size to
the old version.
Qt5 imports still generate using old way since component library
3D previews generation doesn't work on Qt5.
Fixes: QDS-6205
Change-Id: I5418fa19d86e81adcd184be023f1dfbc813d0bf5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Following the ArgumentsAspect precedence for MacroExpander.
Change-Id: Id3f58a994eb03911f7c864d66e06cf9571a1e3db
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This is in preparation for perhaps moving the kit detector into another
plugin such as project explorer for usage by remote linux devices for
instance.
Change-Id: Ie17ab3913aed9ccc895213882cd188c16affda15
Reviewed-by: hjk <hjk@qt.io>
Make it ready for providing implementations for other devices.
Change-Id: I14eaf167a7b2c1189f4d23f2e9f556204295b9b3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The timeline and timeline-animation is now visible in
the Navigator regardless of the "Show only visible" filter
setting.
Also assigned icons to timeline, timeline-animation,
keyframe and keyframe-group
Fixes: QDS-6965
Change-Id: I85a735a3a1811dd783c98422358492fd4b71f61f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
In a scene with multiple states and timelines it occasionally happend
that the curve editor was updated from an inactive timeline.
This is now fixed.
Fixes: QDS-6948
Change-Id: I586593452e69cebe7bb2571e301230bf0ace8631
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
There is not need to export this class as it's not used
outside. Rename RemoteLinuxKillAppStep into KillAppStep,
as the "RemoteLinux" prefix is redundant inside RemoteLinux
plugin.
Change-Id: I46800c84fd326bb0631b77e48243443d79bc2fb2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
We had only one class derived from it
(UploadAndInstallTarPackageService), so glue both classes
together. Don't export UploadAndInstallTarPackageService class,
as it's not used outside. Move the implementation into cpp file.
Change-Id: I1521d1badb559e510e11337ace309a867196b251
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
No subclass was using it currently, so simply internals.
Change-Id: Ie9574fdb2d6a26d089f3059acca407d65c59b2cc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Microsoft offers cross-compilers for the Arm64 architecture.
Windows 11 Arm64 can emulate the x86 and x64 architecture so the
binaries that can be run should be taken into consideration.
Change-Id: I330c15a2c543eada9f7c939887ce13a1dd7559fd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This removes the reference to emulation layer in error messages.
Task-number: QDS-7019
Change-Id: I120647266c007ce41481c4980a705d57b5a3e544
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This patch allows to distinguish between 6.2 and 6.3.
Change-Id: I9ba4c9984673e9e9e6f7d50a1ea35704f7e00211
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>