Commit Graph

76686 Commits

Author SHA1 Message Date
Thomas Hartmann
088b926ff4 QmlDesigner: Update supported macOS version
Task-number: QDS-6290
Change-Id: I41a0cca5cc0f5113fe3a06e3cb93a7e49b20a341
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-18 08:40:20 +00:00
Jarek Kobus
fdc8193f13 ProcessInterface: Drop ProcessMode from c'tor
Drop it also from registerHandle() methods, as it wasn't
used there.

Change-Id: I34b72c38368b82f22d73314fe3cd429ed43cadbc
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-02-18 08:29:24 +00:00
David Schulz
088d692bb2 Editor: fix crash after triggering select all with no search results
Change-Id: I32d5172e8b5df6db93053f358c5a72cb8d38f6ea
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-18 08:09:14 +00:00
Leena Miettinen
d487110351 QML/JS: Fix terminology in messages
- Replace Qt Quick Designer with Qt Design Studio
- Replace "Qt Quick UI form" with "UI file (.ui.qml)"

Also fix the docs:

- Add missing messages
- Hide QDS  messages from Qt Creator Manual
- Make punctuation consistent
- Add some links to more information

Task-number: QDS-2670
Task-number: QTCREATORBUG-27055
Change-Id: Id90f1ad82e7297f91225bc8d650a9578ba071330
Reviewed-by: Mats Honkamaa <mats.honkamaa@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-18 07:33:35 +00:00
Leena Miettinen
1f3e6b4c7a Android: Fix punctuation and wording of messages
Task-number: QTCREATORBUG-27055
Change-Id: I4180717163ec52a405c40e1a932713dda27c3f38
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2022-02-18 07:27:41 +00:00
Christian Stenger
e4ff13e529 StudioWelcome: Fix compile
Amends 5d660d7afe.

Change-Id: I8d7239f2b57274c062cb2f9f535d274f5e149288
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-02-18 06:10:18 +00:00
Alessandro Portale
74643556f9 Utils: Print out QtcProcess number in result debug log
That makes it easier to understand which result belongs to which
process. And make the result output a 1-liner in the case of logging,
which makes filtering easier.

Change-Id: I6da84d28fe2269d2d6dfe6f5a1d300faf5697ca1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-02-17 17:07:10 +00:00
Jarek Kobus
ae36fd943a ProcessInterface: Drop arguments from finished() signal
Make the API more similar to QtcProcess API.

Change-Id: If62051908b7974008bebda21dd288b02e7a772f3
Reviewed-by: hjk <hjk@qt.io>
2022-02-17 16:58:19 +00:00
Leena Miettinen
3805bec91f C++ Editor: Fix UI text capitalization
Task-number: QTCREATORBUG-27055
Change-Id: I148cfb7b9628ab2460050c1127b6557b8830983b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-17 14:34:19 +00:00
Leena Miettinen
b2d90241fe Log Viewer: Fix UI text
Also update the string in the documentation.

Task-number: QTCREATORBUG-27055
Change-Id: Idce699a7796e7cb55d8218c105ec851c369cef7b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-17 14:23:29 +00:00
Mahmoud Badri
81c9051feb QmlDesigner: Fix rename asset folder dialog's error text width
Fixes: QDS-6202
Change-Id: Iea6714561ce23e3a18889ab5d684fbeae85d62fe
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-02-17 14:16:49 +00:00
Mahmoud Badri
9c4e4309f8 QmlDesigner: Close Assets Library context menu on press outside
Fixes: QDS-6197
Change-Id: I0c694b5a64bc0a41e905523b16552d6b0493eac6
Reviewed-by: Samuel Ghinet <samuel.ghinet@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-02-17 13:57:52 +00:00
Henning Gruendl
f7cbc513aa QmlDesigner: Add missing context pointer connect
* Add missing context pointer in connect statement
* Fix console output "QFile::remove: Empty or null file name"

Task-number: QDS-6170
Change-Id: I31f671dc1422c6b90aff81252f4bc4cf2c34e7d1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-17 13:11:46 +00:00
Henning Gruendl
5d660d7afe QmlDesigner: Add examples download path setting
Add a PathChooser to StudioSettingsPage which enables setting the
location to which the QtDesignStudio examples are extracted.

Task-number: QDS-6174
Change-Id: I99232edf3c1200a84daaadf4a0d118317a5ea009
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-17 13:11:39 +00:00
Eike Ziller
8851810658 GitHub: Explicitly use MSVC 2019 machines
windows-latest is "transitioning to 2022" currently, and that seems to
mean that for some users this is already 2022 and for some still 2019.
Explicitly state something.

Change-Id: I1e7ba6fa60b9fe44c78505b322ff8278c2e41ee6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-17 13:07:42 +00:00
Christian Kandeler
15280d7127 ClangCodeModel: Request clangd quickfix for -Wswitch warning
This way, a warning about missing switch cases will be accompanied by a
matching code action, which allows the user to fix it right away by
clicking on the lightbulb.
Requires clangd >= 15; see https://reviews.llvm.org/D118976.

Change-Id: I11e82264c41e4154f979d28a5e44e72c8158595b
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-02-17 12:38:49 +00:00
Leena Miettinen
0064dda2c0 Remote Linux: Do not use contractions in UI text
Task-number: QTCREATORBUG-27055
Change-Id: I7fbc6374c910fa81900a10432892c10afb0ea6d4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-02-17 12:12:31 +00:00
Leena Miettinen
99ceebe695 Debugger: Remove extra words from tooltips
Task-number: QTCREATORBUG-27055
Change-Id: Ic7b447da2de3267ad897cdef0275a2faa4474099
Reviewed-by: hjk <hjk@qt.io>
2022-02-17 12:12:02 +00:00
Leena Miettinen
eb8d84f6de Docker: Fix UI text caps and punctuation
Task-number: QTCREATORBUG-27055
Change-Id: I6b5c2bbd36e34d4444b798e2e5040bff674ad02a
Reviewed-by: hjk <hjk@qt.io>
2022-02-17 12:09:23 +00:00
Leena Miettinen
e4b39e0ce4 CMake: Fix UI text
Task-number: QTCREATORBUG-27055
Change-Id: I53a3ece8b6180afa4fbcbc474cc980aced5f55c8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-17 12:08:59 +00:00
Leena Miettinen
4f3d3d445c Project Explorer: Fix UI text
Task-number: QTCREATORBUG-27055
Change-Id: I9b0e4f02ea7d1ebb14a9581f21c76b8908589334
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-17 12:08:37 +00:00
Leena Miettinen
1a90f06fe5 QML Designer: Fix UI text
Fix capitalization of strings and the wording of tooltips.

Task-number: QTCREATORBUG-27055
Change-Id: Id8e324b44574b9cf0d1522ae204b452cea6193cd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-02-17 12:05:26 +00:00
Jarek Kobus
531e24892b Fix starting remote process in terminal
SshDeviceProcess::start() is overridden and it starts
connecting phase. It marks the current state as
Starting. Later, when connection is being established,
it calls back the base QtcProcess::start() and it
fails on assert. This doesn't happen when starting
not in terminal, as in this case SshDeviceProcess
delegates the start to the aggregated SshRemoteProcess
instead of calling QtcProcess::start().

Disabling the assert for a while, until we de-virtualize
the public interface back again, as from the public
API side it's still a valid assert.

Change-Id: I0d62ec0db778f68fcc5afa4a6f08d54f98d74e4f
Reviewed-by: hjk <hjk@qt.io>
2022-02-17 11:43:04 +00:00
Thomas Hartmann
d0852fb2a1 StudioWelcome: Remove unused code
Change-Id: I380a35cb735669feeeac5d0293ed43c4d2ef7059
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-02-17 10:46:22 +00:00
Thomas Hartmann
1fa9034aca StudioWelcome: Avoid opening two projects on double click
This issue was introdced because we do not go to the edit mode after
opening a project. We stay in the WelcomeMode until the project is
loaded. Since the recent project list did change a second click
(aka double click) will open a second project.

We now block the update of the model for 1000ms and also block opening another
project for the same duration.

Task-number: QDS-6286
Change-Id: I52ed6aa3686594b63fe4a6134c6db1287bca1dcb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2022-02-17 10:45:53 +00:00
Thomas Hartmann
0d319ac3a1 QmlDesigner: Fix loading of .metainfo for versioned folders
This fixes a regression introduced by 7ea6492a17.
Since we actually check if import folders exist,
we did not take versioned folders into account. e.g. 'MyPlugin.1'
Extended and cleaned up the manual test case.

Task-number: QDS-6078
Change-Id: I3235d8fe498745903c5ca897e25e3d43222c119f
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2022-02-17 10:45:37 +00:00
Mahmoud Badri
c8481710c9 QmlDesigner: Enable searching in the text editor
Also hide the bottom status bar when it is empty.

Task-number: QDS-6187
Change-Id: I053771243c268ea20df8e127831b789b854021aa
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-17 10:45:01 +00:00
Erik Verbruggen
c755de0823 McuSupport: Move kit methods out of McuSupportOptions
... and into McuKitManager

Task-number: QTCREATORBUG-26890
Change-Id: Ic5ed689458d3ef004ebb42a549c48a6326c2f45d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-17 10:41:59 +00:00
Christian Stenger
01a0f41ed5 Utils: Fix MinGW build
Change-Id: I019651bb7de30595790cfe3b79a12579ce24410f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-17 09:44:26 +00:00
Christian Kandeler
9528762855 Disable -Wmissing-field-initializers when building with GCC
This warning is enabled with -Wextra, but incomplete aggregate
initialization is quite common in modern C++ due to direct member
initialization, and we make use of that in Creator in several places.

Change-Id: I585dd70e7c5c52e4549f1c5e3b8d16cc40b260ce
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-17 09:33:20 +00:00
Christian Stenger
ff71d1fb7b Update qlitehtml to latest master
Change-Id: I3fbfcba59dbc43a617cad960556fe6484a088555
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2022-02-17 09:18:39 +00:00
Christian Kandeler
120218e0fd Update qbs submodule
... to HEAD of 1.22 branch.

Change-Id: Ib15854a88b6265f341c42f2b62d67f914fb9e747
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2022-02-17 09:18:12 +00:00
Christian Stenger
22b9628d54 Nanotrace: Fix build with older Xcode
Change-Id: Ia0f29844ba95fc75199cbfd98932d5bf4c270335
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-17 08:57:03 +00:00
Christian Stenger
85976b3caf Qbs: Include latest change in qbs build
Amends 45c018f560.

Change-Id: I161bae375e422a352ba702c1030498511bbe5d81
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-17 08:56:32 +00:00
Jarek Kobus
0b08b24682 A gift for Alessandro
Add an info to the start process log about whether it was
started by a call to QtcProcess::runBlocking() or not.
In case it was, specify the event loop mode.

Change-Id: Ie1adf0526b341eedcd0d84505075a942b057ff99
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-17 08:46:56 +00:00
Jarek Kobus
e0d6568751 QtcProcess: Fix a lacking call to setBelowNormalPriority()
Amends 825c89987c

Change-Id: Ib6a812efb924f8ea840b510656fee3a5b3b41fbc
Reviewed-by: hjk <hjk@qt.io>
2022-02-17 08:11:36 +00:00
Christian Kandeler
4cd18fb3a4 ClangCodeModel: Factor out clangd compilation db update
We want to re-use that code.

Change-Id: I9b9201b63ef4c375c24efa402c80769634287714
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-02-17 08:10:31 +00:00
Christian Stenger
59e90a439e StudioWelcome: Fix qbs build
Change-Id: I37c5f2df2480fd1357a55d36744330534385b68e
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-02-17 07:01:18 +00:00
Henning Gruendl
4b7ab40ed0 QmlDesigner: Add private api to narrow down bug
This is only a temporary patch to narrow down a bug in QtDS.

Task-number: QDS-6239
Change-Id: Icf9cde008179174fd79fb92a92372fb2b541068b
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2022-02-16 18:33:29 +00:00
Alessandro Portale
2cd7d89ec5 Android: Remove a cast in AndroidDeployQtStep::init
Don't do an additional dynamic_cast.

Change-Id: Icf3beda4e78bc03232689439e8ba264287b603ab
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2022-02-16 17:17:44 +00:00
Leena Miettinen
2a1ce51ce3 Utils: Fix UI text punctuation and capitalization
Also simplify the wording of a message.

Task-number: QTCREATORBUG-27055
Change-Id: I29df31f8484d451d8d8d1869ca3a1b182072d2c1
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-02-16 16:57:17 +00:00
hjk
33eef06f64 ProjectExplorer: Remove a 100ms delay in ApplicationLauncher
The underlying (and even local) process finished, it's unclear why
we need to withhold this information from user code for some time.

Change-Id: Id9cfbd7de9c8eab6fe63797d147043e15bfb4680
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-02-16 15:46:58 +00:00
Christian Stenger
a5a50f01b1 Fix build
Amends 45c018f560.

Change-Id: Iefb39e0855bf671a7a27f161bb99529c03fb8a66
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2022-02-16 14:10:01 +00:00
hjk
d4b060481a ProjectExplorer: Consolidate ApplicationLauncher output handling
Use the previous local version as default, as this heeds the
"Merge stderr and stdout" setting in the Build&Run options.

Change-Id: I4dc1294db6571d351555fe687e4093a5e5f54a95
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-02-16 13:59:56 +00:00
Christiaan Janssen
6e96480154 McuSupport: remove legacy support for 1.x SDKs
Task-number: QTCREATORBUG-26891
Change-Id: I011649b051c6c4c9b954b1c782685e404c3796fe
Reviewed-by: Piotr Mućko <piotr.mucko@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-16 13:50:14 +00:00
Eike Ziller
209ecc91a0 CMake: Fix configurations tab bar appearance
A tab bar should span completely above the group that it "tabs", and
have no spacing to it. Otherwise there are funny visual artifacts, and
the visual correspondance is not clear.

Add an option for spacing to LayoutBuilder for that.

Change-Id: I5ca9dc713fff95599c9ec1cf90abe8473bc67c2a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2022-02-16 13:38:41 +00:00
Christian Stenger
282c3d0dab LanguageClient: Do not send initializing request twice
Amends dc268e3157.

Change-Id: I6ca81ec336f09c02b26f47b5e00bebbc54882ed6
Reviewed-by: David Schulz <david.schulz@qt.io>
2022-02-16 13:07:59 +00:00
David Schulz
ca7e567786 LanguageClient: cancel running document symbol requests
Change-Id: I963d76e1d4ccc264cf20206b33a9de990d472a33
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2022-02-16 12:56:20 +00:00
hjk
0f2108e57d ProjectExplorer: Dissolve ApplicationLauncherPrivate::localProcessDone
The odd delay seems to have no or different reasons in both places.
Aim at handling them one by one.

Change-Id: I4682954eb67a09dead95d4df16c2ab4da45a7fb7
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2022-02-16 12:10:35 +00:00
Piotr Mućko
76453511cc McuSupport: plugin code formatting
Change-Id: I2d1c3dfad3fddce7706056997d284292e13d3ad2
Reviewed-by: hjk <hjk@qt.io>
(cherry picked from commit 27cadc86ba)
2022-02-16 11:18:28 +00:00