Commit Graph

64672 Commits

Author SHA1 Message Date
Tobias Hunger
182c460a2b CMake: Do not treat project with the empty string as a name as invalid
CMake will happily accept the empty string as a project name, so do not
treat that is invalid in Creator. Apparently the empty project name will
get generated by CMake itself if no project() command is found in the
top level CMakeLists.txt file.

Make sure to set a sensible name if the top-level project has no name,
using the directory name of the source directory instead.

Change-Id: I3b861daa13c1d0fec31c294ef0ac15338310020d
Fixes: QTCREATORBUG-24044
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-11 12:34:25 +00:00
Tobias Hunger
8c830f79e7 CMake: Improve debugging output when parsing projects from file-api
Change-Id: Ifaed0e5a6566923052a4e2f00adbb3617cd42c8b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2020-06-11 12:34:01 +00:00
hjk
dc68792c3a FakeVim: Start porting QRegExp uses to QRegularExpression
QRegExp will not exist in Qt 6.

Task-number: QTCREATORBUG-24098
Change-Id: Iaf239fd110b2294ad1fe20a598d416a4f43a3abf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-11 11:34:09 +00:00
hjk
26eaa46464 FakeVim: Use QRegularExpression in C-A/C-X handling
Task-number: QTCREATORBUG-24098
Change-Id: If2cff3b9059856afa8793f4df9acc0cde27e2e1e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-11 11:31:38 +00:00
hjk
c161a1af15 ProjectExplorer: Use QRegularExpression in SelectableFilesModel
Task-number: QTCREATORBUG-24098
Change-Id: I741f754dbb361310fa4e84241e75c39df7fc2627
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-11 11:08:53 +00:00
Tim Jenssen
3acdb7891b Merge remote-tracking branch 'origin/qds-1.59'
Change-Id: I8891e7490a7fd51997a3b57561961f6134be3252
2020-06-11 12:54:10 +02:00
Thomas Hartmann
417530c3a8 QmlDesigner: Show "None" instead of magic -1 in timeline settings
When nothing is set as fixed frame we show "None" in the UI instead
of a missleading -1.

Task-number: QDS-1139
Change-Id: I22edfefe8f05a343467e66e66424d10b5ca8a4bc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-06-11 10:31:01 +00:00
Alessandro Portale
e4ded6a08f McuSupport: Enable resetting of path choosers to the default path
This change adds a "reset" button to the path choosers. Pressing it
sets the path to the default path.

The default path is now overwritable by the system settings value (if
present). This way, there is only one and only default path, which
allows us to again simplify McuPackage::writeToSettings().

Task-number: QTCREATORBUG-23860
Change-Id: I192663f3487250b9eba4773d2510abf3f9e66127
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-11 09:47:04 +00:00
Christian Stenger
d41502ebb0 GLSL: Fix freeze on unexpected end of file
Fixes: QTCREATORBUG-24070
Change-Id: I2c503932cb2064f4871a4467c26f7af0efb50bc8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-11 08:51:05 +00:00
hjk
8114a58847 Utils: Port ClassNameValidatingLineEdit to QRegularExpression
Task-number: 24098
Change-Id: Ifeae0a864455e99ec7d358d293507072abdf9057
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-11 08:50:23 +00:00
Denis Shienkov
8d572ea18e ProjectExplorer: Add support for new M32R architecture
This commit adds new ProjectExplorer::Abi::M32RArchitecture
entry for the Renesas M32R architecture:

 * https://www.renesas.com/us/en/products/microcontrollers-
microprocessors/m32r.html

Also now the ABI of GCC compiler for this architecture is recognized
correctly.

Change-Id: Ic6a328e06c2824489c1f18895260355c449e7da8
Reviewed-by: hjk <hjk@qt.io>
2020-06-11 08:18:56 +00:00
Denis Shienkov
daf0a750cb ProjectExplorer: Recognize GCC ABI for Compact Risc architecture
Now the ABI of GCC compiler for the Compact Risc (aka CR16) architecture
is deteted correctly.

Change-Id: Ifbe12a26036707da4a9df361d67b6033b29c0748
Reviewed-by: hjk <hjk@qt.io>
2020-06-11 08:17:36 +00:00
Thomas Hartmann
a5ef3260fa QmlDesigner: Adapt to QtQml.QtObject
* Adding QtObjectPane for QtQml support
* Allowing also QtQml.QtObject to determine major version

Change-Id: If82ea1c52cb4b78415d0f422e22b5423903b5abb
Reviewed-by: Christian Kamm <mail@ckamm.de>
2020-06-11 07:51:24 +00:00
hjk
d0960a33ac BinEditor/ClangCodeModel: Remove non-uses of #include <QRegExp>
Task-number: 24098
Change-Id: I58a52ad3c384cc945799ad73e5d3ce392245cd50
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-11 07:48:35 +00:00
hjk
5bbf81011e Utils: Use QRegularExpression in BuildableHelperLibrary
Task-number: QTCREATORBUG-24098
Change-Id: I2c6885310575d25ea6d8cf4528873bcebcddb324
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-11 07:17:14 +00:00
David Schulz
3f08961322 Utils: fix selectAt used with invisible blocks
Using QTextCursor::movePosition with QTextCursor::NextBlock seems to
jump over invisible blocks. Use setPosition instead.

Change-Id: I3271fb8570678ef6f09141032948dedee308e20c
Fixes: QTCREATORBUG-24019
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-11 06:52:01 +00:00
Andre Hartmann
b059095f3f Don't pass full command line to exitMessage()
Amends 00b692e67e

SynchronousProcessResponse::exitMessage() takes only
the executable as first parameter. Passing a whole
command line there has two disadvantages:

1. Sensible data (like passwords) that needs to be obfuscated
   is shown as plain text in the output pane.
2. Forward slashes like in "refs/for/master" are converted
   to backslashes on Windows.

While the second case could be fixed with an overload
of CommandLine to exitMessage, the first point probably
needs more work at several places.

So let's just remove the arguments, like it was in Creator versions
before 00b692e67e

Fixes: QTCREATORBUG-24153
Change-Id: I546f7238347466eac089ba3e7f74201c2be40d39
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2020-06-11 05:03:14 +00:00
Eike Ziller
5fcbc55c2c Meson: Hopefully final build fix for older GCC
Amends 77d7bb5014.

Change-Id: I94df369cd8aae7d978ede631103199a3a7cb5b26
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-10 19:36:03 +00:00
Thomas Hartmann
ad4c5e0258 QmlDesigner: Fix puppet crash
Change-Id: I2a408d090c4bbf2c3da7f03473312eff4b7e6c34
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-06-10 16:02:59 +00:00
hjk
26121da90c Android: Use QRegularExpression for parsing logcat output
Task-number: QTCREATORBUG-24098
Change-Id: I3df81c06611f1547b9424e31ea1b4a4541573946
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-10 15:36:15 +00:00
Tim Jenssen
83148cbb89 unittest: another adjustment to new constructor
Change-Id: Id1d38fcca8f4b51dea2c17b466521534b73d7ae7
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-06-10 15:22:08 +00:00
Marco Bubke
50d3067bcd UnitTests: Refactor printing
Move standard printing functions to extra header.

Change-Id: Ib032047235297dfe3ac0bcdbd39c353493f3ae0d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-10 13:34:37 +00:00
Marco Bubke
5a7a6cb02d Sqlite: Remove last usages of UpdateCallback
Change-Id: Ie7ffe06c55a7827fae20996e5b0eadb9892b9e23
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-10 13:34:27 +00:00
Christian Stenger
ba580bba83 QmlJS: Fix line number for string literals (Part 2)
Amends 626807c94e. Scanning the strings appears differently if
using multi-line strings and using the line terminator at the beginning
of a string or having already some characters present.

Fixes: QTCREATORBUG-23777
Change-Id: I840a11e3b0e06adda443849f926189bda9dc2e4b
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@qt.io>
2020-06-10 13:07:23 +00:00
Christian Kandeler
4fbd68183b clangbackend: Fix lexicographical sorting of completions
Utf8String has a weird operator<, so we did not get the expected results
from our string comparisons.

Task-number: QTCREATORBUG-6242
Change-Id: I0e94dc42d6e04ab833efcce41463b7024455b6d8
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-06-10 12:50:50 +00:00
Eike Ziller
228568af7a Meson: More build fixes for older GCC
Amends 77d7bb5014.

Change-Id: Ib55feb37db1c66ca162e097fdcab7fe6ad538cf2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-10 11:49:09 +00:00
Tim Jenssen
bca0c2c3f4 clangrefactoring: fix cmake and qbs after file rename
Change-Id: Ic78df938ad4edced664ef968d834c59110f4ab37
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-06-10 11:32:30 +00:00
Christian Kandeler
31ef76d304 Sqlite: Fix qbs build for unit test
Change-Id: I02c0917788fbe97377b69e30d08e84323d9c1e97
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-10 11:10:44 +00:00
David Schulz
bd432c2c8a TextEditor: fix updating completions after cursor navigation
Notify the assistant that something has changed after cursor movement
shortcuts.

Task-number: QTCREATORBUG-24077
Fixes: QTCREATORBUG-24071
Change-Id: Ic956c08140c47a8edc9603227008062a7ab95fa0
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-10 10:50:21 +00:00
hjk
dbb19b5986 Android: Use QRegularExpression in AndroidCreateKeystoreCertificate
Task-number: QTCREATORBUG-24098
Change-Id: I58e26a882d8ac5015c02b9dc9b7ff4934091b18a
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
2020-06-10 10:40:25 +00:00
Christian Kandeler
a9c497e9a4 CPlusPlus: Fix overload resolution involving default arguments
If one of the overloads had additional default arguments, then for each
of these, its priority was increased, which does not appear to make any
sense.

Fixes: QTCREATORBUG-17807
Change-Id: Id5be81ce52c615a424fe4314d2e50385b3fb2b1c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-06-10 10:36:10 +00:00
Christian Stenger
43b6b3d1c8 Meson: Fix compile for gcc 5.3
Amends 77d7bb5014.

Change-Id: Ic613e2b9ddcc0e4b86ed78ddc997c7c40120316c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-10 10:31:06 +00:00
David Schulz
14b163c961 TextEditor: cleanup after raised minimum Qt version
Change-Id: I0bd6747e7805ba3348062c2f31af4f6160e047e9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-10 09:51:30 +00:00
Tobias Hunger
443f2bae50 CMake: Filter out non-directories from LD_LIBRARY_PATH/PATH
Task-number: QTCREATORBUG-23997
Change-Id: I4b92cd484305614b30c70bbdbd8815b0d85b7d98
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-10 09:42:45 +00:00
hjk
3a690154cb Android: Use QRegularExpression to check package names
Task-number: QTCREATORBUG-24098
Change-Id: I1082d39e65c4237592c81758fcdde614fc50d6e0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-10 09:24:52 +00:00
hjk
61d6120619 Utils: Port NewClassWidget to QRegularExpression
Task-number: 24098
Change-Id: I6dcc14f474ffe0b25d2a4db948346c2274fcfeea
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2020-06-10 09:17:48 +00:00
Marco Bubke
acf5329422 Sqlite: Fix null handling
Most of it is only silencing a warning but one is fixing a faulty test. So
writing null values should now be working.

Change-Id: If702e1fc8176a9e0ae82a5589c719d567929202b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-10 09:05:00 +00:00
Henning Gruendl
e330cccbfe QmlDesigner: Add dialog title label in flow view
* Add support for showing the dialog title of a flow decision in the
  flow view.
* Add preconfigured positions for the label to be placed.

Task-number: QDS-2248
Change-Id: Ib113ac44e9bdc084d18a3a6083b767487bd9cde2
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-06-10 08:54:47 +00:00
Christian Kandeler
758f79923f CppEditor: Fix operator refactoring
The refactoring option was not triggered if the operator definition had
a different amount of whitespace after "operator" than the declaration.

Fixes: QTCREATORBUG-6236
Change-Id: Idf6438203e28d3f1effe0a0375d6563f813a9726
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-06-10 08:27:38 +00:00
hjk
30610b7991 CMake: Remove some now-unused code
Change-Id: I39dd5f8de0ca4e5461cd01885029e1c65ac8ec05
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2020-06-10 07:50:01 +00:00
Christian Stenger
d0ecf4537a LSP: Fix missing include
Amends 1f303ffcc5.

Change-Id: I6cf8bf0b1d40c7de1294769bd9a6a406ce74ef92
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-06-10 07:19:18 +00:00
hjk
afde217f28 Debugger: Convert a QRegExp use in source path map
Task-number: QTCREATORBUG-24098
Change-Id: I1ee441a60cbf362d38459bcef869e02d7fca9b7e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2020-06-10 07:07:23 +00:00
Christian Stenger
ae0d913e2f CMakePM: Fix compile
Amends 01b0d4f8f5.

Change-Id: I05a65684c51b960eeb4803b5d764bc8ff5a22626
Reviewed-by: hjk <hjk@qt.io>
2020-06-10 06:53:28 +00:00
hjk
1f303ffcc5 LSP: Port to QRegularExpression
Task-number: 24098
Change-Id: Ic7efcf3bb3d268e52ac545a72e5188c5affda004
Reviewed-by: David Schulz <david.schulz@qt.io>
2020-06-10 06:36:45 +00:00
Aleksei German
e069293a4b QmlDesigner: Variant types for Binding Editor
- Variant and alias types proper support
 - Extended instantiation options for Editor
Task: QDS-2264

Change-Id: I95ff24fb81ce64b4effc64803304ff2b150a7ff6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-06-09 18:44:14 +00:00
Aleksei German
def4655042 QmlDesigner: Fix for Binding Editor launch pos
Task: QDS-1418

Change-Id: Id0c051d7187648a1477de70769fb7a47363ccdeb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2020-06-09 18:43:42 +00:00
Tobias Hunger
01b0d4f8f5 CMake: Remove magic configuration from CMake
Get rid of magic configuration handling in the CMakeProjectManager.

* Use CMakeCache.txt as the sole source of truth, do not keep
  a shadow copy of configuration in the .user file
* Have initial CMake arguments that are easy to edit in batch
  (Fixes: QTCREATORBUG-18179) used whenever no CMakeCache.txt
  file is in the build directory. These allow for any thing that
  can be passed to CMake on the command line.
  (Fixes: QTCREATORBUG-16296)
* Ask when changes to CMake configuration were not applied
  (Fixes: QTCREATORBUG-18504)
* Run cmake with arguments effecting its configuration only when
  the CMake settings are changed in the UI, run CMake without any
  special arguments in all other cases.
* Get rid of the confusing dialog used to keep settings in sync between
  what is in CMakeCache.txt and Creator (Fixes: QTCREATORBUG-23218)

Change-Id: I26d55be7df733f084f5691ecf7d7b4352f58b8e7
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2020-06-09 16:34:00 +00:00
Christian Stenger
c02a0037d5 Sqlite: Fix unit test build
Change-Id: I29c15bbad053a3bac01ea05ad06ff994ce0d8d06
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2020-06-09 14:50:09 +00:00
Marco Bubke
06866c3ee9 Sqlite: Use a more efficient update hook
Change-Id: Ic6df1f4ba6b914c7751faf7cf89083fa50a92793
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2020-06-09 14:48:27 +00:00
Christian Stenger
ebfe03c151 QmlDesigner: Fix compile
Amends 3bd22bd2d7.

Change-Id: I2193d49056a95a818087b48fbf571196627bb3e3
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2020-06-09 14:03:23 +00:00