That's part of a1947aeffe1 in qtbase, with manual adaptation.
It looks like we've been out-of-sync with upstream already before.
Change-Id: Ie6ef9e4fce44e01944194dc27bd3f54274ad7c6f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
- Fix for connections order in view
- Fix for binding and connection editor init crash
Change-Id: If0faf401b8e89a5548c65f07284138e869612c95
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Use the original offset only in the one place where it is relevant.
This amends commit 8eac3fba80.
Fixes: QTCREATORBUG-24221
Change-Id: Idcfc5ecc8a76c875c4f2ca5890d0ba95ce52a6e9
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Activate new ADS feature focus highlight
* Remove resources.qrc and related *.svg files
* Clean up new and existing source
Base repository was merged until commit
3de877fe5635ff51a6d1205ca98aad85d204427f
Merged changes from base repository include the following:
* Fix wrong current index when removing a widget from DockAreaLayout
* Fix invisible TabWidget for DockWidgets that are not part of a
restored state
* Enable ClickFocus for DockWidget to support focussing in case the
content does not support it
* Move focus related functionality into DockFocusController class
* Add new DockManger config flag FocusStyling
* Add support for focus styling of FloatingWidgetTitleBar
* Improve focus handling when dropping a DockWidget
* Improve highlighting focused DockWidget
* Improve setting of DockWidgetTab focus
* Add styling of focused DockWidget
* Fix docking of floating widgets for macOS
* Fix setting of DockingStateReader file version - use internal file
version instead of user file version
* Fix saveState() and restoreState() version handling to work like the
function from QMainWindow
* Fix escape key handling in native window event function if event
WM_EXITSIZEMOVE occurs
* Implement windows drag handling with native WM_ nonclient area
messages
* Fix showing DockArea when inserting a DockWidget in a hidden DockArea
* Fix setting DockAreaTabBar index to prevent showing of tab 0 when
inserting a DockWidget into an area with no current index tab
* Fix wrong insertion order of DockWidget when dropping a floating
widget to the left or top container drop area
* Fix tab changes position when redocking it to the same position
* Add nullptr check to fix potential nullptr access when closing a
FloatingDockContainer
* Fix single DockArea cannot be split
* Fix visibility issue when adding dock widget after all other dock
widgets have ben closed
* Fix FloatingDragPreview flashing of hidden overlay when dragging the
last visible DockWidget in non opaque docking mode
* Fix FloatingDragPreview preventing dock widget from floating when
dragging over another dock widget
* Fix DockWidget::setWidget function to test for QAbstractScrollArea
instead of QScrollArea. Now setWidget properly supports ItemViews like
QTreeView or QTableView
* Fix wrong display of center drop area when dragging over invisible
dock area title bar
* Fix bug that drop overlay sometimes was not visible when moving the
drag preview over a floating window
* Fix dropping of FloatingDragPreview into center of dock container with
only one single visible dock area. If this happens the dropped dock
widget needs to get tabified
* Fix crash when trying to make a DockWidget floating in non-opaque mode
if the DockWidget is not floatable
* Fix DockWidgetTab to provide the right size when starting floating
* Add DockWidget functions setAsCurrentTab, raise, isCurrentTab,
isTabbed
* Add new config flag HideSingleCentralWidgetTitleBar to enable a
central single dock widget in the main dock container (dock manager)
without titlebar
* Fix DockContainerWidget::hasTopLevelDockWidget() and
DockContainerWidget::topLevelDockArea() to work properly also for the
main non floating dock container
* Fix ElidingLabel to properly support Qt::ElideNone
* Add setElideMode function to DockWidgetTab
* Add setFullScreen(), setNormal() and isFullScreen() function to
DockWidget
* Fix takeWidget() function and fixed setWidget() function to handle
case when there is already a content widget
Task-number: QDS-2180
Change-Id: Ie30648ba329016c91fd19e9b4e12e31e47614b18
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Sometimes source groups would start from the root directory rather than
having the correct folder specified in CMake. This was because the
incorrect path was being used to find the relative path. Forward
baseDirectory to the overrideBaseDir parameter of addNestedNodes() to
guarantee the proper directory is used as the base.
Fixes: QTCREATORBUG-23896
Change-Id: I213c02a3fff3c10e4b6a58211600dd16ac257bbc
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
When the process is aborted, both errorOccurred and then finished is
sent. Because of the combination of deleteLater and QueuedConnection
this leads to m_process being already nullptr when finished is sent, so
add some guards.
Change-Id: I446114176f8fa5934b411b39d77c97d6267303fa
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... when visualizing the range of a code model warning.
Otherwise, warnings covering multiple lines can get too noisy.
Fixes: QTCREATORBUG-18659
Change-Id: Ieff7729d8069e791027f7bdde5fca13f4c7f7163
Reviewed-by: David Schulz <david.schulz@qt.io>
This broke in aef8255ba0, which removed the collection of MSVC
toolchains in a global variable for clang-cl to inspect.
Change-Id: I949aa0a098ed307d264e8fe23625586018507d00
Reviewed-by: hjk <hjk@qt.io>
Effectively 7cba2acd2cc and 0d88721d772 from qtbase.
Task-number: QTCREATORBUG-24098
Change-Id: I88902b358d88e34032f588b9eb0af13c5b9d8675
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
QRegExp will not be available in Qt 6.
Task-number: QTCREATORBUG-24098
Change-Id: Ia1aec515615ecaf8e92ae1a3a1dad92cb999bfb1
Reviewed-by: Lukas Holecek <hluk@email.cz>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Code snippet:
template<class T> struct MyStruct { int value; };
int main() {
auto s = MyStruct<int>();
s.value; // "value" is not found
}
This fixes find usages for unique_ptr declared as auto like this:
auto ptr = std::unique_ptr<MyStruct>(new MyStruct());
ptr->value;
Also fixes in-place constructors:
std::unique_ptr<MyStruct>(new MyStruct())->value;
Fixes: QTCREATORBUG-15364
Change-Id: I8d452a77fe85e63665ec8d4c4afbcf8aad063121
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This was caused by 7419e09d0f.
Change-Id: I423047d353698798c712f9a32603e955ae1ee15c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
The intermediate "category" nodes where never filtered out.
CategorySortFilterModel was changed to use filterRegularExpression() and
setFilterFixedString does not set that (it only affects filterRegExp()
which we need to get rid off).
Set a regular expression directly instead of a fixed string.
Amends 47e576528e
Change-Id: I6f844027b83d66ca2d5088d83e6e84b01b9eda45
Reviewed-by: hjk <hjk@qt.io>
Do not ignore _any_ directory starting with "build", just a toplevel one
(which possibly is a CMake build directory).
Amends bd4c9ea250
Change-Id: I1f80db1241e51c4d49d94593cbcaf881c8659cb5
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
We should use the fonts folder as default if it exists.
Change-Id: If18714ffa195856f14d7960b46b20992b48faa6f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Not in Qt 6, and I don't see a difference.
Change-Id: I4556e48f9ab60b4024ca46a7ed1389b54744c891
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Having a search inside a document and switching the find options
to use regular expressions may end up in lots of warnings
regarding using an invalid expression for a match call.
Check beforehand to avoid this.
Change-Id: Ia929090ae3910ff3fa87b57a5718293d2b6ccd04
Reviewed-by: David Schulz <david.schulz@qt.io>
Accordingly Adjust the svg element Ids to new png locations in the
source tree.
Change-Id: I717dd7165c571e69322a1cce8d609f49c6bc75bc
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
I figured it might be easier to keep track of active hack here and
also recognized includes that only exist for that reasons in user code
if it's always the same.
Change-Id: I4bf6af493443148cf30a6903d541cd9dc58946da
Reviewed-by: David Schulz <david.schulz@qt.io>
