Current implementation requires each VCS to connect to the referenceClicked
signal. Only Git does it, but this is conceptually wrong. If other VCSs
would connect to the same signal, all of them will act upon clicking a
link, which can result in multiple editors, most of them are likely to be
invalid anyway.
By default executes vcsDescribe. Can be extended or modified by subclasses.
Change-Id: Ib953009efd77446a4b2963f0aa8a2f3f3d26509f
Reviewed-by: Artur Shepilko <artur.shepilko@nomadbyte.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Do not subtract from unsigned (size) values.
Amends d15d15efa2.
Change-Id: I9a8b09d3733b49ea646ae8a14caefcf5c908fad3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This makes it more likely that using other clang-tidy and clazy binaries
than the ones shipped with Qt Creator will work.
Done-with: Nikolai Kosjar
Fixes: QTCREATORBUG-23672
Change-Id: I8c44e037ca8d50505fe10032034edaf4f408d52c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
And inline non-shared object id.
I regularly stumble over this speciality when doing mass refactorings
in the code base and I believe the extra benefit this namespace level
has does not outweigh it.
Change-Id: I3694a656f1095dcb5509b212b9e1d25ae5c8b5ec
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Setting it to CMAKE_OSX_DEPLOYMENT_TARGET if that is set
(either via cmake directly, or, as we do for the packages,
by setting the MACOSX_DEPLOYMENT_TARGET environment variable).
Fixes: QTCREATORBUG-22466
Change-Id: I7378bc32be6d66cf4e4b1eac1530c89159e74804
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
... so that the first #if is not grayed out.
Fixes: QTCREATORBUG-23714
Change-Id: Ia014fd8cd768ea9530567ba8c712bdc0c4063091
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It can be rather difficult to see the actual content of a raw string
literal among all the clutter. Let us help the user by highlighting the
string differently from the delimiter.
Fixes: QTCREATORBUG-19119
Change-Id: I14447d62a686d82a2f2e123786a9b0eec16a0fa2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Forward declarations for items in QList are not sufficient for moc anymore.
Task-number: QTCREATORBUG-24098
Change-Id: I537b9fbd4fb0b95937a051fdc0c7f106a6c8cd65
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
I don't think it's worthwhile to put that in some header, it's only
four occurrences.
Task-number: QTCREATORBUG-24098
Change-Id: Ic4e505f264a5d9970d8be1071c849d2bb3389746
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Change-Id: I1d4fc0f25f1882a34058c66c51376982cc70238e
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Implicitly included header was removed.
Change-Id: Ib96242b11a17261c755124a2355c757cc5ec41bd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Make import of build directories using Qt 6 work. This assumes that
Qt 6 will use the same layout as Qt 5 and that there is qmake (which
is assumed everywhere in Creator right now).
Change-Id: I37194b186127befb3df32ebacf86c032c71ef18a
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
And restrict the auto test to Qt<6.
Task-number: QTCREATORBUG-24098
Change-Id: Idfbe94bc1a4b2d5a8c23a07a031520775bb17cd3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... not just functions.
This includes global variables and static members.
Fixes: QTCREATORBUG-18828
Change-Id: Iee9f83a4f955a859c6fc4038c61997b30afdaec8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
As suggested by clang-tidy's "modernize-use-override" check and to match
Qt Creator's coding guidelines.
Change-Id: I2cfef113e21a0cd44d18a5b98e9bc8427563c53a
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Parsing may end up with incomplete information when parsing documents
that are currently edited and contain syntax errors due to
incomplete changes.
This resulted in not re-adding all items which in turn led to lose
also its expanded state when re-adding it in a later successful parse.
Avoid the need to expand manually again and again by caching the
expanded state for a couple of re-parses.
Change-Id: I2994b9c7ab56c0c76f416d10247e68dea271cd10
Reviewed-by: David Schulz <david.schulz@qt.io>
Deprecated, and declared to have no effect for Qt >= 5.12.
Task-number: QTCREATORBUG-24098
Change-Id: I11067b8e2ae40ff1f1dd4de92a734a40d2eae556
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When editing the "Path" variable on Windows, the PathListDialog
currently returns the path with all '\\' dir separators turned
into '/'. Such conversion makes sense for the "Add ..." operation
but should not be enforced for all paths.
Or in other words: Do it like EnvironmentWidget does.
This change removes conversion of the separators of all paths.
Task-number: QTCREATORBUG-24213
Change-Id: Icab1bdc190e55e8f5724a93b7cd14b08e4c68829
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
At some point in the preprocessing stage, some tokens get "squeezed", so
their associated string no longer refers to the document content, but
only to their own symbol. However, there is at least one context that
operated under the assumption that the token's offset still pointed into
the "global" string. As the token's offset is zero after parsing, this
lead to the same piece of code being preprocessed in an infinite loop.
Fixes: QTCREATORBUG-19525
Change-Id: I231ba51811cfa0b5c6dfe7f75fe0384472252c6f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
When reparsing while modifying a file it can happen that
the parse failed for some reason or did not provide full
information due to syntax errors the code model cannot cope
with.
This in turn can purge items from the test tree. Re-adding
the items in a later reparse had just added the item and
did not take care of (former) check states.
Add simple caching mechanism to keep track of check states
and use them if available.
Task-number: QTCREATORBUG-24099
Change-Id: I3ca04f5fd58810df71582972e6fe96a00cfc48f1
Reviewed-by: David Schulz <david.schulz@qt.io>
Note that this is more a temporary workaround as there are more changes
to come (qsizetype instead of int for sizes, switch QList/QVector
aliasing).
Task-number: QTCREATORBUG-23806
Change-Id: Ic815fe293b1c4922276c127dec61930dc365acae
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The only reason it was required to be in Core plugin, was its use of Id,
which now is available in Utils.
Change-Id: I66ce863c24924e6448d339b3422538a7fe167336
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
