Files
qt-creator/src/plugins/debugger/watchwindow.cpp
David Schulz 15e56078b6 Debugger: Improve keyboard navigation in locals view
Expanding items in the locals view results in replacing the original
tree item with a newly created one. This ultimately resets the selection
and the current item of the view, which in turn makes it cumbersome to
navigate by keyboard.

Save a list of selected inames and the iname of the current index when
requesting the update and try to reselect them after the update
finished.

Fixes: QTCREATORBUG-27569
Change-Id: I9d8f51631e4ee490e19307877cbef44798506016
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2024-04-30 10:56:02 +00:00

187 lines
5.5 KiB
C++

// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#include "watchwindow.h"
#include "debuggeractions.h"
#include "debuggerinternalconstants.h"
#include "debuggertr.h"
#include "watchhandler.h"
#include <utils/algorithm.h>
#include <utils/aspects.h>
#include <utils/qtcassert.h>
#include <QHeaderView>
#include <QScrollBar>
#include <QTimer>
namespace Debugger {
namespace Internal {
WatchTreeView::WatchTreeView(WatchType type)
: m_type(type)
{
setObjectName("WatchWindow");
setWindowTitle(Tr::tr("Locals and Expressions"));
setIndentation(indentation() * 9/10);
setUniformRowHeights(true);
setDragEnabled(true);
setAcceptDrops(true);
setDropIndicatorShown(true);
m_progressDelayTimer.setSingleShot(true);
m_progressDelayTimer.setInterval(80);
connect(&m_progressDelayTimer, &QTimer::timeout, this, &WatchTreeView::showProgressIndicator);
connect(this, &QTreeView::expanded, this, &WatchTreeView::expandNode);
connect(this, &QTreeView::collapsed, this, &WatchTreeView::collapseNode);
connect(&settings().logTimeStamps, &Utils::BaseAspect::changed,
this, &WatchTreeView::updateTimeColumn);
}
void WatchTreeView::expandNode(const QModelIndex &idx)
{
model()->setData(idx, true, LocalsExpandedRole);
}
void WatchTreeView::collapseNode(const QModelIndex &idx)
{
model()->setData(idx, false, LocalsExpandedRole);
}
void WatchTreeView::currentChanged(const QModelIndex &current, const QModelIndex &previous)
{
emit currentIndexChanged(current);
BaseTreeView::currentChanged(current, previous);
}
void WatchTreeView::setModel(QAbstractItemModel *model)
{
BaseTreeView::setModel(model);
setRootIndex(model->index(m_type, 0, QModelIndex()));
setRootIsDecorated(true);
if (header()) {
header()->setDefaultAlignment(Qt::AlignLeft);
if (m_type == ReturnType || m_type == TooltipType)
header()->hide();
}
auto watchModel = qobject_cast<WatchModelBase *>(model);
QTC_ASSERT(watchModel, return);
connect(model, &QAbstractItemModel::layoutChanged,
this, &WatchTreeView::resetHelper);
connect(watchModel, &WatchModelBase::currentIndexRequested,
this, &QAbstractItemView::setCurrentIndex);
connect(watchModel, &WatchModelBase::itemIsExpanded,
this, &WatchTreeView::handleItemIsExpanded);
connect(watchModel, &WatchModelBase::updateStarted,
this, &WatchTreeView::handleUpdateStarted);
connect(watchModel, &WatchModelBase::updateFinished,
this, &WatchTreeView::handleUpdateFinished);
updateTimeColumn();
}
void WatchTreeView::updateTimeColumn()
{
if (header())
header()->setSectionHidden(WatchModelBase::TimeColumn, !settings().logTimeStamps());
}
void WatchTreeView::handleItemIsExpanded(const QModelIndex &idx)
{
bool on = idx.data(LocalsExpandedRole).toBool();
QTC_ASSERT(on, return);
if (!isExpanded(idx))
expand(idx);
}
void WatchTreeView::handleUpdateStarted()
{
m_selectedInames = Utils::transform(selectedIndexes(), [this](const QModelIndex &idx) {
return model()->data(idx, LocalsINameRole).toString();
});
m_currentIname = currentIndex().data(LocalsINameRole).toString();
if (m_type == LocalsType)
m_progressDelayTimer.start();
}
void WatchTreeView::handleUpdateFinished()
{
m_progressDelayTimer.stop();
if (m_type == LocalsType)
hideProgressIndicator();
auto watchModel = qobject_cast<WatchModelBase *>(model());
QTC_ASSERT(watchModel, return);
QItemSelection selection;
QModelIndex currentIndex;
watchModel->forAllItems([&](Utils::TreeItem *item) {
const QModelIndex index = item->index();
const QString iName = index.data(LocalsINameRole).toString();
if (m_selectedInames.contains(iName))
selection.append(QItemSelectionRange(index));
if (iName == m_currentIname)
currentIndex = index;
});
selectionModel()->select(selection, QItemSelectionModel::Select);
if (currentIndex.isValid())
setCurrentIndex(currentIndex);
}
void WatchTreeView::reexpand(QTreeView *view, const QModelIndex &idx)
{
if (idx.data(LocalsExpandedRole).toBool()) {
//qDebug() << "EXPANDING " << view->model()->data(idx, LocalsINameRole);
if (!view->isExpanded(idx)) {
view->expand(idx);
for (int i = 0, n = view->model()->rowCount(idx); i != n; ++i) {
QModelIndex idx1 = view->model()->index(i, 0, idx);
reexpand(view, idx1);
}
}
} else {
//qDebug() << "COLLAPSING " << view->model()->data(idx, LocalsINameRole);
if (view->isExpanded(idx))
view->collapse(idx);
}
}
void WatchTreeView::resetHelper()
{
QModelIndex idx = model()->index(m_type, 0);
reexpand(this, idx);
expand(idx);
}
void WatchTreeView::reset()
{
BaseTreeView::reset();
if (model()) {
setRootIndex(model()->index(m_type, 0));
resetHelper();
}
}
void WatchTreeView::doItemsLayout()
{
if (m_sliderPosition == 0)
m_sliderPosition = verticalScrollBar()->sliderPosition();
Utils::BaseTreeView::doItemsLayout();
if (m_sliderPosition)
QTimer::singleShot(0, this, &WatchTreeView::adjustSlider);
}
void WatchTreeView::adjustSlider()
{
if (m_sliderPosition) {
verticalScrollBar()->setSliderPosition(m_sliderPosition);
m_sliderPosition = 0;
}
}
} // namespace Internal
} // namespace Debugger