forked from qt-creator/qt-creator
Now only one piece of code needs to be written to both linkify output in
an output pane and create tasks for it in the issues pane.
The calling sites are also simplified. For instance, until now, build
steps had to feed their output parsers manually and then push the
created tasks up the signal stack in parallel with the actual output,
which the build manager relied upon for cross-linking the output pane
content. Afterwards, the output would get forwarded to the formatter
(and parsed for ANSI escape codes a second time). In contrast, a build
step now just forwards the process output, and task parsing as well as
output formatting is done centrally further up the stack.
Concrete user-visible improvements so far:
- File paths in compiler/linker messages are clickable links now.
- QtTest applications now create clickable links also when run
as part of a build step, not just in the app output pane.
Task-number: QTCREATORBUG-22665
Change-Id: Ic9fb95b2d97f2520ab3ec653315e9219466ec08d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
241 lines
7.0 KiB
C++
241 lines
7.0 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2016 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of Qt Creator.
|
|
**
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include "cmakeprocess.h"
|
|
|
|
#include "cmakeparser.h"
|
|
|
|
#include <coreplugin/messagemanager.h>
|
|
#include <coreplugin/progressmanager/progressmanager.h>
|
|
#include <coreplugin/reaper.h>
|
|
#include <projectexplorer/projectexplorerconstants.h>
|
|
#include <projectexplorer/taskhub.h>
|
|
|
|
#include <utils/stringutils.h>
|
|
|
|
#include <QDir>
|
|
|
|
namespace CMakeProjectManager {
|
|
namespace Internal {
|
|
|
|
using namespace ProjectExplorer;
|
|
|
|
static QString lineSplit(const QString &rest, const QByteArray &array, std::function<void(const QString &)> f)
|
|
{
|
|
QString tmp = rest + Utils::SynchronousProcess::normalizeNewlines(QString::fromLocal8Bit(array));
|
|
int start = 0;
|
|
int end = tmp.indexOf(QLatin1Char('\n'), start);
|
|
while (end >= 0) {
|
|
f(tmp.mid(start, end - start));
|
|
start = end + 1;
|
|
end = tmp.indexOf(QLatin1Char('\n'), start);
|
|
}
|
|
return tmp.mid(start);
|
|
}
|
|
|
|
CMakeProcess::CMakeProcess()
|
|
{
|
|
connect(&m_cancelTimer, &QTimer::timeout, this, &CMakeProcess::checkForCancelled);
|
|
m_cancelTimer.setInterval(500);
|
|
}
|
|
|
|
CMakeProcess::~CMakeProcess()
|
|
{
|
|
if (m_process) {
|
|
processStandardOutput();
|
|
processStandardError();
|
|
|
|
m_process->disconnect();
|
|
Core::Reaper::reap(m_process.release());
|
|
}
|
|
|
|
m_parser.flush();
|
|
|
|
if (m_future) {
|
|
reportCanceled();
|
|
reportFinished();
|
|
}
|
|
}
|
|
|
|
void CMakeProcess::run(const BuildDirParameters ¶meters, const QStringList &arguments)
|
|
{
|
|
QTC_ASSERT(!m_process && !m_future, return);
|
|
|
|
CMakeTool *cmake = parameters.cmakeTool();
|
|
QTC_ASSERT(parameters.isValid() && cmake, return);
|
|
|
|
const Utils::FilePath workDirectory = parameters.workDirectory;
|
|
QTC_ASSERT(workDirectory.exists(), return);
|
|
|
|
const QString srcDir = parameters.sourceDirectory.toString();
|
|
|
|
const auto parser = new CMakeParser;
|
|
parser->setSourceDirectory(srcDir);
|
|
m_parser.addLineParser(parser);
|
|
|
|
// Always use the sourceDir: If we are triggered because the build directory is getting deleted
|
|
// then we are racing against CMakeCache.txt also getting deleted.
|
|
|
|
auto process = std::make_unique<Utils::QtcProcess>();
|
|
m_processWasCanceled = false;
|
|
|
|
m_cancelTimer.start();
|
|
|
|
process->setWorkingDirectory(workDirectory.toString());
|
|
process->setEnvironment(parameters.environment);
|
|
|
|
connect(process.get(), &QProcess::readyReadStandardOutput,
|
|
this, &CMakeProcess::processStandardOutput);
|
|
connect(process.get(), &QProcess::readyReadStandardError,
|
|
this, &CMakeProcess::processStandardError);
|
|
connect(process.get(), QOverload<int, QProcess::ExitStatus>::of(&QProcess::finished),
|
|
this, &CMakeProcess::handleProcessFinished);
|
|
|
|
QStringList args;
|
|
args += parameters.generatorArguments;
|
|
args += arguments;
|
|
args += srcDir;
|
|
Utils::CommandLine commandLine(cmake->cmakeExecutable(), args);
|
|
|
|
TaskHub::clearTasks(ProjectExplorer::Constants::TASK_CATEGORY_BUILDSYSTEM);
|
|
|
|
Core::MessageManager::write(tr("Running %1 in %2.")
|
|
.arg(commandLine.toUserOutput())
|
|
.arg(workDirectory.toUserOutput()));
|
|
|
|
auto future = std::make_unique<QFutureInterface<void>>();
|
|
future->setProgressRange(0, 1);
|
|
Core::ProgressManager::addTimedTask(*future.get(),
|
|
tr("Configuring \"%1\"").arg(parameters.projectName),
|
|
"CMake.Configure",
|
|
10);
|
|
|
|
process->setCommand(commandLine);
|
|
emit started();
|
|
m_elapsed.start();
|
|
process->start();
|
|
|
|
m_process = std::move(process);
|
|
m_future = std::move(future);
|
|
}
|
|
|
|
QProcess::ProcessState CMakeProcess::state() const
|
|
{
|
|
if (m_process)
|
|
return m_process->state();
|
|
return QProcess::NotRunning;
|
|
}
|
|
|
|
void CMakeProcess::reportCanceled()
|
|
{
|
|
QTC_ASSERT(m_future, return);
|
|
m_future->reportCanceled();
|
|
}
|
|
|
|
void CMakeProcess::reportFinished()
|
|
{
|
|
QTC_ASSERT(m_future, return);
|
|
m_future->reportFinished();
|
|
m_future.reset();
|
|
}
|
|
|
|
void CMakeProcess::setProgressValue(int p)
|
|
{
|
|
QTC_ASSERT(m_future, return);
|
|
m_future->setProgressValue(p);
|
|
}
|
|
|
|
void CMakeProcess::processStandardOutput()
|
|
{
|
|
QTC_ASSERT(m_process, return);
|
|
|
|
static QString rest;
|
|
rest = lineSplit(rest, m_process->readAllStandardOutput(),
|
|
[](const QString &s) { Core::MessageManager::write(s); });
|
|
|
|
}
|
|
|
|
void CMakeProcess::processStandardError()
|
|
{
|
|
QTC_ASSERT(m_process, return);
|
|
|
|
static QString rest;
|
|
rest = lineSplit(rest, m_process->readAllStandardError(), [this](const QString &s) {
|
|
m_parser.appendMessage(s, Utils::StdErrFormat);
|
|
Core::MessageManager::write(s);
|
|
});
|
|
}
|
|
|
|
void CMakeProcess::handleProcessFinished(int code, QProcess::ExitStatus status)
|
|
{
|
|
QTC_ASSERT(m_process && m_future, return);
|
|
|
|
m_cancelTimer.stop();
|
|
|
|
processStandardOutput();
|
|
processStandardError();
|
|
|
|
QString msg;
|
|
if (status != QProcess::NormalExit) {
|
|
if (m_processWasCanceled) {
|
|
msg = tr("CMake process was canceled by the user.");
|
|
} else {
|
|
msg = tr("CMake process crashed.");
|
|
}
|
|
} else if (code != 0) {
|
|
msg = tr("CMake process exited with exit code %1.").arg(code);
|
|
}
|
|
|
|
if (!msg.isEmpty()) {
|
|
Core::MessageManager::write(msg);
|
|
TaskHub::addTask(BuildSystemTask(Task::Error, msg));
|
|
m_future->reportCanceled();
|
|
} else {
|
|
m_future->setProgressValue(1);
|
|
}
|
|
|
|
m_future->reportFinished();
|
|
|
|
emit finished(code, status);
|
|
|
|
const QString elapsedTime = Utils::formatElapsedTime(m_elapsed.elapsed());
|
|
Core::MessageManager::write(elapsedTime);
|
|
}
|
|
|
|
void CMakeProcess::checkForCancelled()
|
|
{
|
|
if (!m_process || !m_future)
|
|
return;
|
|
|
|
if (m_future->isCanceled()) {
|
|
m_cancelTimer.stop();
|
|
m_processWasCanceled = true;
|
|
m_process->close();
|
|
}
|
|
}
|
|
|
|
} // namespace Internal
|
|
} // namespace CMakeProjectManager
|