feedc0de/sdbus-cpp
1
0
Fork 0
forked from Kistler-Group/sdbus-cpp
Code Pull Requests Activity

chore: remove obsolete TODO comments

Browse Source
This commit is contained in:
Stanislav Angelovič
2023-10-31 15:54:49 +01:00
parent b7b454ba38
commit 9da18aec25
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/sdbus-c++/Types.h
View File

@@ -56,7 +56,7 @@ namespace sdbus {
Variant(); Variant();
template <typename _ValueType> template <typename _ValueType>
/*explicit*/ Variant(const _ValueType& value) // TODO: Mark explicit in new major version so we don't break client code within v1 Variant(const _ValueType& value)
: Variant() : Variant()
{ {
msg_.openVariant(signature_of<_ValueType>::str()); msg_.openVariant(signature_of<_ValueType>::str());

2
src/Proxy.cpp
View File

@@ -143,7 +143,7 @@ std::future<MethodReply> Proxy::callMethod(const MethodCall& message, uint64_t t
async_reply_handler asyncReplyCallback = [promise = std::move(promise)](MethodReply& reply, const Error* error) noexcept async_reply_handler asyncReplyCallback = [promise = std::move(promise)](MethodReply& reply, const Error* error) noexcept
{ {
if (error == nullptr) if (error == nullptr)
promise->set_value(reply); // TODO: std::move? Can't move now because currently processed message. TODO: Refactor promise->set_value(reply);
else else
promise->set_exception(std::make_exception_ptr(*error)); promise->set_exception(std::make_exception_ptr(*error));
}; };