feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Fix for scan-build warning where async changes make it appear like the output buffer could be NULL (even though its not). Added NULL check on the AddRecordHeader function.

Browse Source
This commit is contained in:
David Garske
2016-04-01 10:55:01 -07:00
parent dd28d53cfb
commit 19f0769ec4
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/internal.c
View File

@ -3532,6 +3532,9 @@ static void AddRecordHeader(byte* output, word32 length, byte type, WOLFSSL* ssl
/* record layer header */
rl = (RecordLayerHeader*)output;
if (rl == NULL) {
return;
}
rl->type = type;
rl->pvMajor = ssl->version.major; /* type and version same in each */
rl->pvMinor = ssl->version.minor;
@ -3539,13 +3542,15 @@ static void AddRecordHeader(byte* output, word32 length, byte type, WOLFSSL* ssl
#ifdef WOLFSSL_ALTERNATIVE_DOWNGRADE
if (ssl->options.side == WOLFSSL_CLIENT_END
&& ssl->options.connectState == CONNECT_BEGIN
&& !ssl->options.resuming)
&& !ssl->options.resuming) {
rl->pvMinor = ssl->options.downgrade ? ssl->options.minDowngrade
: ssl->version.minor;
}
#endif
if (!ssl->options.dtls)
if (!ssl->options.dtls) {
c16toa((word16)length, rl->length);
}
else {
#ifdef WOLFSSL_DTLS
DtlsRecordLayerHeader* dtls;