feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Scan-Build Fixes

Browse Source 
1. Fix a potential dereference of NULL pointer.

To recreate:
    $ scan-build ./configure --enable-sp --enable-sp-asm --enable-sp-math
This commit is contained in:
John Safranek
2020-11-12 11:33:42 -08:00
parent b931b1bd4d
commit 1e348b991d
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
wolfcrypt/src/sp_int.c
View File

@ -2321,9 +2321,11 @@ int sp_prime_is_prime_ex(sp_int* a, int t, int* result, WC_RNG* rng)
if (a == NULL || result == NULL || rng == NULL)
err = MP_VAL;
if (sp_isone(a)) {
*result = MP_NO;
return MP_OKAY;
if (err == MP_OKAY) {
if (sp_isone(a)) {
*result = MP_NO;
return MP_OKAY;
}
}
if (err == MP_OKAY && a->used == 1) {
@ -2410,7 +2412,8 @@ int sp_prime_is_prime_ex(sp_int* a, int t, int* result, WC_RNG* rng)
(void)t;
#endif /* !WC_NO_RNG */
*result = ret;
if (result != NULL)
*result = ret;
return err;
}