More PR comment fixes

This commit is contained in:
Andras Fekete
2024-08-07 16:56:57 -04:00
parent a31d8c5ce7
commit 38d191c159
2 changed files with 11 additions and 7 deletions

View File

@ -7934,8 +7934,10 @@ int wc_dilithium_check_key(dilithium_key* key)
}
}
/* Dispose of allocated memory. */
XFREE(s1, key->heap, DYNAMIC_TYPE_DILITHIUM);
if (key != NULL) {
/* Dispose of allocated memory. */
XFREE(s1, key->heap, DYNAMIC_TYPE_DILITHIUM);
}
#else
/* Validate parameter. */
if (key == NULL) {

View File

@ -5081,11 +5081,13 @@ int wc_MakeRsaKey(RsaKey* key, int size, long e, WC_RNG* rng)
#if !defined(WOLFSSL_CRYPTOCELL) && !defined(WOLFSSL_SE050)
#ifdef WOLFSSL_SMALL_STACK
XFREE(p, key->heap, DYNAMIC_TYPE_RSA);
XFREE(q, key->heap, DYNAMIC_TYPE_RSA);
XFREE(tmp1, key->heap, DYNAMIC_TYPE_RSA);
XFREE(tmp2, key->heap, DYNAMIC_TYPE_RSA);
XFREE(tmp3, key->heap, DYNAMIC_TYPE_RSA);
if (key != NULL) {
XFREE(p, key->heap, DYNAMIC_TYPE_RSA);
XFREE(q, key->heap, DYNAMIC_TYPE_RSA);
XFREE(tmp1, key->heap, DYNAMIC_TYPE_RSA);
XFREE(tmp2, key->heap, DYNAMIC_TYPE_RSA);
XFREE(tmp3, key->heap, DYNAMIC_TYPE_RSA);
}
#elif defined(WOLFSSL_CHECK_MEM_ZERO)
mp_memzero_check(p);
mp_memzero_check(q);