feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Merge pull request #4635 from julek-wolfssl/PrintPubKeyEC-wrong-free

Browse Source 
Return early on failed `key` init
This commit is contained in:
Kaleb Himes
2021-12-07 13:28:53 -07:00
committed by GitHub
parent 96daf2bede 223f25149b
commit 8609d98122
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
wolfcrypt/src/evp.c
View File

@@ -8182,6 +8182,13 @@ static int PrintPubKeyEC(WOLFSSL_BIO* out, const byte* pkey, int pkeySz,
return WOLFSSL_FAILURE;
}
if (wc_ecc_init(&key) != 0) {
/* Return early so we don't have to remember if init succeeded
* or not. */
mp_free(&a);
return WOLFSSL_FAILURE;
}
if (indent < 0) {
indent = 0;
}
@@ -8189,8 +8196,6 @@ static int PrintPubKeyEC(WOLFSSL_BIO* out, const byte* pkey, int pkeySz,
indent = EVP_PKEY_PRINT_INDENT_MAX;
}
res = wc_ecc_init(&key) == 0;
if (res == WOLFSSL_SUCCESS) {
res = wc_EccPublicKeyDecode(pkey, &inOutIdx, &key, pkeySz) == 0;
}