feedc0de/wolfssl
1
0
Fork 0
forked from wolfSSL/wolfssl
Code Pull Requests Activity

Fix scan-build report of possible use of unitialized output[i].

Browse Source
This commit is contained in:
David Garske
2017-10-16 11:24:41 -07:00
parent 02ee22e73b
commit de34ec0f0c
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wolfcrypt/src/asn.c
View File

@@ -6391,7 +6391,7 @@ WOLFSSL_LOCAL int SetSerialNumber(const byte* sn, word32 snSz, byte* output)
int i = 0;
int snSzInt = (int)snSz;
if (sn == NULL || output == NULL)
if (sn == NULL || output == NULL || snSzInt < 0)
return BAD_FUNC_ARG;
/* remove leading zeros */
@@ -6405,8 +6405,10 @@ WOLFSSL_LOCAL int SetSerialNumber(const byte* sn, word32 snSz, byte* output)
i += SetLength(snSzInt, &output[i]);
XMEMCPY(&output[i], sn, snSzInt);
/* ensure positive (MSB not set) */
output[i] &= ~0x80;
if (snSzInt > 0) {
/* ensure positive (MSB not set) */
output[i] &= ~0x80;
}
/* compute final length */
i += snSzInt;