Enable the ruff rule (unnecessary-empty-iterable-within-deque-call) and simplify 7 initializations (#170684)

homeassistant/components/brands/__init__.py

@@ -41,7 +41,7 @@ CONFIG_SCHEMA = cv.empty_config_schema(DOMAIN)
 
 async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool:
     """Set up the Brands integration."""
-    access_tokens: deque[str] = deque([], 2)
+    access_tokens: deque[str] = deque(maxlen=2)
     access_tokens.append(hex(_RND.getrandbits(256))[2:])
     hass.data[DOMAIN] = access_tokens
 

homeassistant/components/camera/__init__.py

@@ -445,7 +445,7 @@ class Camera(Entity, cached_properties=CACHED_PROPERTIES_WITH_ATTR_):
         self.stream: Stream | None = None
         self.stream_options: dict[str, str | bool | float] = {}
         self.content_type: str = DEFAULT_CONTENT_TYPE
-        self.access_tokens: collections.deque = collections.deque([], 2)
+        self.access_tokens: collections.deque = collections.deque(maxlen=2)
         self._warned_old_signature = False
         self.async_update_token()
         self._create_stream_lock: asyncio.Lock | None = None

homeassistant/components/image/__init__.py

@@ -207,7 +207,7 @@ class ImageEntity(Entity, cached_properties=CACHED_PROPERTIES_WITH_ATTR_):
     def __init__(self, hass: HomeAssistant, verify_ssl: bool = False) -> None:
         """Initialize an image entity."""
         self._client = get_async_client(hass, verify_ssl=verify_ssl)
-        self.access_tokens: collections.deque = collections.deque([], 2)
+        self.access_tokens: collections.deque = collections.deque(maxlen=2)
         self.async_update_token()
 
     @cached_property

homeassistant/components/mqtt/debug_info.py

@@ -42,7 +42,7 @@ def log_message(
     )
     if topic not in entity_info["transmitted"]:
         entity_info["transmitted"][topic] = {
-            "messages": deque([], STORED_MESSAGES),
+            "messages": deque(maxlen=STORED_MESSAGES),
         }
     msg = TimestampedPublishMessage(
         topic, payload, qos, retain, timestamp=time.monotonic()
@@ -61,7 +61,7 @@ def add_subscription(
         if subscription not in entity_info["subscriptions"]:
             entity_info["subscriptions"][subscription] = {
                 "count": 1,
-                "messages": deque([], STORED_MESSAGES),
+                "messages": deque(maxlen=STORED_MESSAGES),
             }
         else:
             entity_info["subscriptions"][subscription]["count"] += 1

homeassistant/components/mqtt/discovery.py

@@ -555,7 +555,7 @@ async def async_start(  # noqa: C901
                     MQTT_DISCOVERY_DONE.format(*discovery_hash),
                     discovery_done,
                 ),
-                "pending": deque([]),
+                "pending": deque(),
             }
 
         if component not in mqtt_data.platforms_loaded and payload:

homeassistant/components/push/camera.py

@@ -118,7 +118,7 @@ class PushCamera(Camera):
         self._filename = None
         self._expired_listener = None
         self._timeout = timeout
-        self.queue: deque[bytes] = deque([], buffer_size)
+        self.queue: deque[bytes] = deque(maxlen=buffer_size)
         self._current_image: bytes | None = None
         self._image_field = image_field
         self.webhook_id = webhook_id

pyproject.toml

@@ -740,6 +740,7 @@ select = [
   "RUF032", # Decimal() called with float literal argument
   "RUF033", # __post_init__ method with argument defaults
   "RUF034", # Useless if-else condition
+  "RUF037", # Unnecessary empty iterable within deque call
   "RUF046", # Unnecessary cast to int
   "RUF051", # Use dict.pop(key, None) instead of if-key-in-dict-del
   "RUF059", # unused-unpacked-variable