home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-08-11 00:25:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

value_fn and inline refactoring

Browse Source
This commit is contained in:
Mark Hannon
2025-05-13 11:33:04 +00:00
parent c01b9d0dd4
commit 6a4218c1ea
1 changed files with 33 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
homeassistant/components/zimi/sensor.py
View File

@@ -2,6 +2,8 @@
from __future__ import annotations
from collections.abc import Callable
from dataclasses import dataclass
import logging
from zcc import ControlPoint
@@ -15,40 +17,48 @@ from homeassistant.components.sensor import (
from homeassistant.const import PERCENTAGE, EntityCategory, UnitOfTemperature
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
from homeassistant.helpers.typing import StateType
from . import ZimiConfigEntry
from .entity import ZimiEntity
SENSOR_KEY_DOOR_TEMP = "door_temperature"
SENSOR_KEY_GARAGE_BATTERY = "garage_battery"
SENSOR_KEY_GARAGE_HUMDITY = "garage_humidty"
SENSOR_KEY_GARAGE_TEMP = "garage_temperature"
GARAGE_SENSOR_DESCRIPTIONS = (
SensorEntityDescription(
key=SENSOR_KEY_DOOR_TEMP,
@dataclass(frozen=True, kw_only=True)
class ZimiSensorEntityDescription(SensorEntityDescription):
"""Class describing Zimi sensor entities."""
value_fn: Callable[[ControlPointDevice], StateType]
GARAGE_SENSOR_DESCRIPTIONS: tuple[ZimiSensorEntityDescription, ...] = (
ZimiSensorEntityDescription(
key="door_temperature",
name="Outside temperature",
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
device_class=SensorDeviceClass.TEMPERATURE,
value_fn=lambda device: device.door_temp,
),
SensorEntityDescription(
key=SENSOR_KEY_GARAGE_BATTERY,
ZimiSensorEntityDescription(
key="garage_battery",
name="Battery Level",
native_unit_of_measurement=PERCENTAGE,
entity_category=EntityCategory.DIAGNOSTIC,
device_class=SensorDeviceClass.BATTERY,
value_fn=lambda device: device.battery_level,
),
SensorEntityDescription(
key=SENSOR_KEY_GARAGE_TEMP,
ZimiSensorEntityDescription(
key="garage_temperature",
name="Garage temperature",
native_unit_of_measurement=UnitOfTemperature.CELSIUS,
device_class=SensorDeviceClass.TEMPERATURE,
value_fn=lambda device: device.garage_temp,
),
SensorEntityDescription(
key=SENSOR_KEY_GARAGE_HUMDITY,
ZimiSensorEntityDescription(
key="garage_humidty",
name="Garage humidity",
native_unit_of_measurement=PERCENTAGE,
device_class=SensorDeviceClass.HUMIDITY,
value_fn=lambda device: device.garage_humidity,
),
)
@@ -64,16 +74,22 @@ async def async_setup_entry(
api = config_entry.runtime_data
async_add_entities(ZimiSensor(device, description, api) for device in api.sensors for description in GARAGE_SENSOR_DESCRIPTIONS)
async_add_entities(
ZimiSensor(device, description, api)
for device in api.sensors
for description in GARAGE_SENSOR_DESCRIPTIONS
)
class ZimiSensor(ZimiEntity, SensorEntity):
"""Representation of a Zimi sensor."""
entity_description: ZimiSensorEntityDescription
def __init__(
self,
device: ControlPointDevice,
description: SensorEntityDescription,
description: ZimiSensorEntityDescription,
api: ControlPoint,
) -> None:
"""Initialize an ZimiSensor with specified type."""
@@ -84,19 +100,7 @@ class ZimiSensor(ZimiEntity, SensorEntity):
self._attr_unique_id = device.identifier + "." + self.entity_description.key
@property
def native_value(self) -> float | None:
def native_value(self) -> str | int | float | None:
"""Return the state of the sensor."""
if self.entity_description.key == SENSOR_KEY_DOOR_TEMP:
return self._device.door_temp
if self.entity_description.key == SENSOR_KEY_GARAGE_BATTERY:
return self._device.battery_level
if self.entity_description.key == SENSOR_KEY_GARAGE_HUMDITY:
return self._device.garage_humidity
if self.entity_description.key == SENSOR_KEY_GARAGE_TEMP:
return self._device.garage_temp
return None
return self.entity_description.value_fn(self._device)