home-assistant/core
1
0
Fork 1
mirror of https://github.com/home-assistant/core.git synced 2025-08-06 22:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Added unit tests for hold/away mode

Browse Source
This commit is contained in:
Steven Roebert
2022-01-03 11:47:02 +01:00
parent 3de73ea8ef
commit f1c12919db
2 changed files with 86 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
homeassistant/components/mqtt/climate.py
View File

@@ -803,10 +803,14 @@ class MqttClimate(MqttEntity, ClimateEntity):
if preset_mode == PRESET_NONE:
hold_mode = None
if self._hold != hold_mode:
optimistic_update = await self._set_hold_mode(hold_mode) or optimistic_update
optimistic_update = (
await self._set_hold_mode(hold_mode) or optimistic_update
)
if self._away:
optimistic_update = await self._set_away_mode(False) or optimistic_update
optimistic_update = (
await self._set_away_mode(False) or optimistic_update
)
if optimistic_update:
self.async_write_ha_state()

80
tests/components/mqtt/test_climate.py
View File

@@ -19,6 +19,7 @@ from homeassistant.components.climate.const import (
HVAC_MODE_HEAT,
PRESET_ECO,
PRESET_NONE,
PRESET_AWAY,
SUPPORT_AUX_HEAT,
SUPPORT_FAN_MODE,
SUPPORT_PRESET_MODE,
@@ -566,6 +567,85 @@ async def test_set_hold(hass, mqtt_mock):
assert state.attributes.get("preset_mode") == "none"
async def test_set_preset_away(hass, mqtt_mock):
"""Test setting the hold mode and away mode."""
assert await async_setup_component(hass, CLIMATE_DOMAIN, DEFAULT_CONFIG)
await hass.async_block_till_done()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == PRESET_NONE
await common.async_set_preset_mode(hass, "hold-on", ENTITY_CLIMATE)
mqtt_mock.async_publish.assert_called_once_with("hold-topic", "hold-on", 0, False)
mqtt_mock.async_publish.reset_mock()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == "hold-on"
await common.async_set_preset_mode(hass, PRESET_AWAY, ENTITY_CLIMATE)
mqtt_mock.async_publish.assert_called_once_with("away-mode-topic", "ON", 0, False)
mqtt_mock.async_publish.assert_called_once_with("hold-topic", "off", 0, False)
mqtt_mock.async_publish.reset_mock()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == PRESET_NONE
await common.async_set_preset_mode(hass, "hold-on-again", ENTITY_CLIMATE)
mqtt_mock.async_publish.assert_called_once_with(
"hold-topic", "hold-on-again", 0, False
)
mqtt_mock.async_publish.assert_called_once_with("away-mode-topic", "OFF", 0, False)
mqtt_mock.async_publish.reset_mock()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == "hold-on-again"
async def test_set_preset_away_pessimistic(hass, mqtt_mock):
"""Test setting the hold mode and away mode in pessimistic mode."""
config = copy.deepcopy(DEFAULT_CONFIG)
config["climate"]["hold_state_topic"] = "hold-state"
config["climate"]["away_mode_state_topic"] = "away-state"
assert await async_setup_component(hass, CLIMATE_DOMAIN, config)
await hass.async_block_till_done()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == PRESET_NONE
await common.async_set_preset_mode(hass, "hold-on", ENTITY_CLIMATE)
mqtt_mock.async_publish.assert_called_once_with("hold-topic", "hold-on", 0, False)
mqtt_mock.async_publish.reset_mock()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == PRESET_NONE
async_fire_mqtt_message(hass, "hold-state", "hold-on")
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == "hold-on"
await common.async_set_preset_mode(hass, PRESET_AWAY, ENTITY_CLIMATE)
mqtt_mock.async_publish.assert_called_once_with("away-mode-topic", "ON", 0, False)
mqtt_mock.async_publish.assert_called_once_with("hold-topic", "off", 0, False)
mqtt_mock.async_publish.reset_mock()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == "hold-on"
async_fire_mqtt_message(hass, "away-state", "ON")
async_fire_mqtt_message(hass, "hold-state", "off")
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == PRESET_NONE
await common.async_set_preset_mode(hass, "hold-on-again", ENTITY_CLIMATE)
mqtt_mock.async_publish.assert_called_once_with(
"hold-topic", "hold-on-again", 0, False
)
mqtt_mock.async_publish.assert_called_once_with("away-mode-topic", "OFF", 0, False)
mqtt_mock.async_publish.reset_mock()
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == PRESET_NONE
async_fire_mqtt_message(hass, "hold-state", "hold-on-again")
async_fire_mqtt_message(hass, "away-state", "OFF")
state = hass.states.get(ENTITY_CLIMATE)
assert state.attributes.get("preset_mode") == "hold-on-again"
async def test_set_preset_mode_twice(hass, mqtt_mock):
"""Test setting of the same mode twice only publishes once."""
assert await async_setup_component(hass, CLIMATE_DOMAIN, DEFAULT_CONFIG)