Fix lint

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

.github/workflows/ci.yaml

@@ -853,49 +853,12 @@ jobs:
           key: >-
             ${{ runner.os }}-${{ runner.arch }}-${{ steps.python.outputs.python-version }}-${{
             needs.info.outputs.python_cache_key }}
-      - name: Restore pytest test counts cache
-        id: cache-pytest-counts
-        uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
-        with:
-          path: pytest_test_counts.json
-          # Primary key is a sentinel; restore-keys pick the most recent
-          # prefix match since the real (content-addressed) key isn't
-          # known until split_tests.py runs below.
-          key: >-
-            pytest-counts-${{ runner.os }}-${{ runner.arch }}-${{
-            steps.python.outputs.python-version }}-${{
-            needs.info.outputs.python_cache_key }}-restore-sentinel
-          restore-keys: |
-            pytest-counts-${{ runner.os }}-${{ runner.arch }}-${{ steps.python.outputs.python-version }}-${{ needs.info.outputs.python_cache_key }}-
       - name: Run split_tests.py
         env:
           TEST_GROUP_COUNT: ${{ needs.info.outputs.test_group_count }}
         run: |
           . venv/bin/activate
-          python -m script.split_tests \
-            --cache pytest_test_counts.json \
-            ${TEST_GROUP_COUNT} tests
-      - name: Hash pytest test counts cache
-        id: cache-pytest-counts-hash
-        run: |
-          echo "hash=$(sha256sum pytest_test_counts.json | cut -d' ' -f1)" \
-            >> "$GITHUB_OUTPUT"
-      - name: Save pytest test counts cache
-        # Content-addressed key: identical content reuses the same entry.
-        # Skip the save when the restore already matched that hash.
-        if: >-
-          !endsWith(
-            steps.cache-pytest-counts.outputs.cache-matched-key,
-            steps.cache-pytest-counts-hash.outputs.hash
-          )
-        uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
-        with:
-          path: pytest_test_counts.json
-          key: >-
-            pytest-counts-${{ runner.os }}-${{ runner.arch }}-${{
-            steps.python.outputs.python-version }}-${{
-            needs.info.outputs.python_cache_key }}-${{
-            steps.cache-pytest-counts-hash.outputs.hash }}
+          python -m script.split_tests ${TEST_GROUP_COUNT} tests
       - name: Upload pytest_buckets
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
         with:

CODEOWNERS

@@ -2054,8 +2054,8 @@ CLAUDE.md @home-assistant/core
 /tests/components/yamaha_musiccast/ @vigonotion @micha91
 /homeassistant/components/yandex_transport/ @rishatik92 @devbis
 /tests/components/yandex_transport/ @rishatik92 @devbis
-/homeassistant/components/yardian/ @h3l1o5
-/tests/components/yardian/ @h3l1o5
+/homeassistant/components/yardian/ @aeon-matrix
+/tests/components/yardian/ @aeon-matrix
 /homeassistant/components/yeelight/ @zewelor @shenxn @starkillerOG @alexyao2015
 /tests/components/yeelight/ @zewelor @shenxn @starkillerOG @alexyao2015
 /homeassistant/components/yeelightsunflower/ @lindsaymarkward

homeassistant/components/aws_s3/__init__.py

@@ -51,7 +51,6 @@ async def async_setup_entry(hass: HomeAssistant, entry: S3ConfigEntry) -> bool:
                 translation_key="invalid_bucket_name",
             ) from err
     except ValueError as err:
-        # pylint: disable-next=home-assistant-exception-translation-key-missing
         raise ConfigEntryError(
             translation_domain=DOMAIN,
             translation_key="invalid_endpoint_url",

homeassistant/components/aws_s3/strings.json

@@ -7,7 +7,7 @@
       "cannot_connect": "[%key:component::aws_s3::exceptions::cannot_connect::message%]",
       "invalid_bucket_name": "[%key:component::aws_s3::exceptions::invalid_bucket_name::message%]",
       "invalid_credentials": "[%key:component::aws_s3::exceptions::invalid_credentials::message%]",
-      "invalid_endpoint_url": "Invalid endpoint URL. Please make sure it's a valid AWS S3 endpoint URL."
+      "invalid_endpoint_url": "[%key:component::aws_s3::exceptions::invalid_endpoint_url::message%]"
     },
     "step": {
       "user": {
@@ -48,6 +48,9 @@
     },
     "invalid_credentials": {
       "message": "Bucket cannot be accessed using provided combination of access key ID and secret access key."
+    },
+    "invalid_endpoint_url": {
+      "message": "Invalid endpoint URL. Please make sure it's a valid AWS S3 endpoint URL."
     }
   }
 }

homeassistant/components/bluetooth/manifest.json

@@ -20,7 +20,7 @@
     "bluetooth-adapters==2.3.0",
     "bluetooth-auto-recovery==1.6.4",
     "bluetooth-data-tools==1.29.18",
-    "dbus-fast==5.0.14",
-    "habluetooth==6.7.4"
+    "dbus-fast==5.0.15",
+    "habluetooth==6.7.9"
   ]
 }

homeassistant/components/ihc/const.py

@@ -15,7 +15,6 @@ CONF_INFO = "info"
 CONF_INVERTING = "inverting"
 CONF_LIGHT = "light"
 CONF_NODE = "node"
-CONF_NOTE = "note"
 CONF_OFF_ID = "off_id"
 CONF_ON_ID = "on_id"
 CONF_POSITION = "position"

homeassistant/components/ihc/manual_setup.py

@@ -8,6 +8,7 @@ from homeassistant.components.binary_sensor import DEVICE_CLASSES_SCHEMA
 from homeassistant.const import (
     CONF_ID,
     CONF_NAME,
+    CONF_NOTE,
     CONF_PASSWORD,
     CONF_TYPE,
     CONF_UNIT_OF_MEASUREMENT,
@@ -25,7 +26,6 @@ from .const import (
     CONF_INFO,
     CONF_INVERTING,
     CONF_LIGHT,
-    CONF_NOTE,
     CONF_OFF_ID,
     CONF_ON_ID,
     CONF_POSITION,

homeassistant/components/qingping/manifest.json

@@ -21,5 +21,5 @@
   "documentation": "https://www.home-assistant.io/integrations/qingping",
   "integration_type": "device",
   "iot_class": "local_push",
-  "requirements": ["qingping-ble==1.1.4"]
+  "requirements": ["qingping-ble==1.1.5"]
 }

homeassistant/components/system_bridge/strings.json

@@ -217,9 +217,9 @@
         "home": "[%key:common::entity::button::home::name%]",
         "insert": "Insert",
         "left": "[%key:common::entity::button::left::name%]",
-        "lights_kbd_down": "Keyboasrd backlight brightness down",
+        "lights_kbd_down": "Keyboard backlight brightness down",
         "lights_kbd_toggle": "Toggle keyboard backlight",
-        "lights_kbd_up": "Keyboard backlight brighness up",
+        "lights_kbd_up": "Keyboard backlight brightness up",
         "lights_mon_down": "Display brightness down",
         "lights_mon_up": "Display brightness up",
         "numpad_0": "NumPad 0",

homeassistant/components/yardian/manifest.json

@@ -1,7 +1,7 @@
 {
   "domain": "yardian",
   "name": "Yardian",
-  "codeowners": ["@h3l1o5"],
+  "codeowners": ["@aeon-matrix"],
   "config_flow": true,
   "documentation": "https://www.home-assistant.io/integrations/yardian",
   "integration_type": "device",

homeassistant/const.py

@@ -91,7 +91,6 @@ CONF_COMMAND_ON: Final = "command_on"
 CONF_COMMAND_OPEN: Final = "command_open"
 CONF_COMMAND_STATE: Final = "command_state"
 CONF_COMMAND_STOP: Final = "command_stop"
-CONF_COMMENT: Final = "comment"
 CONF_CONDITION: Final = "condition"
 CONF_CONDITIONS: Final = "conditions"
 CONF_CONTINUE_ON_ERROR: Final = "continue_on_error"
@@ -171,6 +170,7 @@ CONF_MODEL_ID: Final = "model_id"
 CONF_MONITORED_CONDITIONS: Final = "monitored_conditions"
 CONF_MONITORED_VARIABLES: Final = "monitored_variables"
 CONF_NAME: Final = "name"
+CONF_NOTE: Final = "note"
 CONF_OFFSET: Final = "offset"
 CONF_OPTIMISTIC: Final = "optimistic"
 CONF_OPTIONS: Final = "options"

homeassistant/helpers/config_validation.py

@@ -38,7 +38,6 @@ from homeassistant.const import (
     CONF_ATTRIBUTE,
     CONF_BELOW,
     CONF_CHOOSE,
-    CONF_COMMENT,
     CONF_CONDITION,
     CONF_CONDITIONS,
     CONF_CONTINUE_ON_ERROR,
@@ -61,6 +60,7 @@ from homeassistant.const import (
     CONF_ID,
     CONF_IF,
     CONF_MATCH,
+    CONF_NOTE,
     CONF_PARALLEL,
     CONF_PLATFORM,
     CONF_REPEAT,
@@ -1459,7 +1459,7 @@ SCRIPT_SCHEMA = vol.All(ensure_list, [script_action])
 
 SCRIPT_ACTION_BASE_SCHEMA: VolDictType = {
     vol.Optional(CONF_ALIAS): string,
-    vol.Remove(CONF_COMMENT): str,  # Is only used in frontend
+    vol.Remove(CONF_NOTE): str,  # Is only used in frontend
     vol.Optional(CONF_CONTINUE_ON_ERROR): boolean,
     vol.Optional(CONF_ENABLED): vol.Any(boolean, template),
 }
@@ -1527,7 +1527,7 @@ NUMERIC_STATE_THRESHOLD_SCHEMA = vol.Any(
 
 CONDITION_BASE_SCHEMA: VolDictType = {
     vol.Optional(CONF_ALIAS): string,
-    vol.Remove(CONF_COMMENT): str,  # Is only used in frontend
+    vol.Remove(CONF_NOTE): str,  # Is only used in frontend
     vol.Optional(CONF_ENABLED): vol.Any(boolean, template),
 }
 
@@ -1862,7 +1862,7 @@ TRIGGER_BASE_SCHEMA = vol.Schema(
         vol.Optional(CONF_ID): str,
         vol.Optional(CONF_VARIABLES): SCRIPT_VARIABLES_SCHEMA,
         vol.Optional(CONF_ENABLED): vol.Any(boolean, template),
-        vol.Remove(CONF_COMMENT): str,  # Is only used in frontend
+        vol.Remove(CONF_NOTE): str,  # Is only used in frontend
     }
 )
 

homeassistant/package_constraints.txt

@@ -30,12 +30,12 @@ certifi>=2021.5.30
 ciso8601==2.3.3
 cronsim==2.7
 cryptography==48.0.0
-dbus-fast==5.0.14
+dbus-fast==5.0.15
 file-read-backwards==2.0.0
 fnv-hash-fast==2.0.3
 go2rtc-client==0.4.0
 ha-ffmpeg==3.2.2
-habluetooth==6.7.4
+habluetooth==6.7.9
 hass-nabucasa==2.2.0
 hassil==3.5.0
 home-assistant-bluetooth==2.0.0

requirements_all.txt

@@ -797,7 +797,7 @@ datadog==0.52.0
 datapoint==0.12.1
 
 # homeassistant.components.bluetooth
-dbus-fast==5.0.14
+dbus-fast==5.0.15
 
 # homeassistant.components.debugpy
 debugpy==1.8.17
@@ -1213,7 +1213,7 @@ ha-xthings-cloud==1.0.5
 habiticalib==0.4.7
 
 # homeassistant.components.bluetooth
-habluetooth==6.7.4
+habluetooth==6.7.9
 
 # homeassistant.components.hanna
 hanna-cloud==0.0.7
@@ -2839,7 +2839,7 @@ qbittorrent-api==2026.5.1
 qbusmqttapi==1.5.0
 
 # homeassistant.components.qingping
-qingping-ble==1.1.4
+qingping-ble==1.1.5
 
 # homeassistant.components.qnap
 qnapstats==0.4.0

script/split_tests.py

@@ -2,14 +2,9 @@
 """Helper script to split test into n buckets."""
 
 import argparse
-from collections.abc import Iterator
 from concurrent.futures import ProcessPoolExecutor
-from contextlib import suppress
-from dataclasses import dataclass, field, replace
-import hashlib
-import json
+from dataclasses import dataclass, field
 from math import ceil
-from operator import attrgetter, itemgetter
 import os
 from pathlib import Path
 import subprocess
@@ -20,21 +15,13 @@ from typing import Final
 # place to subdivide to keep each pytest invocation roughly equal in size.
 _FAN_OUT_DIRS: Final = frozenset({"components"})
 
-# Cache file format version; bump on any incompatible schema change so old
-# caches are ignored rather than misread.
-_CACHE_VERSION: Final = 3
-
-# Fall back from file-level to directory-level pytest collection when
-# misses make up more than this fraction of the tree; past that point
-# the per-file argv overhead pytest pays outweighs the cost of letting
-# it re-walk dirs and re-collect the hits.
-_DIR_LEVEL_MISS_RATIO: Final = 0.3
-
 
 class Bucket:
     """Class to hold bucket."""
 
-    def __init__(self) -> None:
+    def __init__(
+        self,
+    ):
         """Initialize bucket."""
         self.total_tests = 0
         self._paths: list[str] = []
@@ -60,56 +47,43 @@ class BucketHolder:
         self._buckets: list[Bucket] = [Bucket() for _ in range(bucket_count)]
 
     def split_tests(self, test_folder: TestFolder) -> None:
-        """Place atomic units via best-fit; oversized ones go to the smallest bucket."""
+        """Split tests into buckets."""
         digits = len(str(test_folder.total_tests))
-        by_load = attrgetter("total_tests")
-        units = sorted(self._atomic_units(test_folder), key=itemgetter(0), reverse=True)
-        for size, items in units:
-            for item in items:
-                tag = " (same bucket)" if item is not items[0] else ""
-                print(f"{item.total_tests:>{digits}} tests in {item.path}{tag}")
-            fits = [
-                b
-                for b in self._buckets
-                if b.total_tests + size <= self._tests_per_bucket
-            ]
-            bucket = max(fits, key=by_load) if fits else min(self._buckets, key=by_load)
-            for item in items:
-                bucket.add(item)
+        sorted_tests = sorted(
+            test_folder.get_all_flatten(), reverse=True, key=lambda x: x.total_tests
+        )
+        for tests in sorted_tests:
+            if tests.added_to_bucket:
+                # Already added to bucket
+                continue
 
+            print(f"{tests.total_tests:>{digits}} tests in {tests.path}")
+            smallest_bucket = min(self._buckets, key=lambda x: x.total_tests)
+            is_file = isinstance(tests, TestFile)
+            if (
+                smallest_bucket.total_tests + tests.total_tests < self._tests_per_bucket
+            ) or is_file:
+                smallest_bucket.add(tests)
+                # Ensure all files from the same folder are in the same bucket
+                # to ensure that syrupy correctly identifies unused snapshots
+                if is_file:
+                    for other_test in tests.parent.children.values():
+                        if other_test is tests or isinstance(other_test, TestFolder):
+                            continue
+                        print(
+                            f"{other_test.total_tests:>{digits}}"
+                            f" tests in {other_test.path}"
+                            " (same bucket)"
+                        )
+                        smallest_bucket.add(other_test)
+
+        # verify that all tests are added to a bucket
         if not test_folder.added_to_bucket:
             raise ValueError("Not all tests are added to a bucket")
 
-    def _atomic_units(
-        self, folder: TestFolder
-    ) -> Iterator[tuple[int, list[TestFolder | TestFile]]]:
-        """Yield ``(size, items)`` placement units.
-
-        A folder that fits is one unit; otherwise same-dir files form
-        a unit only when the folder has syrupy snapshots, else each
-        file stands alone.  Sub-folders recurse independently.
-        """
-        if folder.total_tests <= self._tests_per_bucket:
-            yield folder.total_tests, [folder]
-            return
-
-        sibling_files = [c for c in folder.children.values() if isinstance(c, TestFile)]
-        if sibling_files:
-            if _has_snapshots(folder.path):
-                yield (
-                    sum(f.total_tests for f in sibling_files),
-                    list(sibling_files),
-                )
-            else:
-                for file in sibling_files:
-                    yield file.total_tests, [file]
-        for child in folder.children.values():
-            if isinstance(child, TestFolder):
-                yield from self._atomic_units(child)
-
-    def create_output_file(self) -> None:
+    def create_ouput_file(self) -> None:
         """Create output file."""
-        with Path("pytest_buckets.txt").open("w", encoding="utf-8") as file:
+        with Path("pytest_buckets.txt").open("w") as file:
             for idx, bucket in enumerate(self._buckets):
                 print(f"Bucket {idx + 1} has {bucket.total_tests} tests")
                 file.write(bucket.get_paths_line())
@@ -196,15 +170,6 @@ class TestFolder:
         return result
 
 
-def _has_snapshots(folder_path: Path) -> bool:
-    """Return True when ``folder_path/snapshots`` holds ``.ambr`` files.
-
-    Same-dir tests must share a pytest run so syrupy can spot unused
-    snapshots; without snapshots that constraint doesn't apply.
-    """
-    return any((folder_path / "snapshots").glob("*.ambr"))
-
-
 def _collect_batch(paths: list[Path]) -> tuple[str, str, int]:
     """Run pytest --collect-only on a batch of paths."""
     result = subprocess.run(
@@ -251,343 +216,44 @@ def _enumerate_batch_paths(path: Path) -> list[Path]:
     return paths
 
 
-def _hash_file(path: Path) -> str:
-    """Return a short content hash for ``path``."""
-    return hashlib.sha256(path.read_bytes()).hexdigest()[:16]
+def collect_tests(path: Path) -> TestFolder:
+    """Collect all tests."""
+    batch_paths = _enumerate_batch_paths(path)
+    if not batch_paths:
+        print(f"No eligible test paths found under {path}")
+        sys.exit(1)
+    workers = min(len(batch_paths), os.cpu_count() or 1) or 1
+    # Round-robin chunking keeps batches roughly balanced when path
+    # ordering correlates with test size.
+    batches = [batch_paths[i::workers] for i in range(workers)]
 
-
-def _walk_test_tree(root: Path) -> tuple[list[Path], list[Path]]:
-    """Walk ``root`` once and return (test files, fixture files).
-
-    Fixtures are every non-``test_*.py`` ``.py``: conftests and helpers
-    like ``common.py`` that drive parametrize imports.  Uses ``os.walk``
-    (~2x faster than ``Path.rglob`` on this tree) and prunes ``.``/``_``
-    subdirs.
-    """
-    test_files: list[Path] = []
-    fixtures: list[Path] = []
-    for dirpath, dirnames, filenames in os.walk(root):
-        dirnames[:] = [d for d in dirnames if not d.startswith((".", "_"))]
-        base = Path(dirpath)
-        for name in filenames:
-            if not name.endswith(".py"):
-                continue
-            if name.startswith("test_"):
-                test_files.append(base / name)
-            else:
-                fixtures.append(base / name)
-    test_files.sort()
-    fixtures.sort()
-    return test_files, fixtures
-
-
-_PROJECT_ROOT_MARKERS: Final = frozenset(
-    {"pyproject.toml", "setup.py", "setup.cfg", "pytest.ini", "tox.ini"}
-)
-
-
-def _find_ancestor_fixtures(root: Path) -> list[Path]:
-    """Return non-``test_*.py`` Python files above ``root``, up to the project root.
-
-    Includes conftests and helper modules (eg ``common.py``); subtree
-    runs need both so shared ancestor helpers like
-    ``tests/components/common.py`` still invalidate descendants.
-    Stops at the first ancestor containing a project-root marker so we
-    don't read unrelated ``.py`` files outside the repo or trip on
-    dirs we can't list.
-    """
-    fixtures: list[Path] = []
-    current = root.resolve().parent
-    while True:
-        with suppress(OSError):
-            fixtures.extend(
-                entry
-                for entry in current.glob("*.py")
-                if not entry.name.startswith("test_")
-            )
-        if any((current / marker).exists() for marker in _PROJECT_ROOT_MARKERS):
-            break
-        if current == current.parent:
-            break
-        current = current.parent
-    return fixtures
-
-
-def _build_fixtures_by_dir(
-    root: Path, descendants: list[Path]
-) -> dict[Path, list[Path]]:
-    """Bucket descendants plus ancestor fixtures by resolved parent dir."""
-    by_dir: dict[Path, list[Path]] = {}
-    for fixture in (*_find_ancestor_fixtures(root), *descendants):
-        by_dir.setdefault(fixture.parent.resolve(), []).append(fixture)
-    return by_dir
-
-
-def _file_fixture_hash(
-    test_file: Path,
-    root: Path,
-    fixtures_by_dir: dict[Path, list[Path]],
-    blob_cache: dict[Path, bytes] | None = None,
-    dir_cache: dict[Path, str] | None = None,
-) -> str:
-    """Hash every ``.py`` fixture on the test file's ancestor path.
-
-    Catches conftests and helper modules (``common.py`` etc.) at any
-    level so parametrize imports from shared helpers invalidate
-    descendants, while sibling subtrees stay warm.  Pass shared
-    ``blob_cache``/``dir_cache`` dicts to memoize across many files.
-    """
-    test_dir = test_file.parent.resolve()
-    if dir_cache is not None and (cached := dir_cache.get(test_dir)) is not None:
-        return cached
-    relevant: list[Path] = []
-    current = test_dir
-    while True:
-        relevant.extend(fixtures_by_dir.get(current, ()))
-        parent = current.parent
-        if parent == current:
-            break
-        current = parent
-    relevant.sort()
-    digest = hashlib.sha256()
-    for fixture in relevant:
-        blob = blob_cache.get(fixture) if blob_cache is not None else None
-        if blob is None:
-            # relpath keeps the hash machine-stable across ancestor paths.
-            blob = (
-                os.path.relpath(fixture, root).encode()
-                + b"\0"
-                + fixture.read_bytes()
-                + b"\0"
-            )
-            if blob_cache is not None:
-                blob_cache[fixture] = blob
-        digest.update(blob)
-    result = digest.hexdigest()
-    if dir_cache is not None:
-        dir_cache[test_dir] = result
-    return result
-
-
-@dataclass
-class _CacheEntry:
-    """Cached test count plus its scope hash for a single file."""
-
-    hash: str
-    fixture_hash: str
-    count: int
-
-
-@dataclass
-class _Cache:
-    """Mapping of test file path → cached entry."""
-
-    entries: dict[str, _CacheEntry]
-
-    @classmethod
-    def load(cls, path: Path) -> _Cache:
-        """Load cache; any drift (missing, bad, version, malformed) returns empty."""
-        try:
-            raw = json.loads(path.read_bytes())
-        except OSError, ValueError:
-            raw = None
-        if not (
-            isinstance(raw, dict)
-            and raw.get("version") == _CACHE_VERSION
-            and isinstance(raw.get("files"), dict)
-        ):
-            return cls(entries={})
-        entries: dict[str, _CacheEntry] = {}
-        for key, value in raw["files"].items():
-            if not isinstance(value, dict):
-                continue
-            hash_value = value.get("hash")
-            fixture_hash = value.get("fixture_hash")
-            count = value.get("count")
-            # bool is an int subclass; reject true/false and negatives so
-            # corrupted JSON can't feed bucket sizing a bogus weight.
-            if (
-                not isinstance(hash_value, str)
-                or not isinstance(fixture_hash, str)
-                or not isinstance(count, int)
-                or isinstance(count, bool)
-                or count < 0
-            ):
-                continue
-            entries[key] = _CacheEntry(
-                hash=hash_value, fixture_hash=fixture_hash, count=count
-            )
-        return cls(entries=entries)
-
-    def save(self, path: Path) -> None:
-        """Write the cache to ``path``, creating parent dirs as needed."""
-        path.parent.mkdir(parents=True, exist_ok=True)
-        path.write_text(
-            json.dumps(
-                {
-                    "version": _CACHE_VERSION,
-                    "files": {
-                        key: {
-                            "hash": entry.hash,
-                            "fixture_hash": entry.fixture_hash,
-                            "count": entry.count,
-                        }
-                        for key, entry in sorted(self.entries.items())
-                    },
-                },
-                indent=2,
-                ensure_ascii=False,
-            )
-            + "\n",
-            encoding="utf-8",
-        )
-
-
-def _resolve_entries(
-    test_files: list[Path],
-    cache: _Cache,
-    root: Path,
-    fixtures_by_dir: dict[Path, list[Path]],
-) -> tuple[dict[Path, _CacheEntry], list[Path]]:
-    """Build an entry for every file; return ``(entries, misses)``.
-
-    Hits reuse the stored entry; misses get fresh hashes with a
-    count=0 placeholder for the caller to fill in after pytest runs.
-    Shared caches memoize fixture blobs and per-dir hashes so each
-    fixture file is read once and each unique dir hashed once.
-    """
-    blob_cache: dict[Path, bytes] = {}
-    dir_cache: dict[Path, str] = {}
-    entries: dict[Path, _CacheEntry] = {}
-    misses: list[Path] = []
-    for file in test_files:
-        file_hash = _hash_file(file)
-        fixture_hash = _file_fixture_hash(
-            file, root, fixtures_by_dir, blob_cache, dir_cache
-        )
-        cached = cache.entries.get(str(file.relative_to(root)))
-        if (
-            cached is not None
-            and cached.hash == file_hash
-            and cached.fixture_hash == fixture_hash
-        ):
-            entries[file] = cached
-        else:
-            entries[file] = _CacheEntry(
-                hash=file_hash, fixture_hash=fixture_hash, count=0
-            )
-            misses.append(file)
-    return entries, misses
-
-
-def _run_collect_batches(paths: list[Path]) -> list[tuple[str, str, int]]:
-    """Run pytest --collect-only across ``paths`` using a process pool."""
-    workers = min(len(paths), os.cpu_count() or 1) or 1
-    batches = [paths[i::workers] for i in range(workers)]
     if workers == 1:
-        return [_collect_batch(batches[0])]
-    with ProcessPoolExecutor(max_workers=workers) as executor:
-        return list(executor.map(_collect_batch, batches))
+        results = [_collect_batch(batches[0])]
+    else:
+        with ProcessPoolExecutor(max_workers=workers) as executor:
+            results = list(executor.map(_collect_batch, batches))
 
-
-def _parse_collect_output(stdout: str) -> dict[Path, int]:
-    """Parse ``pytest --collect-only -qq`` output into ``{path: count}``."""
-    counts: dict[Path, int] = {}
-    for line in stdout.splitlines():
-        if not line.strip():
-            continue
-        file_path, _, total_tests = line.partition(": ")
-        if not file_path or not total_tests:
-            raise ValueError(f"Unexpected line: {line}")
-        counts[Path(file_path)] = int(total_tests)
-    return counts
-
-
-def _run_pytest_collect(paths: list[Path]) -> dict[Path, int]:
-    """Run pytest --collect-only across ``paths`` and parse the output."""
-    counts: dict[Path, int] = {}
-    for stdout, stderr, returncode in _run_collect_batches(paths):
+    folder = TestFolder(path)
+    for stdout, stderr, returncode in results:
         if returncode != 0:
             print("Failed to collect tests:")
             print(stderr)
             print(stdout)
             sys.exit(1)
-        # Surface stderr from successful runs too; pytest puts deprecation
-        # and import warnings here that would otherwise vanish.
-        if stderr.strip():
-            sys.stderr.write(stderr)
-        try:
-            counts.update(_parse_collect_output(stdout))
-        except ValueError as err:
-            print(err)
-            sys.exit(1)
-    return counts
+        for line in stdout.splitlines():
+            if not line.strip():
+                continue
+            file_path, _, total_tests = line.partition(": ")
+            if not file_path or not total_tests:
+                print(f"Unexpected line: {line}")
+                sys.exit(1)
 
+            file = TestFile(int(total_tests), Path(file_path))
+            folder.add_test_file(file)
 
-def _build_folder(root: Path, counts: dict[Path, int]) -> TestFolder:
-    """Build a ``TestFolder`` from ``{path: count}``; zero-count files are skipped."""
-    folder = TestFolder(root)
-    for file_path, count in counts.items():
-        if count:
-            folder.add_test_file(TestFile(count, file_path))
     return folder
 
 
-def _exit_if_empty(paths: list[Path], root: Path) -> None:
-    """Exit with a clear message when no eligible test paths were found."""
-    if not paths:
-        print(f"No eligible test paths found under {root}")
-        sys.exit(1)
-
-
-def _collect_tests_uncached(path: Path) -> TestFolder:
-    """Hand pytest the top-level dirs; the pre-cache path when ``--cache`` is unset."""
-    batch_paths = _enumerate_batch_paths(path)
-    _exit_if_empty(batch_paths, path)
-    return _build_folder(path, _run_pytest_collect(batch_paths))
-
-
-def _collect_tests_cached(path: Path, cache_path: Path) -> TestFolder:
-    """Collect tests using an on-disk cache for incremental updates."""
-    all_test_files, fixtures = _walk_test_tree(path)
-    _exit_if_empty(all_test_files, path)
-
-    fixtures_by_dir = _build_fixtures_by_dir(path, fixtures)
-    cache = _Cache.load(cache_path)
-    entries, misses = _resolve_entries(all_test_files, cache, path, fixtures_by_dir)
-    hits = len(all_test_files) - len(misses)
-    print(f"Cache: {hits} hits / {len(misses)} misses / {len(all_test_files)} total")
-
-    if misses:
-        # Past _DIR_LEVEL_MISS_RATIO the per-file argv overhead beats
-        # re-walking the dirs, so fall back to dir-level collection.
-        if not hits or len(misses) > len(all_test_files) * _DIR_LEVEL_MISS_RATIO:
-            collect_paths = _enumerate_batch_paths(path)
-        else:
-            collect_paths = misses
-        new_counts = _run_pytest_collect(collect_paths)
-        # Files pytest returned no count for stay at 0; cached so they
-        # aren't re-collected next run.
-        for file in misses:
-            entries[file] = replace(entries[file], count=new_counts.get(file, 0))
-
-    _Cache(entries={str(f.relative_to(path)): e for f, e in entries.items()}).save(
-        cache_path
-    )
-    return _build_folder(path, {f: e.count for f, e in entries.items()})
-
-
-def collect_tests(path: Path, cache_path: Path | None = None) -> TestFolder:
-    """Collect all tests, using an on-disk cache when ``cache_path`` is set."""
-    if cache_path is None:
-        return _collect_tests_uncached(path)
-    if path.is_file():
-        # No fixture tree to scope against; bypass cache to avoid stale hits.
-        print(f"--cache ignored: {path} is a single file")
-        return _collect_tests_uncached(path)
-    return _collect_tests_cached(path, cache_path)
-
-
 def main() -> None:
     """Execute script."""
     parser = argparse.ArgumentParser(description="Split tests into n buckets.")
@@ -610,17 +276,11 @@ def main() -> None:
         help="Path to the test files to split into buckets",
         type=Path,
     )
-    parser.add_argument(
-        "--cache",
-        help="Path to a JSON file used to cache per-file test counts",
-        type=Path,
-        default=None,
-    )
 
     arguments = parser.parse_args()
 
     print("Collecting tests...")
-    tests = collect_tests(arguments.path, arguments.cache)
+    tests = collect_tests(arguments.path)
     tests_per_bucket = ceil(tests.total_tests / arguments.bucket_count)
 
     bucket_holder = BucketHolder(tests_per_bucket, arguments.bucket_count)
@@ -630,7 +290,7 @@ def main() -> None:
     print(f"Total tests: {tests.total_tests}")
     print(f"Estimated tests per bucket: {tests_per_bucket}")
 
-    bucket_holder.create_output_file()
+    bucket_holder.create_ouput_file()
 
 
 if __name__ == "__main__":

tests/components/bluetooth/test_init.py

@@ -2,6 +2,7 @@
 
 import asyncio
 from datetime import timedelta
+import sys
 import time
 from typing import Any
 from unittest.mock import AsyncMock, MagicMock, Mock, patch
@@ -99,6 +100,7 @@ async def test_setup_and_stop(
     assert len(mock_bleak_scanner_start.mock_calls) == 1
 
 
+@pytest.mark.skipif(sys.platform != "linux", reason="Requires Linux BlueZ scanner")
 @pytest.mark.parametrize(
     "options",
     [{CONF_MODE: "passive"}, {CONF_PASSIVE: True}],
@@ -161,6 +163,7 @@ async def test_setup_and_stop_passive(
     }
 
 
+@pytest.mark.skipif(sys.platform != "linux", reason="Requires Linux BlueZ scanner")
 async def test_setup_and_stop_old_bluez(
     hass: HomeAssistant,
     mock_bleak_scanner_start: MagicMock,

tests/helpers/test_config_validation.py

@@ -2034,7 +2034,7 @@ def test_stop_action_schema_error_false_with_response() -> None:
     assert config["response_variable"] == "result"
 
 
-_COMMENT_SCHEMA_PARAMS = [
+_NOTE_SCHEMA_PARAMS = [
     pytest.param(
         cv.TRIGGER_BASE_SCHEMA,
         {"platform": "event"},
@@ -2053,20 +2053,20 @@ _COMMENT_SCHEMA_PARAMS = [
 ]
 
 
-@pytest.mark.parametrize(("validator", "base_config"), _COMMENT_SCHEMA_PARAMS)
+@pytest.mark.parametrize(("validator", "base_config"), _NOTE_SCHEMA_PARAMS)
 @pytest.mark.usefixtures("hass")
-def test_base_schemas_accept_comment(
+def test_base_schemas_accept_note(
     validator: Callable[[dict[str, Any]], dict[str, Any]],
     base_config: dict[str, Any],
 ) -> None:
-    """Test that the comment field is accepted and stripped from the output."""
-    validated = validator({**base_config, "comment": "Single line"})
-    assert "comment" not in validated
+    """Test that the note field is accepted and stripped from the output."""
+    validated = validator({**base_config, "note": "Single line"})
+    assert "note" not in validated
 
 
-@pytest.mark.parametrize(("validator", "base_config"), _COMMENT_SCHEMA_PARAMS)
+@pytest.mark.parametrize(("validator", "base_config"), _NOTE_SCHEMA_PARAMS)
 @pytest.mark.parametrize(
-    "invalid_comment",
+    "invalid_note",
     [
         pytest.param(None, id="none"),
         pytest.param(42, id="int"),
@@ -2076,11 +2076,11 @@ def test_base_schemas_accept_comment(
     ],
 )
 @pytest.mark.usefixtures("hass")
-def test_base_schemas_reject_invalid_comment(
+def test_base_schemas_reject_invalid_note(
     validator: Callable[[dict[str, Any]], dict[str, Any]],
     base_config: dict[str, Any],
-    invalid_comment: Any,
+    invalid_note: Any,
 ) -> None:
-    """Test that script, condition, trigger base schemas reject non-string comments."""
+    """Test that script, condition, trigger base schemas reject non-string notes."""
     with pytest.raises(vol.Invalid):
-        validator({**base_config, "comment": invalid_comment})
+        validator({**base_config, "note": invalid_note})

tests/script/test_split_tests.py

@@ -1,678 +0,0 @@
-"""Tests for the split_tests cache logic."""
-
-from collections.abc import Callable
-import json
-from pathlib import Path
-from unittest.mock import patch
-
-import pytest
-
-from script import split_tests
-
-
-@pytest.fixture
-def tree(tmp_path: Path) -> Path:
-    """Build a tree: root conftest, two integrations, a ``common.py`` helper."""
-    # Bound the ancestor-fixture walk so it doesn't escape tmp_path.
-    (tmp_path / "pyproject.toml").write_text("")
-    (tmp_path / "conftest.py").write_text("# tests/conftest.py\n")
-    (tmp_path / "common.py").write_text("# helper module\n")
-
-    alpha_dir = tmp_path / "components" / "alpha"
-    alpha_dir.mkdir(parents=True)
-    (alpha_dir / "conftest.py").write_text("# alpha conftest\n")
-    (alpha_dir / "test_one.py").write_text("def test_a():\n    pass\n")
-    (alpha_dir / "test_two.py").write_text("def test_b():\n    pass\n")
-
-    beta_dir = tmp_path / "components" / "beta"
-    beta_dir.mkdir()
-    (beta_dir / "test_x.py").write_text("def test_x():\n    pass\n")
-
-    return tmp_path
-
-
-def test_iter_eligible_children_filters_helpers(tree: Path) -> None:
-    """Helper files like conftest.py and common.py are not collection targets."""
-    children = split_tests._iter_eligible_children(tree)
-    names = {p.name for p in children}
-    assert "common.py" not in names
-    assert "conftest.py" not in names
-    # components/ is a dir, gets included.
-    assert "components" in names
-
-
-def test_enumerate_batch_paths_fans_out_components(tree: Path) -> None:
-    """tests/components fans out one level deeper into per-integration paths."""
-    paths = split_tests._enumerate_batch_paths(tree)
-    rel = {p.relative_to(tree).as_posix() for p in paths}
-    assert rel == {"components/beta", "components/alpha"}
-
-
-def test_enumerate_batch_paths_for_single_file(tmp_path: Path) -> None:
-    """A test file passed directly is returned as-is."""
-    file = tmp_path / "test_solo.py"
-    file.write_text("def test_x(): pass\n")
-    assert split_tests._enumerate_batch_paths(file) == [file]
-
-
-def _fixture_hash_for(tree: Path, file: Path) -> str:
-    """Compute the fixture scope hash for ``file`` rooted at ``tree``."""
-    _, fixtures = split_tests._walk_test_tree(tree)
-    fixtures_by_dir = split_tests._build_fixtures_by_dir(tree, fixtures)
-    return split_tests._file_fixture_hash(file, tree, fixtures_by_dir)
-
-
-def _prime_cache(
-    cache_path: Path,
-    tree: Path,
-    hits: dict[Path, int] | None = None,
-    extra_entries: dict[str, split_tests._CacheEntry] | None = None,
-) -> None:
-    """Save a cache for ``tree`` keyed on real file and fixture hashes.
-
-    ``hits`` maps file → cached count (hashed for real, so the next
-    run resolves as a hit).  ``extra_entries`` injects raw entries
-    whose path may not exist on disk (eg ghost files).
-    """
-    entries: dict[str, split_tests._CacheEntry] = {
-        str(file.relative_to(tree)): split_tests._CacheEntry(
-            hash=split_tests._hash_file(file),
-            fixture_hash=_fixture_hash_for(tree, file),
-            count=count,
-        )
-        for file, count in (hits or {}).items()
-    }
-    if extra_entries:
-        entries.update(extra_entries)
-    split_tests._Cache(entries=entries).save(cache_path)
-
-
-def _echo_one_test_each(
-    skip: set[Path] | None = None,
-) -> Callable[[list[Path]], list[tuple[str, str, int]]]:
-    """Fake ``_run_collect_batches``: 1 test per path; ``skip`` paths drop out."""
-    skip = skip or set()
-
-    def fake(paths: list[Path]) -> list[tuple[str, str, int]]:
-        emitted = [p for p in paths if p not in skip]
-        return [("\n".join(f"{p}: 1" for p in emitted) + "\n", "", 0)]
-
-    return fake
-
-
-def test_file_fixture_hash_changes_when_ancestor_conftest_changes(tree: Path) -> None:
-    """A conftest edit in the file's ancestor chain busts that file's hash."""
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    before = _fixture_hash_for(tree, alpha_one)
-    # Same-dir conftest is an ancestor of alpha_one.
-    (tree / "components" / "alpha" / "conftest.py").write_text("# changed\n")
-    after = _fixture_hash_for(tree, alpha_one)
-    assert before != after
-
-
-def test_file_fixture_hash_changes_when_same_dir_helper_changes(tree: Path) -> None:
-    """A non-conftest helper in the same dir busts the file's hash."""
-    alpha_dir = tree / "components" / "alpha"
-    (alpha_dir / "common.py").write_text("# helper v1\n")
-    alpha_one = alpha_dir / "test_one.py"
-    before = _fixture_hash_for(tree, alpha_one)
-    (alpha_dir / "common.py").write_text("# helper v2\n")
-    after = _fixture_hash_for(tree, alpha_one)
-    assert before != after
-
-
-def test_file_fixture_hash_isolated_from_sibling_dir(tree: Path) -> None:
-    """A helper change in a sibling subtree leaves this file's hash alone."""
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    before = _fixture_hash_for(tree, alpha_one)
-    # beta is a sibling of alpha (not an ancestor), so its helper edit
-    # must not affect alpha_one's fixture hash.
-    (tree / "components" / "beta" / "common.py").write_text("# beta v2\n")
-    after = _fixture_hash_for(tree, alpha_one)
-    assert before == after
-
-
-def test_file_fixture_hash_changes_when_ancestor_helper_changes(tree: Path) -> None:
-    """A helper edit anywhere on the ancestor path busts the file's hash.
-
-    Test files often import VALUES for ``@pytest.mark.parametrize`` from
-    shared helpers like ``tests/components/common.py``; any ancestor
-    ``.py`` change has to invalidate descendants so cached counts don't
-    drift after edits to those sources.
-    """
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    # Seed a shared helper one level up from alpha.
-    components_common = tree / "components" / "common.py"
-    components_common.write_text("# helper v1\n")
-    before = _fixture_hash_for(tree, alpha_one)
-    components_common.write_text("# helper v2\n")
-    after = _fixture_hash_for(tree, alpha_one)
-    assert before != after
-
-
-def test_file_fixture_hash_stable_for_test_changes(tree: Path) -> None:
-    """Test-file edits do not invalidate the file's fixture hash."""
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    before = _fixture_hash_for(tree, alpha_one)
-    alpha_one.write_text("def test_a():\n    pass\n\ndef test_c():\n    pass\n")
-    after = _fixture_hash_for(tree, alpha_one)
-    assert before == after
-
-
-def test_find_ancestor_fixtures_stops_at_project_root(tmp_path: Path) -> None:
-    """A project-root marker bounds the ancestor walk."""
-    project = tmp_path / "project"
-    project.mkdir()
-    (project / "pyproject.toml").write_text("")
-    (project / "common.py").write_text("# included\n")
-    nested = project / "tests" / "x"
-    nested.mkdir(parents=True)
-    # Above the project root: must NOT be picked up.
-    (tmp_path / "outside.py").write_text("# excluded\n")
-
-    found = {p.name for p in split_tests._find_ancestor_fixtures(nested)}
-    assert "common.py" in found
-    assert "outside.py" not in found
-
-
-def test_find_ancestor_fixtures_walks_through_gaps(tmp_path: Path) -> None:
-    """Ancestor conftests + helpers are collected across intermediate gaps."""
-    (tmp_path / "pyproject.toml").write_text("")  # bound the walk
-    nested = tmp_path / "a" / "b" / "c"
-    nested.mkdir(parents=True)
-    # ``a/b`` has no fixtures, but ``a`` has both a conftest and a helper.
-    (tmp_path / "a" / "conftest.py").write_text("# a\n")
-    (tmp_path / "a" / "common.py").write_text("# a helper\n")
-    (tmp_path / "a" / "b" / "c" / "conftest.py").write_text("# c\n")
-
-    found = {
-        p.relative_to(tmp_path).as_posix()
-        for p in split_tests._find_ancestor_fixtures(nested)
-    }
-    # The walk starts at ``nested.parent`` (a/b); a/b/c/conftest.py is
-    # not an ancestor.  Both ``a/conftest.py`` and ``a/common.py`` must
-    # be found despite a/b having no fixtures of its own.
-    assert "a/conftest.py" in found
-    assert "a/common.py" in found
-    assert "a/b/c/conftest.py" not in found
-
-
-def test_file_fixture_hash_picks_up_ancestor_helper_above_root(
-    tmp_path: Path,
-) -> None:
-    """An ancestor non-conftest helper above root still busts descendant hashes.
-
-    A subtree run on ``components/`` must still invalidate when a shared
-    helper one level up (eg ``tests/components/common.py``) changes.
-    """
-    (tmp_path / "pyproject.toml").write_text("")  # bound the walk
-    (tmp_path / "common.py").write_text("# v1\n")
-    subtree = tmp_path / "components"
-    subtree.mkdir()
-    test_file = subtree / "test_x.py"
-    test_file.write_text("def test_x(): pass\n")
-
-    before = _fixture_hash_for(subtree, test_file)
-    (tmp_path / "common.py").write_text("# v2\n")
-    after = _fixture_hash_for(subtree, test_file)
-    assert before != after
-
-
-def test_file_fixture_hash_picks_up_ancestor_conftest_across_gap(
-    tmp_path: Path,
-) -> None:
-    """An ancestor conftest across a gap still busts the descendant's hash."""
-    (tmp_path / "pyproject.toml").write_text("")  # bound the walk
-    nested = tmp_path / "a" / "b"
-    nested.mkdir(parents=True)
-    (tmp_path / "a" / "conftest.py").write_text("# v1\n")
-    test_file = nested / "test_x.py"
-    test_file.write_text("def test_x(): pass\n")
-
-    before = _fixture_hash_for(nested, test_file)
-    (tmp_path / "a" / "conftest.py").write_text("# v2\n")
-    after = _fixture_hash_for(nested, test_file)
-    assert before != after
-
-
-def test_file_fixture_hash_includes_ancestor_above_root(tmp_path: Path) -> None:
-    """An ancestor conftest above root must still scope a subtree file."""
-    (tmp_path / "pyproject.toml").write_text("")  # bound the walk
-    (tmp_path / "conftest.py").write_text("# parent\n")
-    subtree = tmp_path / "components"
-    subtree.mkdir()
-    test_file = subtree / "test_x.py"
-    test_file.write_text("def test_x(): pass\n")
-
-    before = _fixture_hash_for(subtree, test_file)
-    (tmp_path / "conftest.py").write_text("# parent changed\n")
-    after = _fixture_hash_for(subtree, test_file)
-    assert before != after
-
-
-def test_walk_test_tree_separates_tests_from_fixtures(tree: Path) -> None:
-    """The walker returns test_*.py files and every other .py as fixtures."""
-    test_files, fixtures = split_tests._walk_test_tree(tree)
-    test_names = {p.name for p in test_files}
-    fixture_paths = {p.relative_to(tree).as_posix() for p in fixtures}
-    assert test_names == {"test_one.py", "test_two.py", "test_x.py"}
-    assert fixture_paths == {
-        "conftest.py",
-        "common.py",
-        "components/alpha/conftest.py",
-    }
-
-
-def test_walk_test_tree_skips_hidden_and_dunder_dirs(tmp_path: Path) -> None:
-    """Hidden/dunder directories are pruned from the walk."""
-    (tmp_path / "__pycache__").mkdir()
-    (tmp_path / "__pycache__" / "test_ghost.py").write_text("def test_g(): pass\n")
-    (tmp_path / ".hidden").mkdir()
-    (tmp_path / ".hidden" / "test_invisible.py").write_text("def test_h(): pass\n")
-    (tmp_path / "test_real.py").write_text("def test_r(): pass\n")
-
-    test_files, _ = split_tests._walk_test_tree(tmp_path)
-    assert {p.name for p in test_files} == {"test_real.py"}
-
-
-def test_collect_tests_skips_cache_for_single_file_root(tmp_path: Path) -> None:
-    """Single-file root bypasses caching.
-
-    Otherwise the invalidation hash would be constant and stale counts
-    could survive conftest edits.
-    """
-    cache_path = tmp_path / "cache.json"
-    file = tmp_path / "test_solo.py"
-    file.write_text("def test_x(): pass\n")
-
-    with (
-        patch.object(split_tests, "_collect_tests_uncached") as uncached,
-        patch.object(split_tests, "_collect_tests_cached") as cached,
-    ):
-        split_tests.collect_tests(file, cache_path)
-
-    uncached.assert_called_once_with(file)
-    cached.assert_not_called()
-    assert not cache_path.exists()
-
-
-def test_cache_roundtrip(tmp_path: Path) -> None:
-    """A cache survives save → load."""
-    cache_path = tmp_path / "cache.json"
-    cache = split_tests._Cache(
-        entries={
-            "tests/alpha/test_a.py": split_tests._CacheEntry(
-                hash="h1", fixture_hash="f1", count=5
-            )
-        },
-    )
-    cache.save(cache_path)
-    loaded = split_tests._Cache.load(cache_path)
-    assert loaded.entries == cache.entries
-
-
-def test_cache_load_missing_returns_empty(tmp_path: Path) -> None:
-    """A missing cache file degrades gracefully to an empty cache."""
-    cache = split_tests._Cache.load(tmp_path / "missing.json")
-    assert cache.entries == {}
-
-
-def test_cache_load_invalid_json_returns_empty(tmp_path: Path) -> None:
-    """Corrupt JSON is treated as a cache miss instead of crashing."""
-    path = tmp_path / "broken.json"
-    path.write_text("{not json")
-    cache = split_tests._Cache.load(path)
-    assert cache.entries == {}
-
-
-def test_cache_load_wrong_version_returns_empty(tmp_path: Path) -> None:
-    """An older cache schema is discarded rather than misread."""
-    path = tmp_path / "old.json"
-    path.write_text(json.dumps({"version": 0, "files": {}}))
-    cache = split_tests._Cache.load(path)
-    assert cache.entries == {}
-
-
-def test_cache_load_drops_malformed_entries(tmp_path: Path) -> None:
-    """Malformed per-file entries are skipped, valid ones are kept."""
-    path = tmp_path / "cache.json"
-    path.write_text(
-        json.dumps(
-            {
-                "version": split_tests._CACHE_VERSION,
-                "files": {
-                    "good.py": {"hash": "h1", "fixture_hash": "f1", "count": 3},
-                    "bad_count.py": {
-                        "hash": "h2",
-                        "fixture_hash": "f2",
-                        "count": "three",
-                    },
-                    "missing_hash.py": {"fixture_hash": "f3", "count": 4},
-                    "missing_fixture_hash.py": {"hash": "h4", "count": 4},
-                    "not_dict.py": 5,
-                    # bool is an int subclass; reject so True isn't read as 1.
-                    "bool_count.py": {
-                        "hash": "h5",
-                        "fixture_hash": "f5",
-                        "count": True,
-                    },
-                    "negative_count.py": {
-                        "hash": "h6",
-                        "fixture_hash": "f6",
-                        "count": -1,
-                    },
-                },
-            }
-        )
-    )
-    cache = split_tests._Cache.load(path)
-    assert set(cache.entries) == {"good.py"}
-
-
-def test_cache_save_creates_parent_dir(tmp_path: Path) -> None:
-    """Save mkdirs missing parent dirs so ``--cache foo/bar.json`` works."""
-    cache_path = tmp_path / "nested" / "subdir" / "cache.json"
-    split_tests._Cache(entries={}).save(cache_path)
-    assert cache_path.is_file()
-
-
-def _resolve(
-    test_files: list[Path], cache: split_tests._Cache, tree: Path
-) -> tuple[dict[Path, split_tests._CacheEntry], list[Path]]:
-    """Run resolve_entries with a freshly indexed fixtures_by_dir."""
-    _, fixtures = split_tests._walk_test_tree(tree)
-    return split_tests._resolve_entries(
-        test_files,
-        cache,
-        tree,
-        split_tests._build_fixtures_by_dir(tree, fixtures),
-    )
-
-
-def test_resolve_entries_hits_and_misses(tree: Path) -> None:
-    """Files with matching content + fixture hashes are hits."""
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    alpha_two = tree / "components" / "alpha" / "test_two.py"
-    beta_x = tree / "components" / "beta" / "test_x.py"
-
-    alpha_one_hash = split_tests._hash_file(alpha_one)
-    alpha_one_fixture = _fixture_hash_for(tree, alpha_one)
-    cache = split_tests._Cache(
-        entries={
-            str(alpha_one.relative_to(tree)): split_tests._CacheEntry(
-                hash=alpha_one_hash, fixture_hash=alpha_one_fixture, count=1
-            ),
-            str(alpha_two.relative_to(tree)): split_tests._CacheEntry(
-                hash="stale", fixture_hash=alpha_one_fixture, count=99
-            ),
-        },
-    )
-    entries, misses = _resolve([alpha_one, alpha_two, beta_x], cache, tree)
-    # Hit: cached entry passed through verbatim.
-    assert entries[alpha_one] == split_tests._CacheEntry(
-        hash=alpha_one_hash, fixture_hash=alpha_one_fixture, count=1
-    )
-    # Misses: fresh hashes plus a count=0 placeholder.
-    assert set(misses) == {alpha_two, beta_x}
-    assert entries[alpha_two].count == 0
-    assert entries[alpha_two].hash == split_tests._hash_file(alpha_two)
-    assert entries[beta_x].count == 0
-    assert entries[beta_x].hash == split_tests._hash_file(beta_x)
-
-
-def test_resolve_entries_misses_on_fixture_drift(tree: Path) -> None:
-    """A file with unchanged content but changed scope counts as a miss."""
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    cache = split_tests._Cache(
-        entries={
-            str(alpha_one.relative_to(tree)): split_tests._CacheEntry(
-                hash=split_tests._hash_file(alpha_one),
-                fixture_hash="stale-fixture-hash",
-                count=1,
-            ),
-        },
-    )
-    _, misses = _resolve([alpha_one], cache, tree)
-    assert misses == [alpha_one]
-
-
-def test_resolve_entries_isolates_unrelated_dirs(tree: Path) -> None:
-    """Editing a helper in one dir leaves files in other dirs as hits."""
-    alpha_dir = tree / "components" / "alpha"
-    beta_dir = tree / "components" / "beta"
-    # Helpers per dir, so a change in alpha doesn't bust beta.
-    (alpha_dir / "common.py").write_text("# alpha helper v1\n")
-    (beta_dir / "common.py").write_text("# beta helper v1\n")
-    alpha_one = alpha_dir / "test_one.py"
-    beta_x = beta_dir / "test_x.py"
-
-    # Snapshot cache entries with the v1 fixture state.
-    cache = split_tests._Cache(
-        entries={
-            str(alpha_one.relative_to(tree)): split_tests._CacheEntry(
-                hash=split_tests._hash_file(alpha_one),
-                fixture_hash=_fixture_hash_for(tree, alpha_one),
-                count=1,
-            ),
-            str(beta_x.relative_to(tree)): split_tests._CacheEntry(
-                hash=split_tests._hash_file(beta_x),
-                fixture_hash=_fixture_hash_for(tree, beta_x),
-                count=2,
-            ),
-        },
-    )
-
-    # Now bust beta's helper; alpha's scope is unchanged, beta's isn't.
-    (beta_dir / "common.py").write_text("# beta helper v2\n")
-    _, misses = _resolve([alpha_one, beta_x], cache, tree)
-    assert misses == [beta_x]
-
-
-def test_collect_tests_hashes_each_file_once(tree: Path) -> None:
-    """Hits reuse the stored hash, misses reuse the resolve-time hash.
-
-    Guards against regressing the double-read on cache-miss rebuilds:
-    each test file should pass through _hash_file at most once per run.
-    """
-    cache_path = tree / "cache.json"
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    # Prime with one hit so we exercise the file-level (not directory-level) miss path.
-    _prime_cache(cache_path, tree, hits={alpha_one: 1})
-
-    real_hash = split_tests._hash_file
-    counts: dict[Path, int] = {}
-
-    def counting_hash(path: Path) -> str:
-        counts[path] = counts.get(path, 0) + 1
-        return real_hash(path)
-
-    # Pin the threshold so the tiny tree stays on the file-level path.
-    with (
-        patch.object(split_tests, "_DIR_LEVEL_MISS_RATIO", 1.0),
-        patch.object(split_tests, "_hash_file", side_effect=counting_hash),
-        patch.object(
-            split_tests, "_run_collect_batches", side_effect=_echo_one_test_each()
-        ),
-    ):
-        split_tests.collect_tests(tree, cache_path)
-
-    assert all(n == 1 for n in counts.values()), counts
-
-
-def test_collect_tests_warm_cache_skips_pytest(tree: Path) -> None:
-    """A warm cache with no diffs should skip the pytest subprocess entirely."""
-    cache_path = tree / "cache.json"
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    alpha_two = tree / "components" / "alpha" / "test_two.py"
-    beta_x = tree / "components" / "beta" / "test_x.py"
-    _prime_cache(cache_path, tree, hits={alpha_one: 1, alpha_two: 2, beta_x: 3})
-
-    with patch.object(split_tests, "_run_collect_batches") as run_batches:
-        folder = split_tests.collect_tests(tree, cache_path)
-    run_batches.assert_not_called()
-    assert folder.total_tests == 6
-
-
-def test_collect_tests_cold_cache_collects_only_missing(tree: Path) -> None:
-    """A partial cache should only re-collect the files that changed."""
-    cache_path = tree / "cache.json"
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    alpha_two = tree / "components" / "alpha" / "test_two.py"
-    beta_x = tree / "components" / "beta" / "test_x.py"
-
-    _prime_cache(cache_path, tree, hits={alpha_one: 1})
-
-    with (
-        patch.object(split_tests, "_DIR_LEVEL_MISS_RATIO", 1.0),
-        patch.object(
-            split_tests, "_run_collect_batches", side_effect=_echo_one_test_each()
-        ) as run_batches,
-    ):
-        folder = split_tests.collect_tests(tree, cache_path)
-
-    assert run_batches.call_count == 1
-    requested = set(run_batches.call_args.args[0])
-    assert requested == {alpha_two, beta_x}
-    assert folder.total_tests == 3
-
-    # Cache should now contain entries for every test file.
-    saved = json.loads(cache_path.read_text())
-    assert set(saved["files"]) == {
-        str(alpha_one.relative_to(tree)),
-        str(alpha_two.relative_to(tree)),
-        str(beta_x.relative_to(tree)),
-    }
-
-
-def test_collect_tests_falls_back_to_dirs_when_misses_dominate(tree: Path) -> None:
-    """Heavy misses should switch back to dir-level invocation."""
-    cache_path = tree / "cache.json"
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    _prime_cache(cache_path, tree, hits={alpha_one: 1})
-    # 2 misses / 3 total = 67% miss, above the 30% default threshold; this
-    # also covers the new-directory PR case (mostly-new test files).
-
-    with patch.object(
-        split_tests, "_run_collect_batches", side_effect=_echo_one_test_each()
-    ) as run_batches:
-        split_tests.collect_tests(tree, cache_path)
-
-    # We expect the dir-level batch paths, not the individual miss files.
-    requested = set(run_batches.call_args.args[0])
-    assert requested == set(split_tests._enumerate_batch_paths(tree))
-
-
-def test_collect_tests_caches_files_with_no_collected_tests(tree: Path) -> None:
-    """Files pytest returns nothing for are cached as 0 so we stop re-collecting them.
-
-    Helper modules named test_*.py with no actual test functions look like
-    test files to the walker but pytest reports no tests for them.  We
-    want the cache to remember that and skip them on subsequent runs.
-    """
-    cache_path = tree / "cache.json"
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    alpha_two = tree / "components" / "alpha" / "test_two.py"
-    beta_x = tree / "components" / "beta" / "test_x.py"
-
-    # Prime the cache with one hit so collect_tests takes the file-level
-    # diff path; the cold-cache path hands pytest top-level directories
-    # rather than individual file paths.
-    _prime_cache(cache_path, tree, hits={alpha_one: 1})
-
-    with (
-        patch.object(split_tests, "_DIR_LEVEL_MISS_RATIO", 1.0),
-        patch.object(
-            split_tests,
-            "_run_collect_batches",
-            side_effect=_echo_one_test_each(skip={alpha_two}),
-        ),
-    ):
-        split_tests.collect_tests(tree, cache_path)
-
-    saved = json.loads(cache_path.read_text())
-    assert saved["files"][str(alpha_two.relative_to(tree))]["count"] == 0
-    assert saved["files"][str(alpha_one.relative_to(tree))]["count"] == 1
-    assert saved["files"][str(beta_x.relative_to(tree))]["count"] == 1
-
-    # Re-running with the same content should now be a full cache hit
-    # even though alpha_two has no tests.
-    with patch.object(split_tests, "_run_collect_batches") as run_batches:
-        folder = split_tests.collect_tests(tree, cache_path)
-    run_batches.assert_not_called()
-    # alpha_two contributes 0, only alpha_one + beta_x count.
-    assert folder.total_tests == 2
-
-
-def test_collect_tests_drops_deleted_files_from_cache(tree: Path) -> None:
-    """Files that disappear from disk are dropped from the saved cache."""
-    cache_path = tree / "cache.json"
-    alpha_one = tree / "components" / "alpha" / "test_one.py"
-    ghost_rel = "components/alpha/test_ghost.py"
-
-    _prime_cache(
-        cache_path,
-        tree,
-        hits={alpha_one: 1},
-        extra_entries={
-            ghost_rel: split_tests._CacheEntry(
-                hash="dead", fixture_hash="dead", count=42
-            )
-        },
-    )
-
-    with (
-        patch.object(split_tests, "_DIR_LEVEL_MISS_RATIO", 1.0),
-        patch.object(
-            split_tests, "_run_collect_batches", side_effect=_echo_one_test_each()
-        ),
-    ):
-        split_tests.collect_tests(tree, cache_path)
-
-    saved = json.loads(cache_path.read_text())
-    assert ghost_rel not in saved["files"]
-
-
-def _build_folder(tree: Path, counts: dict[Path, int]) -> split_tests.TestFolder:
-    """Build a TestFolder for ``tree`` populated with ``counts``."""
-    folder = split_tests.TestFolder(tree)
-    for path, n in counts.items():
-        folder.add_test_file(split_tests.TestFile(n, path))
-    return folder
-
-
-def test_split_tests_keeps_siblings_together_when_snapshots_present(
-    tmp_path: Path,
-) -> None:
-    """Same-dir files stay together when the folder has syrupy snapshots."""
-    one = tmp_path / "alpha" / "test_one.py"
-    two = tmp_path / "alpha" / "test_two.py"
-    one.parent.mkdir(parents=True)
-    one.touch()
-    two.touch()
-    # Add a snapshot so the syrupy constraint kicks in.
-    snapshots = tmp_path / "alpha" / "snapshots"
-    snapshots.mkdir()
-    (snapshots / "test_one.ambr").write_text("")
-
-    folder = _build_folder(tmp_path, {one: 60, two: 60})
-    holder = split_tests.BucketHolder(tests_per_bucket=50, bucket_count=3)
-    holder.split_tests(folder)
-    # Both files must end up in one bucket; the other two stay empty.
-    sizes = sorted(b.total_tests for b in holder._buckets)
-    assert sizes == [0, 0, 120]
-
-
-def test_split_tests_splits_siblings_when_no_snapshots(tmp_path: Path) -> None:
-    """Same-dir files split freely across buckets when no snapshots exist."""
-    one = tmp_path / "alpha" / "test_one.py"
-    two = tmp_path / "alpha" / "test_two.py"
-    one.parent.mkdir(parents=True)
-    one.touch()
-    two.touch()
-    # No snapshots dir → free to split.
-
-    folder = _build_folder(tmp_path, {one: 60, two: 60})
-    holder = split_tests.BucketHolder(tests_per_bucket=70, bucket_count=2)
-    holder.split_tests(folder)
-    sizes = sorted(b.total_tests for b in holder._buckets)
-    assert sizes == [60, 60]