Bump github/codeql-action from 4.35.4 to 4.35.5

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.4 to 4.35.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/68bde559dea0fdcac2102bfdf6230c5f70eb485e...9e0d7b8d25671d64c341c19c0152d693099fb5ba)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.35.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/workflows/codeql.yml

@@ -28,11 +28,11 @@ jobs:
           persist-credentials: false
 
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@68bde559dea0fdcac2102bfdf6230c5f70eb485e # v4.35.4
+        uses: github/codeql-action/init@9e0d7b8d25671d64c341c19c0152d693099fb5ba # v4.35.5
         with:
           languages: python
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@68bde559dea0fdcac2102bfdf6230c5f70eb485e # v4.35.4
+        uses: github/codeql-action/analyze@9e0d7b8d25671d64c341c19c0152d693099fb5ba # v4.35.5
         with:
           category: "/language:python"

homeassistant/components/webostv/__init__.py

@@ -46,10 +46,8 @@ async def async_setup_entry(hass: HomeAssistant, entry: WebOsTvConfigEntry) -> b
         try:
             await client.connect()
         except WebOsTvPairError as err:
-            raise ConfigEntryAuthFailed(
-                translation_domain=DOMAIN,
-                translation_key="auth_failed",
-            ) from err
+            # pylint: disable-next=home-assistant-exception-not-translated
+            raise ConfigEntryAuthFailed(err) from err
 
     # If pairing request accepted there will be no error
     # Update the stored key without triggering reauth

homeassistant/components/webostv/device_trigger.py

@@ -6,7 +6,6 @@ from homeassistant.components.device_automation import (
     DEVICE_TRIGGER_BASE_SCHEMA,
     InvalidDeviceAutomationConfig,
 )
-from homeassistant.config_entries import ConfigEntryState
 from homeassistant.const import CONF_DEVICE_ID, CONF_PLATFORM, CONF_TYPE
 from homeassistant.core import CALLBACK_TYPE, HomeAssistant
 from homeassistant.exceptions import HomeAssistantError
@@ -14,7 +13,10 @@ from homeassistant.helpers.trigger import TriggerActionType, TriggerInfo
 from homeassistant.helpers.typing import ConfigType
 
 from . import DOMAIN, trigger
-from .helpers import async_get_device_entry_by_device_id
+from .helpers import (
+    async_get_client_by_device_entry,
+    async_get_device_entry_by_device_id,
+)
 from .triggers.turn_on import (
     PLATFORM_TYPE as TURN_ON_PLATFORM_TYPE,
     async_get_turn_on_trigger,
@@ -38,31 +40,10 @@ async def async_validate_trigger_config(
         device_id = config[CONF_DEVICE_ID]
         try:
             device = async_get_device_entry_by_device_id(hass, device_id)
+            async_get_client_by_device_entry(hass, device)
         except ValueError as err:
-            raise InvalidDeviceAutomationConfig(
-                translation_domain=DOMAIN,
-                translation_key="device_not_valid",
-                translation_placeholders={"device_id": device_id},
-            ) from err
-
-        for config_entry_id in device.config_entries:
-            if (
-                entry := hass.config_entries.async_get_entry(config_entry_id)
-            ) and entry.domain == DOMAIN:
-                if entry.state is ConfigEntryState.LOADED:
-                    break
-
-                raise InvalidDeviceAutomationConfig(
-                    translation_domain=DOMAIN,
-                    translation_key="device_config_entry_not_loaded",
-                    translation_placeholders={"device_id": device.id},
-                )
-        else:
-            raise InvalidDeviceAutomationConfig(
-                translation_domain=DOMAIN,
-                translation_key="device_not_valid",
-                translation_placeholders={"device_id": device.id},
-            )
+            # pylint: disable-next=home-assistant-exception-not-translated
+            raise InvalidDeviceAutomationConfig(err) from err
 
     return config
 

homeassistant/components/webostv/helpers.py

@@ -4,7 +4,7 @@ import logging
 
 from aiowebostv import WebOsClient, WebOsTvState
 
-from homeassistant.config_entries import ConfigEntry
+from homeassistant.config_entries import ConfigEntry, ConfigEntryState
 from homeassistant.const import CONF_CLIENT_SECRET, CONF_HOST
 from homeassistant.core import HomeAssistant, callback
 from homeassistant.exceptions import HomeAssistantError
@@ -56,6 +56,31 @@ def async_get_device_id_from_entity_id(hass: HomeAssistant, entity_id: str) -> s
     return entity_entry.device_id
 
 
+@callback
+def async_get_client_by_device_entry(
+    hass: HomeAssistant, device: DeviceEntry
+) -> WebOsClient:
+    """Get WebOsClient from Device Registry by device entry.
+
+    Raises ValueError if client is not found.
+    """
+    for config_entry_id in device.config_entries:
+        entry: WebOsTvConfigEntry | None = hass.config_entries.async_get_entry(
+            config_entry_id
+        )
+        if entry and entry.domain == DOMAIN:
+            if entry.state is ConfigEntryState.LOADED:
+                return entry.runtime_data
+
+            raise ValueError(
+                f"Device {device.id} is not from a loaded {DOMAIN} config entry"
+            )
+
+    raise ValueError(
+        f"Device {device.id} is not from an existing {DOMAIN} config entry"
+    )
+
+
 def get_sources(tv_state: WebOsTvState) -> list[str]:
     """Construct sources list."""
     sources = []

homeassistant/components/webostv/strings.json

@@ -46,18 +46,9 @@
     }
   },
   "exceptions": {
-    "auth_failed": {
-      "message": "Pairing failed, make sure to accept the pairing request on your TV."
-    },
     "communication_error": {
       "message": "Communication error while calling {func} for device {name}: {error}"
     },
-    "device_config_entry_not_loaded": {
-      "message": "The LG webOS TV integration for device {device_id} is not loaded."
-    },
-    "device_not_valid": {
-      "message": "Device {device_id} is not a valid LG webOS TV device."
-    },
     "device_off": {
       "message": "Error calling {func} for device {name}: Device is off and cannot be controlled."
     },

tests/components/webostv/test_device_trigger.py

@@ -117,7 +117,7 @@ async def test_invalid_trigger_raises(
         )
 
     # Test invalid device id
-    with pytest.raises(InvalidDeviceAutomationConfig) as exc_info:
+    with pytest.raises(InvalidDeviceAutomationConfig):
         await device_trigger.async_validate_trigger_config(
             hass,
             {
@@ -127,23 +127,13 @@ async def test_invalid_trigger_raises(
                 "device_id": "invalid_device_id",
             },
         )
-    assert exc_info.value.translation_domain == DOMAIN
-    assert exc_info.value.translation_key == "device_not_valid"
 
 
 @pytest.mark.parametrize(
-    ("domain", "entry_state", "expected_translation_key"),
+    ("domain", "entry_state"),
     [
-        (
-            DOMAIN,
-            ConfigEntryState.NOT_LOADED,
-            "device_config_entry_not_loaded",
-        ),
-        (
-            "fake",
-            ConfigEntryState.LOADED,
-            "device_not_valid",
-        ),
+        (DOMAIN, ConfigEntryState.NOT_LOADED),
+        ("fake", ConfigEntryState.LOADED),
     ],
 )
 async def test_invalid_entry_raises(
@@ -152,7 +142,6 @@ async def test_invalid_entry_raises(
     client,
     domain: str,
     entry_state: ConfigEntryState,
-    expected_translation_key: str,
 ) -> None:
     """Test device id not loaded or from another domain raises."""
     await setup_webostv(hass)
@@ -173,7 +162,5 @@ async def test_invalid_entry_raises(
     }
 
     # Test that device id from non webostv domain raises exception
-    with pytest.raises(InvalidDeviceAutomationConfig) as exc_info:
+    with pytest.raises(InvalidDeviceAutomationConfig):
         await device_trigger.async_validate_trigger_config(hass, config)
-    assert exc_info.value.translation_domain == DOMAIN
-    assert exc_info.value.translation_key == expected_translation_key