Fix NDK version in Android CI

solve span compile problem with gcc 5.5.0 (#1052 )
GCC 4.8.0 - 7.0 has a bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480) involving specialization in a namespace enclosing the specialized template. This PR fixes an appearance of this bug in the span header.
2026-08-06 13:44:09 +02:00 · 2022-09-26 15:35:42 -07:00 · 2022-08-18 12:28:11 -07:00 · 2022-08-17 12:40:45 -07:00 · 2022-07-18 17:42:21 -07:00
2 changed files with 9 additions and 7 deletions
@@ -29,7 +29,7 @@ jobs:
          echo "Emulator starting"

      - name: Configure
-        run: cmake -Werror=dev -DCMAKE_TOOLCHAIN_FILE=$ANDROID_HOME/ndk-bundle/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug ..
+        run: cmake -Werror=dev -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_LATEST_HOME/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=16 -DANDROID_ABI=x86_64 -DCMAKE_BUILD_TYPE=Debug ..

      - name: Build
        run: cmake --build . --parallel
@@ -343,16 +343,18 @@ namespace details
    };
 }} // namespace gsl::details

+namespace std
+{
 template <class Type>
-struct std::pointer_traits<::gsl::details::span_iterator<Type>> {
-    using pointer         = ::gsl::details::span_iterator<Type>;
-    using element_type    = Type;
+struct pointer_traits<::gsl::details::span_iterator<Type>>
+{
+    using pointer = ::gsl::details::span_iterator<Type>;
+    using element_type = Type;
    using difference_type = ptrdiff_t;

-    static constexpr element_type* to_address(const pointer i) noexcept {
-        return i.current_;
-    }
+    static constexpr element_type* to_address(const pointer i) noexcept { return i.current_; }
 };
+} // namespace std

 namespace gsl { namespace details {
    template <std::size_t Ext>
Author	SHA1	Message	Date
Dmitry Kobets	327415221f	Fix NDK version in Android CI	2022-09-26 15:35:42 -07:00
Werner Henze	10df83d292	solve span compile problem with gcc 5.5.0 (#1052 ) GCC 4.8.0 - 7.0 has a bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480) involving specialization in a namespace enclosing the specialized template. This PR fixes an appearance of this bug in the span header.	2022-08-18 12:28:11 -07:00
dmitrykobets-msft	2e94541fcf	Use updated NDK version in android test suite (#1053 ) https://github.com/actions/runner-images/issues/5930 recently updated the NDK version, resulting in test breakages. Update the version.	2022-08-17 12:40:45 -07:00
dmitrykobets-msft	330583f478	Resolve MSVC warning C5260 (#1049 ) * Test solution * Mark dynamic_extent as inline, compiler-version-permitting	2022-07-18 17:42:21 -07:00