mirror of
https://github.com/microsoft/GSL.git
synced 2026-07-05 08:00:49 +02:00
b2f6bec48e
* clang-format improvements - Add a clang-format linter check to the PR pipeline - Apply clang-format to files where the linter initially failed - Remove `CommentPragmas` from `.clang-format` - Remove all `// clang-format off` and `// NO-FORMAT` as they are not needed - Remove a commented out `GSL_SUPPRESS` * clang-format 20 * pipeline fail * Update .github/workflows/clang-format.yml Co-authored-by: Carson Radtke <nosrac925@gmail.com> * output used clang-format version * installed version is 18 which replaces "GSL_SUPPRESS(bounds.1)" with "GSL_SUPPRESS(bounds .1)" * only include/gsl, not include to prevent formatting of include/CMakeLists.txt * apply clang-format[-20] In a VS2026 developer command prompt I ran `clang-format -i include\gsl\* --assume-filename x.cpp`. This was necessary because VS GUI does not format files without an extension :(. Please note that `--assume-filename` is necessary here, otherwise the files will not be formatted. Surprisingly the behaviour for the formatter differs from the behaviour of `lang-format(-20) --dry-run --Werror include/gsl/*` where clang-format recognizes that the files is C++. * change "#if 0" back to original version with comments only * formatting scripts for windows and linux for linux with linter (shfmt and shellcheck) * add WhitespaceSensitiveMacros: [GSL_SUPPRESS] * provide path for clang-format (Windows) Currently not clear to me: On my personal computer at home, when I start "Developer Command Prompt for VS18", I can run `clang-format` without providing the path. On my managed (domain) company computer, when I start "Developer Command Prompt for VS18", I can NOT run `clang-format` without providing the path. I need to call `"%VCINSTALLDIR%Tools\Llvm\bin\clang-format"`. I have no idea what the difference is. At least the version `"%VCINSTALLDIR%Tools\Llvm\bin\clang-format"` works on both computers, so I add the path. --------- Co-authored-by: Werner Henze <w.henze@avm.de> Co-authored-by: Carson Radtke <nosrac925@gmail.com> Co-authored-by: Werner Henze <werner.henze+gitcommits@posteo.de>
120 lines
3.6 KiB
C++
120 lines
3.6 KiB
C++
#include <gtest/gtest.h>
|
|
|
|
#include <gsl/pointers>
|
|
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <type_traits>
|
|
#include <utility>
|
|
|
|
#if __cplusplus >= 201703l
|
|
using std::void_t;
|
|
#else // __cplusplus >= 201703l
|
|
template <class...>
|
|
using void_t = void;
|
|
#endif // __cplusplus < 201703l
|
|
|
|
namespace
|
|
{
|
|
// Custom pointer type that can be used for gsl::not_null, but for which these cannot be swapped.
|
|
struct NotMoveAssignableCustomPtr
|
|
{
|
|
NotMoveAssignableCustomPtr() = default;
|
|
NotMoveAssignableCustomPtr(const NotMoveAssignableCustomPtr&) = default;
|
|
NotMoveAssignableCustomPtr& operator=(const NotMoveAssignableCustomPtr&) = default;
|
|
NotMoveAssignableCustomPtr(NotMoveAssignableCustomPtr&&) = default;
|
|
NotMoveAssignableCustomPtr& operator=(NotMoveAssignableCustomPtr&&) = delete;
|
|
|
|
bool operator!=(std::nullptr_t) const { return true; }
|
|
|
|
int dummy{}; // Without this clang warns, that NotMoveAssignableCustomPtr() is unneeded
|
|
};
|
|
|
|
template <typename U, typename = void>
|
|
static constexpr bool SwapCompilesFor = false;
|
|
template <typename U>
|
|
static constexpr bool
|
|
SwapCompilesFor<U, void_t<decltype(gsl::swap<U>(std::declval<gsl::not_null<U>&>(),
|
|
std::declval<gsl::not_null<U>&>()))>> = true;
|
|
|
|
TEST(pointers_test, swap)
|
|
{
|
|
// taken from gh-1129:
|
|
{
|
|
gsl::not_null<std::unique_ptr<int>> a(std::make_unique<int>(0));
|
|
gsl::not_null<std::unique_ptr<int>> b(std::make_unique<int>(1));
|
|
|
|
static_assert(noexcept(gsl::swap(a, b)),
|
|
"not null unique_ptr should be noexcept-swappable");
|
|
|
|
EXPECT_TRUE(*a == 0);
|
|
EXPECT_TRUE(*b == 1);
|
|
|
|
gsl::swap(a, b);
|
|
|
|
EXPECT_TRUE(*a == 1);
|
|
EXPECT_TRUE(*b == 0);
|
|
|
|
// Make sure our custom ptr can be used with not_null. The shared_pr is to prevent "unused"
|
|
// compiler warnings.
|
|
const auto shared_custom_ptr{std::make_shared<NotMoveAssignableCustomPtr>()};
|
|
gsl::not_null<NotMoveAssignableCustomPtr> c{*shared_custom_ptr};
|
|
EXPECT_TRUE(c.get() != nullptr);
|
|
}
|
|
|
|
{
|
|
gsl::strict_not_null<std::unique_ptr<int>> a{std::make_unique<int>(0)};
|
|
gsl::strict_not_null<std::unique_ptr<int>> b{std::make_unique<int>(1)};
|
|
|
|
static_assert(noexcept(gsl::swap(a, b)),
|
|
"strict not null unique_ptr should be noexcept-swappable");
|
|
|
|
EXPECT_TRUE(*a == 0);
|
|
EXPECT_TRUE(*b == 1);
|
|
|
|
gsl::swap(a, b);
|
|
|
|
EXPECT_TRUE(*a == 1);
|
|
EXPECT_TRUE(*b == 0);
|
|
}
|
|
|
|
{
|
|
gsl::not_null<std::unique_ptr<int>> a{std::make_unique<int>(0)};
|
|
gsl::strict_not_null<std::unique_ptr<int>> b{std::make_unique<int>(1)};
|
|
|
|
EXPECT_TRUE(*a == 0);
|
|
EXPECT_TRUE(*b == 1);
|
|
|
|
gsl::swap(a, b);
|
|
|
|
EXPECT_TRUE(*a == 1);
|
|
EXPECT_TRUE(*b == 0);
|
|
}
|
|
|
|
static_assert(!SwapCompilesFor<NotMoveAssignableCustomPtr>,
|
|
"!SwapCompilesFor<NotMoveAssignableCustomPtr>");
|
|
}
|
|
|
|
TEST(pointers_test, member_types)
|
|
{
|
|
static_assert(std::is_same<gsl::not_null<int*>::element_type, int*>::value,
|
|
"check member type: element_type");
|
|
}
|
|
|
|
TEST(pointers_test, hash_noexcept_compiles)
|
|
{
|
|
{
|
|
using Key = gsl::not_null<std::shared_ptr<int>>;
|
|
static_assert(noexcept(std::hash<Key>{}(std::declval<Key>())),
|
|
"gsl::not_null hash operator must be noexcept");
|
|
}
|
|
|
|
{
|
|
using Key = gsl::strict_not_null<std::shared_ptr<int>>;
|
|
static_assert(noexcept(std::hash<Key>{}(std::declval<Key>())),
|
|
"gsl::strict_not_null hash operator must be noexcept");
|
|
}
|
|
}
|
|
|
|
} // namespace
|