mpusz/mp-units
1
0
Fork 1
mirror of https://github.com/mpusz/mp-units.git synced 2025-08-05 05:04:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #335 from JohelEGP/non_static_constexpr_globals

Browse Source 
refactor: drop `static` from `constexpr` globals
This commit is contained in:
Mateusz Pusz
2022-03-10 21:23:00 +01:00
committed by GitHub
parent 6193854f31 72046b0fe7
commit 1b9d680275
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/core/include/units/magnitude.h
View File

@@ -104,9 +104,9 @@ base_power(T) -> base_power<std::intmax_t>;
// Implementation for BasePower concept (below).
namespace detail {
template<typename T>
static constexpr bool is_base_power = false;
inline constexpr bool is_base_power = false;
template<BaseRep T>
static constexpr bool is_base_power<base_power<T>> = true;
inline constexpr bool is_base_power<base_power<T>> = true;
} // namespace detail
/**
@@ -301,13 +301,13 @@ constexpr bool strictly_increasing(Ts&&... ts) {
}
template<BasePower auto... BPs>
static constexpr bool all_base_powers_valid = (is_valid_base_power(BPs) && ...);
inline constexpr bool all_base_powers_valid = (is_valid_base_power(BPs) && ...);
template<BasePower auto... BPs>
static constexpr bool all_bases_in_order = strictly_increasing(BPs.get_base()...);
inline constexpr bool all_bases_in_order = strictly_increasing(BPs.get_base()...);
template<BasePower auto... BPs>
static constexpr bool is_base_power_pack_valid = all_base_powers_valid<BPs...> && all_bases_in_order<BPs...>;
inline constexpr bool is_base_power_pack_valid = all_base_powers_valid<BPs...> && all_bases_in_order<BPs...>;
constexpr bool is_rational(BasePower auto bp) {
return std::is_integral_v<decltype(bp.get_base())> && (bp.power.den == 1) && (bp.power.exp >= 0);
@@ -337,9 +337,9 @@ struct magnitude {
// Implementation for Magnitude concept (below).
namespace detail {
template<typename T>
static constexpr bool is_magnitude = false;
inline constexpr bool is_magnitude = false;
template<BasePower auto... BPs>
static constexpr bool is_magnitude<magnitude<BPs...>> = true;
inline constexpr bool is_magnitude<magnitude<BPs...>> = true;
} // namespace detail
/**
@@ -455,7 +455,7 @@ template<>
struct prime_factorization<1> { static constexpr magnitude<> value{}; };
template<std::intmax_t N>
static constexpr auto prime_factorization_v = prime_factorization<N>::value;
inline constexpr auto prime_factorization_v = prime_factorization<N>::value;
} // namespace detail
/**