mpusz/mp-units
1
0
Fork 1
mirror of https://github.com/mpusz/mp-units.git synced 2025-08-01 03:14:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: explicit cast added to less for magnitudes to fix clang-arm64 conversion error

Browse Source
This commit is contained in:
Mateusz Pusz
2024-10-03 22:10:38 +02:00
parent cc521ee723
commit a95b2c770e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/include/mp-units/framework/magnitude.h
View File

@@ -226,7 +226,9 @@ template<typename T>
// Magnitude product implementation.
[[nodiscard]] consteval bool less(MagnitudeSpec auto lhs, MagnitudeSpec auto rhs)
{
return get_base_value(lhs) < get_base_value(rhs);
// clang-arm64 raises "error: implicit conversion from 'long' to 'long double' may lose precision" so we need an explicit cast
using ct = std::common_type_t<decltype(get_base_value(lhs)), decltype(get_base_value(rhs))>;
return static_cast<ct>(get_base_value(lhs)) < static_cast<ct>(get_base_value(rhs));
}
// The largest integer which can be extracted from any magnitude with only a single basis vector.