mpusz/mp-units
1
0
Fork 1
mirror of https://github.com/mpusz/mp-units.git synced 2025-07-31 02:47:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: restore user-warnings within the library implementation

Browse Source
This commit is contained in:
Johel Ernesto Guerrero Peña
2021-02-05 22:40:22 -04:00
committed by Mateusz Pusz
parent 8100b6c13d
commit efeacca9ee
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cmake/warnings.cmake
View File

@ -67,6 +67,7 @@ function(set_warnings target scope)
/w14928 # illegal copy-initialization; more than one user-defined /w14928 # illegal copy-initialization; more than one user-defined
# conversion has been implicitly applied # conversion has been implicitly applied
/permissive- # standards conformance mode for MSVC compiler. /permissive- # standards conformance mode for MSVC compiler.
/wd4244 #
) )
set(CLANG_WARNINGS set(CLANG_WARNINGS
@ -82,8 +83,8 @@ function(set_warnings target scope)
-Wunused # warn on anything being unused -Wunused # warn on anything being unused
-Woverloaded-virtual # warn if you overload (not override) a virtual function -Woverloaded-virtual # warn if you overload (not override) a virtual function
-Wcast-qual # warn on dropping const or volatile qualifiers -Wcast-qual # warn on dropping const or volatile qualifiers
-Wconversion # warn on type conversions that may lose data # -Wconversion # warn on type conversions that may lose data
-Wsign-conversion # warn on sign conversions # -Wsign-conversion # warn on sign conversions
-Wnull-dereference # warn if a null dereference is detected -Wnull-dereference # warn if a null dereference is detected
-Wdouble-promotion # warn if float is implicit promoted to double -Wdouble-promotion # warn if float is implicit promoted to double
-Wformat=2 # warn on security issues around functions that format output (ie printf) -Wformat=2 # warn on security issues around functions that format output (ie printf)

2
src/include/units/quantity.h
View File

@ -134,7 +134,7 @@ public:
template<safe_convertible_to_<rep> Value> template<safe_convertible_to_<rep> Value>
explicit(!(is_same_v<dimension, dim_one> && is_same_v<unit, ::units::one>)) explicit(!(is_same_v<dimension, dim_one> && is_same_v<unit, ::units::one>))
constexpr quantity(const Value& v) : value_(static_cast<rep>(v)) {} constexpr quantity(const Value& v) : value_(v) {}
template<safe_castable_to_<quantity> Q> template<safe_castable_to_<quantity> Q>
constexpr quantity(const Q& q) : value_(quantity_cast<quantity>(q).count()) {} constexpr quantity(const Q& q) : value_(quantity_cast<quantity>(q).count()) {}

2
test/unit_test/static/CMakeLists.txt
View File

@ -51,5 +51,3 @@ target_link_libraries(unit_tests_static
PRIVATE PRIVATE
mp::units mp::units
) )
set_source_files_properties(quantity_test.cpp PROPERTIES COMPILE_OPTIONS $<IF:$<CXX_COMPILER_ID:MSVC>,/wd4244,-Wno-conversion>)