mpusz/mp-units
1
0
Fork 1
mirror of https://github.com/mpusz/mp-units.git synced 2025-08-05 13:14:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Try fixing "unreachable code" warning on MSVC 14.2

Browse Source 
This doesn't show up on any other compiler, including MSVC 14.3, so I
think it's just a compiler bug.  Cursory googling suggests perhaps that
some older versions of MSVC have immature support for `if constexpr`.
This commit is contained in:
Chip Hogg
2022-01-12 09:47:40 -05:00
parent d554fb28cc
commit fb602a4497
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/include/units/magnitude.h
View File

@@ -306,12 +306,14 @@ constexpr auto operator*(magnitude<H1, T1...>, magnitude<H2, T2...>) {
return magnitude<new_head>{} * partial_product; return magnitude<new_head>{} * partial_product;
} }
} }
// Case for when H1 has the smaller base. // Case for when H1 has the smaller base.
else if constexpr(H1.get_base() < H2.get_base()){ if constexpr(H1.get_base() < H2.get_base()){
return magnitude<H1>{} * (magnitude<T1...>{} * magnitude<H2, T2...>{}); return magnitude<H1>{} * (magnitude<T1...>{} * magnitude<H2, T2...>{});
} }
// Case for when H2 has the smaller base. // Case for when H2 has the smaller base.
else { if constexpr(H1.get_base() > H2.get_base()){
return magnitude<H2>{} * (magnitude<H1, T1...>{} * magnitude<T2...>{}); return magnitude<H2>{} * (magnitude<H1, T1...>{} * magnitude<T2...>{});
} }
} }