mirror of
https://github.com/mpusz/mp-units.git
synced 2026-07-06 00:20:52 +02:00
96965634f5
mp-units' minimum-supported MSVC 195 (VS 2026) has solid `import std;`
support, but enabling `-o import_std=True` against the build hit two
issues that this change fixes.
(1) Module scanning was only enabled when `cxx_modules=True`.
Without `CMAKE_CXX_SCAN_FOR_MODULES=ON`, CMake doesn't link the implicit
std module BMI into non-module translation units that do `import std;`,
producing C2230 "could not find module 'std'". Enable scanning whenever
`import_std=True` as well. Same bug fixed in `test_package/conanfile.py`.
(2) The std module BMI is built with mismatched compile flags.
CMake materializes the implicit std module BMI as `__cmake_cxx_std_NN`,
a separate internal target that does not link mp-units and therefore
does not inherit mp-units' target-level options. On MSVC this caused
C5050 (`_UTF8` defined on consumer but not on module command line) and
on Clang 21 there is a parallel `-Wreserved-module-identifier` issue
already partially handled in `src/CMakeLists.txt` but in a directory
scope that did not actually reach the BMI either.
Consolidate the workarounds into one `src/cmake/import-std-setup.cmake`
snippet that applies the flags project-wide via `add_compile_options`,
self-guarded by `if(NOT CMAKE_CXX_MODULE_STD) return()`. It is included
from every entry point so all delivery paths converge:
- top-level `CMakeLists.txt` for the dev build
- bundled `mp-unitsConfig.cmake` for `find_package` consumers
- via `cmake_build_modules` in `package_info()` for Conan-generated
configs (the `cxx_modules=False` consumer path)
Other pieces:
- `test/static/unit_magnitude_test.cpp` was the only test in the repo
missing the `MP_UNITS_IMPORT_STD` gate around `#include <type_traits>`,
causing duplicate `std::integral_constant` definitions in this
configuration.
- Compiler support table announces MSVC 195+ for `import std;`.
- Installation docs gain a consumer-side setup note covering the
CMake cache variables required, what mp-units handles automatically
via the snippet, and the `add_subdirectory`-vendored caveat.
Verified: `conan build . -pr msvc195 -o '&:cxx_modules=False'
-o '&:import_std=True' -s compiler.cppstd=23 -c
user.mp-units.build:all=True` -> 40/40 tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
102 lines
4.9 KiB
Markdown
102 lines
4.9 KiB
Markdown
# C++ compiler support (API/ABI) { #cpp-compiler-support }
|
|
|
|
!!! info
|
|
|
|
**mp-units** library tries to provide the best user experience possible with the C++ language.
|
|
To achieve that, it extensively uses the latest C++ language features.
|
|
|
|
Even though the library benefits from the latest C++ versions (if available), C++20 is enough
|
|
to compile and use all of the library's functionality. Newer features can be hidden behind
|
|
some [preprocessor macros](../how_to_guides/integration/wide_compatibility.md#using-compatibility-macros)
|
|
providing a backward-compatible way to use them.
|
|
|
|
The table below provides the minimum compiler version required to compile the code using
|
|
a specific C++ feature:
|
|
|
|
| C++ Feature | C++ version | gcc | clang | apple-clang | MSVC |
|
|
|-------------------------------|:-----------:|:----:|:----------:|:--------------:|:----:|
|
|
| **Minimum support** | 20 | 12+ | 16+ && !19 | 15-16 && !17.0 | 195+ |
|
|
| **`std::format`** | 20 | 13+ | 17+ | 16+ | 195+ |
|
|
| **C++ modules** | 20 | None | 17+ | None | None |
|
|
| **`import std;`** | 23 | None | 18+ | None | 195+ |
|
|
| **Explicit `this` parameter** | 23 | 14+ | 18+ | 17+ | 195+ |
|
|
|
|
??? note "Clang-19 unfixable bug"
|
|
|
|
Unfortunately, Clang-19 does not build **mp-units** because of an
|
|
[unfixable bug in the compiler](https://github.com/llvm/llvm-project/pull/118288).
|
|
|
|
??? note "Apple Clang-17.0 unfixable bug"
|
|
|
|
Unfortunately, Apple Clang-17.0 (Xcode 16.3, 16.4, 26.0, 26.0.1, 26.1, and 26.2-beta) does not
|
|
build **mp-units** because it has the same
|
|
[unfixable bug as Clang-19](https://github.com/llvm/llvm-project/pull/118288).
|
|
|
|
!!! important
|
|
|
|
Enabling/disabling features listed above may influence the API of the library and the ABI of
|
|
the customers' projects.
|
|
|
|
|
|
## `std::format`
|
|
|
|
- Provides
|
|
[powerful text formatting capabilities](../users_guide/framework_basics/text_output.md#text-formatting)
|
|
for C++.
|
|
- An alternative [fmtlib](https://github.com/fmtlib/fmt) library can be used instead if
|
|
- the C++ language feature is not supported,
|
|
- the customer's project did not switch to `std::format` yet (even when the compiler
|
|
supports it).
|
|
- To write code with wide compatibility a
|
|
[dedicated macro may be used](../how_to_guides/integration/wide_compatibility.md#mp_units_std_fmt).
|
|
- Tested with `__cpp_lib_format` [feature test macro](https://en.cppreference.com/w/cpp/feature_test).
|
|
- Related build options:
|
|
- Conan: [std_format](installation_and_usage.md#std_format)
|
|
- CMake: [MP_UNITS_API_STD_FORMAT](installation_and_usage.md#MP_UNITS_API_STD_FORMAT)
|
|
|
|
|
|
## C++ modules
|
|
|
|
- Provide new way to share declarations and definitions across translation units.
|
|
- If used, the library will distribute both "old-style" headers and module interface units
|
|
- associated with the same CMake targets.
|
|
- Even with full compiler support, a user may still decide to not pay for C++ modules
|
|
compilation if they are not needed by the customer's project.
|
|
- Feature test macro is not used for testing here because even if the compiler does not
|
|
support the entire C++ feature (e.g. header units), it is enough to build modules for this
|
|
library.
|
|
- Related build options:
|
|
- Conan: [cxx_modules](installation_and_usage.md#cxx_modules)
|
|
- CMake: [MP_UNITS_BUILD_CXX_MODULES](installation_and_usage.md#MP_UNITS_BUILD_CXX_MODULES)
|
|
|
|
!!! note
|
|
|
|
More requirements for C++ modules support can be found in the
|
|
[CMake's documentation](https://cmake.org/cmake/help/latest/manual/cmake-cxxmodules.7.html).
|
|
|
|
|
|
## `import std;`
|
|
|
|
- If enabled, the library will obtain all the definitions from the `std` namespace via
|
|
`import std;` instead of the "old-style" header includes.
|
|
- Related build options:
|
|
- Conan: [import_std](installation_and_usage.md#import_std)
|
|
- CMake: [CMAKE_CXX_MODULE_STD](https://cmake.org/cmake/help/latest/variable/CMAKE_CXX_MODULE_STD.html)
|
|
|
|
|
|
## Explicit `this` parameter
|
|
|
|
- This feature removes the need for the usage of the CRTP idiom in the
|
|
[`quantity_spec` definitions](../users_guide/framework_basics/systems_of_quantities.md#defining-quantities).
|
|
- To write code with wide compatibility
|
|
a [dedicated macro may be used](../how_to_guides/integration/wide_compatibility.md#QUANTITY_SPEC).
|
|
- Tested with `__cpp_explicit_this_parameter` [feature test macro](https://en.cppreference.com/w/cpp/feature_test).
|
|
- Note that some compiler versions do not implement this macro even though they do
|
|
support the
|
|
feature well enough. In such cases, compilation with explicit `this` is enforced.
|
|
- Related build options:
|
|
- Conan: [no_crtp](installation_and_usage.md#no_crtp)
|
|
- CMake: [MP_UNITS_API_NO_CRTP](installation_and_usage.md#MP_UNITS_API_NO_CRTP)
|
|
|
|
*[CRTP]: Curiously Recurring Template Parameter
|