PyLint fixes

platformio/builder/tools/piolib.py

@@ -14,6 +14,7 @@
 
 # pylint: disable=no-member, no-self-use, unused-argument, too-many-lines
 # pylint: disable=too-many-instance-attributes, too-many-public-methods
+# pylint: disable=assignment-from-no-return
 
 from __future__ import absolute_import
 

platformio/commands/home/helpers.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# pylint: disable=keyword-arg-before-vararg, arguments-differ
+# pylint: disable=keyword-arg-before-vararg,arguments-differ,signature-differs
 
 import os
 import socket

platformio/exception.py

@@ -92,7 +92,7 @@ class PlatformIOPackageException(PlatformioException):
     pass
 
 
-class UnknownPackage(PlatformIOPackageException):
+class UnknownPackage(UserSideException):
 
     MESSAGE = "Detected unknown package '{0}'"
 

platformio/managers/core.py

@@ -33,7 +33,7 @@ CORE_PACKAGES = {
     "tool-pvs-studio": "~7.7.0",
 }
 
-# pylint: disable=arguments-differ
+# pylint: disable=arguments-differ,signature-differs
 
 
 class CorePackageManager(PackageManager):

platformio/managers/lib.py

@@ -84,6 +84,7 @@ class LibraryManager(BasePkgManager):
         for v in versions:
             semver_new = self.parse_semver_version(v["name"])
             if semver_spec:
+                # pylint: disable=unsupported-membership-test
                 if not semver_new or semver_new not in semver_spec:
                     continue
                 if not item or self.parse_semver_version(item["name"]) < semver_new:

platformio/managers/package.py

@@ -46,7 +46,7 @@ class PackageRepoIterator(object):
         return self
 
     def __next__(self):
-        return self.next()
+        return self.next()  # pylint: disable=not-callable
 
     @staticmethod
     @util.memoized(expire="60s")

platformio/telemetry.py

@@ -294,10 +294,6 @@ def on_exception(e):
         isinstance(e, cls)
         for cls in (IOError, exception.ReturnErrorCode, exception.UserSideException,)
     ]
-    try:
-        skip_conditions.append("[API] Account: " in str(e))
-    except UnicodeEncodeError as ue:
-        e = ue
     if any(skip_conditions):
         return
     is_fatal = any(