platformio/platformio-core
1
0
Fork 1
mirror of https://github.com/platformio/platformio-core.git synced 2025-07-29 17:47:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Do not allow ":" and "/" chars in a package name

Browse Source
This commit is contained in:
Ivan Kravets
2020-06-22 15:25:02 +03:00
parent 87d5997b46
commit 967a856061
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
platformio/package/manifest/schema.py
View File

@ -149,7 +149,13 @@ class ExampleSchema(StrictSchema):
class ManifestSchema(BaseSchema):
# Required fields
name = fields.Str(required=True, validate=validate.Length(min=1, max=100))
name = fields.Str(
required=True,
validate=[
validate.Length(min=1, max=100),
validate.Regexp(r"^[^:/]+$", error="The next chars [:/] are not allowed"),
],
)
version = fields.Str(required=True, validate=validate.Length(min=1, max=50))
# Optional fields

4
tests/package/test_manifest.py
View File

@ -841,3 +841,7 @@ def test_broken_schemas():
version="1.2.3",
)
)
# invalid package name
with pytest.raises(ManifestValidationError, match=("are not allowed")):
ManifestSchema().load_manifest(dict(name="C/C++ :library", version="1.2.3"))