platformio/platformio-core
1
0
Fork 1
mirror of https://github.com/platformio/platformio-core.git synced 2025-07-30 01:57:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Iterating the dictionary directly instead of calling .keys()

Browse Source
This commit is contained in:
Ivan Kravets
2016-07-09 15:16:42 +03:00
parent e33e950712
commit a73a710364
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
platformio/builder/scripts/frameworks/mbed.py
View File

@ -86,7 +86,7 @@ MBED_LIBS_MAP = {
def get_mbedlib_includes(): def get_mbedlib_includes():
result = [] result = []
for lib in MBED_LIBS_MAP.keys(): for lib in MBED_LIBS_MAP:
includes = [] includes = []
lib_dir = join(env.subst("$PLATFORMFW_DIR"), "libs", lib) lib_dir = join(env.subst("$PLATFORMFW_DIR"), "libs", lib)
for _, _, files in walk(lib_dir): for _, _, files in walk(lib_dir):

2
platformio/builder/tools/platformio.py
View File

@ -154,7 +154,7 @@ def ProcessUnFlags(env, flags):
all_flags.extend(items) all_flags.extend(items)
all_flags = set(all_flags) all_flags = set(all_flags)
for key in parsed_flags.keys(): for key in parsed_flags:
cur_flags = set(env.get(key, [])) cur_flags = set(env.get(key, []))
for item in cur_flags & all_flags: for item in cur_flags & all_flags:
while item in env[key]: while item in env[key]:

2
platformio/commands/lib.py
View File

@ -153,7 +153,7 @@ def lib_install(ctx, libid, version):
def lib_install_dependency(ctx, data): def lib_install_dependency(ctx, data):
assert isinstance(data, dict) assert isinstance(data, dict)
query = [] query = []
for key in data.keys(): for key in data:
if key in ("authors", "frameworks", "platforms", "keywords"): if key in ("authors", "frameworks", "platforms", "keywords"):
values = data[key] values = data[key]
if not isinstance(values, list): if not isinstance(values, list):

4
platformio/maintenance.py
View File

@ -101,7 +101,7 @@ class Upgrader(object):
prev_platforms = [] prev_platforms = []
# remove platform's folder (obsolete package structure) # remove platform's folder (obsolete package structure)
for name in PlatformFactory.get_platforms().keys(): for name in PlatformFactory.get_platforms():
pdir = join(get_home_dir(), name) pdir = join(get_home_dir(), name)
if not isdir(pdir): if not isdir(pdir):
continue continue
@ -234,7 +234,7 @@ def check_internal_updates(ctx, what):
outdated_items = [] outdated_items = []
if what == "platforms": if what == "platforms":
for platform in PlatformFactory.get_platforms(installed=True).keys(): for platform in PlatformFactory.get_platforms(installed=True):
p = PlatformFactory.newPlatform(platform) p = PlatformFactory.newPlatform(platform)
if p.is_outdated(): if p.is_outdated():
outdated_items.append(platform) outdated_items.append(platform)

2
platformio/telemetry.py
View File

@ -326,7 +326,7 @@ def backup_reports(items):
for params in items: for params in items:
# skip static options # skip static options
for key in params.keys(): for key in params:
if key in ("v", "tid", "cid", "cd1", "cd2", "sr", "an"): if key in ("v", "tid", "cid", "cd1", "cd2", "sr", "an"):
del params[key] del params[key]