Moved "uploader" utility to separated tool folder

platformio/builder/scripts/atmelavr.py

@@ -47,13 +47,13 @@ env.Replace(
         "-mmcu=$BOARD_MCU"
     ],
 
-    UPLOADER="avrdude",
+    UPLOADER=join("$PLATFORMTOOLS_DIR", "avrdude", "avrdude"),
     UPLOADERFLAGS=[
         "-V",  # do not verify
         "-q",  # suppress progress output
         "-D",  # disable auto erase for flash memory
         "-p", "$BOARD_MCU",
-        "-C", join("$PLATFORMTOOLS_DIR", "toolchain", "etc", "avrdude.conf"),
+        "-C", join("$PLATFORMTOOLS_DIR", "avrdude", "avrdude.conf"),
         "-c", "$UPLOAD_PROTOCOL",
         "-b", "$UPLOAD_SPEED",
         "-P", "$UPLOAD_PORT"

platformio/builder/scripts/timsp430.py

@@ -47,7 +47,7 @@ env.Replace(
         "-Wl,-gc-sections,-u,main"
     ],
 
-    UPLOADER=(join("$PLATFORMTOOLS_DIR", "mspdebug", "mspdebug")),
+    UPLOADER=join("$PLATFORMTOOLS_DIR", "mspdebug", "mspdebug"),
     UPLOADERFLAGS=[
         "$UPLOAD_PROTOCOL",
         "--force-reset"

platformio/builder/scripts/titiva.py

@@ -69,7 +69,7 @@ env.Replace(
         "-fsingle-precision-constant"
     ],
 
-    UPLOADER="lm4flash",
+    UPLOADER=join("$PLATFORMTOOLS_DIR", "lm4flash", "lm4flash"),
     UPLOADCMD="$UPLOADER $SOURCES"
 )
 

platformio/builder/tools/platformio.py

@@ -42,7 +42,7 @@ def VariantDirRecursive(env, variant_dir, src_dir, duplicate=True):
     # add root dir by default
     variants = [variant_dir]
     env.VariantDir(variant_dir, src_dir, duplicate)
-    for root, dirnames, filenames in walk(env.subst(src_dir)):
+    for root, dirnames, _ in walk(env.subst(src_dir)):
         if not dirnames:
             continue
         for dn in dirnames:
@@ -95,7 +95,7 @@ def ResetDevice(env):
     s.close()
 
 
-def exists(env):
+def exists(_):
     return True