Compare commits

...

11 Commits

Author SHA1 Message Date
Simon Wisselink c7a64ce0b3 Merge branch 'master' into issue_906 2023-11-06 17:25:20 +01:00
Simon Wisselink 66ba7cfb95 Fix double changelog merged entry 2023-11-06 15:52:52 +01:00
Simon Wisselink 20764ff963 Add changelog 2023-11-06 15:51:45 +01:00
Simon Wisselink d5c7f8c5f5 Add support for MacOS test running using mutagen-compose. 2023-11-06 15:51:45 +01:00
Shad ffb9f9eb26 Typos in documentation (#914) 2023-11-06 15:51:45 +01:00
Simon Wisselink a65c652778 changelog 2023-11-06 15:51:37 +01:00
Simon Wisselink 0dd786ea8f Added some extra unit test 2023-11-06 15:51:19 +01:00
Simon Wisselink ae5ca4e4c4 add case sensitivity test 2023-11-06 15:51:19 +01:00
Jack Dane 46f96877b1 Fix case-sensitive tag names (#907) (#910)
* Don't lower tags until they are used for extensions so custom tags can be case-sensitive.
2023-11-06 15:51:19 +01:00
Simon Wisselink 50dd6856c5 Add changelog 2023-11-06 15:48:14 +01:00
Simon Wisselink 134e7074ce Do not auto-html-escape custom function results.
Fixes #906
This behavior is under-defined though. This requires some clear documentation.
2023-09-21 23:52:45 +02:00
3 changed files with 33 additions and 1 deletions
+1
View File
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Registered output filters wouldn't run [#899](https://github.com/smarty-php/smarty/issues/899)
- Use of negative numbers in {math} equations [#895](https://github.com/smarty-php/smarty/issues/895)
- Do not auto-html-escape custom function results [#906](https://github.com/smarty-php/smarty/issues/906)
- Fix case-sensitive tag names [#907](https://github.com/smarty-php/smarty/issues/907)
### Removed
+1 -1
View File
@@ -1143,7 +1143,7 @@ class Template extends BaseCompiler {
if ($this->smarty->getFunctionHandler($base_tag)) {
if (!isset($this->smarty->security_policy) || $this->smarty->security_policy->isTrustedTag($base_tag, $this)) {
return (new \Smarty\Compile\PrintExpressionCompiler())->compile(
[],
['nofilter'], // functions are never auto-escaped
$this,
['value' => $this->compileFunctionCall($base_tag, $args, $parameter)]
);
@@ -30,4 +30,35 @@ class AutoEscapeTest extends PHPUnit_Smarty
$tpl->assign('foo', '<a@b.c>');
$this->assertEquals("&lt;a@b.c&gt;", $this->smarty->fetch($tpl));
}
/**
* test 'escapeHtml' property
* @group issue906
*/
public function testAutoEscapeDoesNotEscapeFunctionPlugins()
{
$this->smarty->registerPlugin(
\Smarty\Smarty::PLUGIN_FUNCTION,
'horizontal_rule',
function ($params, $smarty) { return "<hr>"; }
);
$tpl = $this->smarty->createTemplate('eval:{horizontal_rule}');
$this->assertEquals("<hr>", $this->smarty->fetch($tpl));
}
/**
* test 'escapeHtml' property
* @group issue906
*/
public function testAutoEscapeDoesNotEscapeBlockPlugins()
{
$this->smarty->registerPlugin(
\Smarty\Smarty::PLUGIN_BLOCK,
'paragraphify',
function ($params, $content) { return $content == null ? null : "<p>".$content."</p>"; }
);
$tpl = $this->smarty->createTemplate('eval:{paragraphify}hi{/paragraphify}');
$this->assertEquals("<p>hi</p>", $this->smarty->fetch($tpl));
}
}