add changelog

changed an incorrect doc and formatted some code.
remove useless resetting of static properties in tearDownAfterClass
2026-08-04 12:34:33 +02:00 · 2026-04-13 21:35:41 +02:00 · 2026-04-13 15:13:28 +02:00 · 2026-04-13 14:15:34 +02:00 · 2026-04-13 14:08:08 +02:00 · 2026-04-13 13:58:09 +02:00
353 changed files with 192 additions and 1121 deletions
@@ -7,3 +7,5 @@ phpunit*
 .phpunit.result.cache
 vendor/*
 composer.lock
+
+
@@ -0,0 +1 @@
+- Moved all unit test-generated output from inside the working tree to tmp files [#1178](https://github.com/smarty-php/smarty/issues/1178)
@@ -15,4 +15,3 @@ if (!ini_get('date.timezone')) {
 }


-
@@ -6,7 +6,6 @@
 /*
 * Smarty PHPUnit Config
 */
-define('individualFolders', true);
 define('MysqlCacheEnable', false);
 define('PdoCacheEnable', false);
 define('PdoGzipCacheEnable', false);
@@ -49,6 +49,37 @@ class PHPUnit_Smarty extends PHPUnit\Framework\TestCase
     */
    public static $cwd = null;

+    /**
+     * Temp directory base for this test class (compile, cache, templates_tmp)
+     *
+     * @var string|null
+     */
+    private static $tempBase = null;
+
+    /**
+     * Unique token for the current test class's temp directory.
+     * Generated once per class.
+     *
+     * @var string|null
+     */
+    private static $tempId = null;
+
+    /**
+     * Return the temp directory base for the current test class.
+     *
+     * @return string
+     * @throws \LogicException If the temp directory base has not been initialized yet.
+     */
+    public static function getTempBase(): string
+    {
+        if (self::$tempBase === null) {
+            throw new \LogicException(
+                'Temp directory base has not been initialized. Call setUpSmarty() before using temp-path helpers.'
+            );
+        }
+        return self::$tempBase;
+    }
+
    /**
     * PDO object for Mysql tests
     *
@@ -75,8 +106,37 @@ class PHPUnit_Smarty extends PHPUnit\Framework\TestCase
     */
    public static function tearDownAfterClass(): void
    {
-        //self::$pdo = null;
-        self::$testNumber = 0;
+        // Remove the unique temp directory for this test class unless the caller
+        // wants to inspect the artifacts (e.g. for debugging a failure).
+        if (!getenv('KEEP_SMARTY_TEST_ARTIFACTS') && self::$tempBase !== null && is_dir(self::$tempBase)) {
+            self::removeDir(self::$tempBase);
+        }
+    }
+
+    /**
+     * Recursively remove a directory, silently ignoring any errors.
+     *
+     * @param string $dir
+     */
+    private static function removeDir(string $dir): void
+    {
+        $dir = rtrim($dir, DIRECTORY_SEPARATOR);
+        $items = @scandir($dir);
+        if ($items === false) {
+            return;
+        }
+        foreach ($items as $item) {
+            if ($item === '.' || $item === '..') {
+                continue;
+            }
+            $path = $dir . DIRECTORY_SEPARATOR . $item;
+            if (is_dir($path) && !is_link($path)) {
+                self::removeDir($path);
+            } else {
+                @unlink($path);
+            }
+        }
+        @rmdir($dir);
    }

    /**
@@ -89,12 +149,46 @@ class PHPUnit_Smarty extends PHPUnit\Framework\TestCase
    public function __construct($name = null, array $data = array(), $dataName = '')
    {
        date_default_timezone_set('Europe/Berlin');
-        if (!defined('individualFolders')) {
-            define('individualFolders', true);
-        }
        parent::__construct($name, $data, $dataName);
    }

+    /**
+     * Compute the temp directory base for a given test directory.
+     *
+     * Returns a path unique to this test class run under sys_get_temp_dir(),
+     * so that concurrent or sequential runs of different test classes never
+     * share compiled/cached output. The unique token is generated once per
+     * class lifetime and reset in tearDownAfterClass().
+     *
+     * Example:
+     *   /path/to/smarty/tests/UnitTests/TagTests/If
+     *     → /tmp/smarty-tests/UnitTests/TagTests/If/<unique-id>/
+     *
+     * @param string $dir absolute test directory
+     * @return string absolute temp base directory (with trailing separator)
+     */
+    private static function getTempDir($dir)
+    {
+        // Lazily generate a unique token for this test class.
+        if (self::$tempId === null) {
+            self::$tempId = uniqid('', true);
+        }
+        $testsRoot = realpath(__DIR__);
+        $realDir = realpath($dir) ?: $dir;
+        // compute relative path from tests/ root
+        if (strpos($realDir, $testsRoot) === 0) {
+            $relative = substr($realDir, strlen($testsRoot));
+        } else {
+            // fallback: use full path hash
+            $relative = DIRECTORY_SEPARATOR . md5($realDir);
+        }
+        return rtrim(sys_get_temp_dir(), DIRECTORY_SEPARATOR)
+            . DIRECTORY_SEPARATOR . 'smarty-tests'
+            . $relative
+            . DIRECTORY_SEPARATOR . self::$tempId
+            . DIRECTORY_SEPARATOR;
+    }
+
    /**
     * Setup Smarty instance called for each test
     *
@@ -102,47 +196,37 @@ class PHPUnit_Smarty extends PHPUnit\Framework\TestCase
     */
    public function setUpSmarty($dir)
    {
-        static $s_dir;
        // set up current working directory
        chdir($dir);
        self::$cwd = getcwd();
+        // compute temp base for this test directory
+        self::$tempBase = self::getTempDir($dir);
        // create missing folders for test
        if (self::$init) {
-            if (!is_dir($dir . '/templates')) {
-                mkdir($dir . '/templates');
+            if (!is_dir(self::$tempBase . 'templates_c')) {
+                mkdir(self::$tempBase . 'templates_c', 0775, true);
            }
-            if (!is_dir($dir . '/configs')) {
-                mkdir($dir . '/configs');
-            }
-            if (individualFolders != 'true') {
-                if (!isset($s_dir[ $dir ])) {
-                    $this->cleanDir($dir . '/templates_c');
-                    $this->cleanDir($dir . '/cache');
-                    if (is_dir($dir . '/templates_tmp')) {
-                        $this->cleanDir($dir . '/templates_tmp');
-                    }
-                    $s_dir[ $dir ] = true;
-                }
-                $dir = __DIR__;
-            }
-            if (!is_dir($dir . '/templates_c')) {
-                mkdir($dir . '/templates_c');
-            }
-            chmod($dir . '/templates_c', 0775);
-            if (!is_dir($dir . '/cache')) {
-                mkdir($dir . '/cache');
-                chmod($dir . '/cache', 0775);
+            if (!is_dir(self::$tempBase . 'cache')) {
+                mkdir(self::$tempBase . 'cache', 0775, true);
            }
+			if (!is_dir(self::$tempBase . 'templates_tmp')) {
+				mkdir(self::$tempBase . 'templates_tmp', 0775, true);
+			}
            self::$init = false;
        }
        clearstatcache();

        // instance Smarty class
        $this->smarty = new \Smarty\Smarty();
-        if (individualFolders != 'true') {
-            $this->smarty->setCompileDir(__DIR__ . '/templates_c');
-            $this->smarty->setCacheDir(__DIR__ . '/cache');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache');
+		$this->smarty->addTemplateDir(self::getTempBase() . 'templates_tmp');
+
+        // Clean output dirs once at the start of each test class run
+        if (self::$testNumber === 0) {
+            $this->cleanDirs();
        }
+        self::$testNumber++;

    }

@@ -230,24 +314,24 @@ KEY `name` (`name`)
    {
        $this->cleanCompileDir();
        $this->cleanCacheDir();
-        if (is_dir(self::$cwd . '/templates_tmp')) {
-            $this->cleanDir(self::$cwd . '/templates_tmp');
+        $templatesTmpDir = self::getTempBase() . 'templates_tmp';
+        if (is_dir($templatesTmpDir)) {
+            $this->cleanDir($templatesTmpDir);
        }
-        $this->assertTrue(true);
-   }
+    }

    /**
     * Make temporary template file
     *
     */
-    public function makeTemplateFile($name, $code)
+    protected function makeTemplateFile($name, $code)
    {
-        if (!is_dir(self::$cwd . '/templates_tmp')) {
-            mkdir(self::$cwd . '/templates_tmp');
-            chmod(self::$cwd . '/templates_tmp', 0775);
-        }
-        $fileName = self::$cwd . '/templates_tmp/' . "{$name}";
-        file_put_contents($fileName, $code);
+        file_put_contents(self::getTempBase() . 'templates_tmp' . '/' . $name, $code);
+    }
+
+    protected function removeTemplateFile($name)
+    {
+        unlink(self::getTempBase() . 'templates_tmp' . '/' . $name);
    }

    /**
@@ -18,6 +18,7 @@ class TemplateNormalizationTest extends PHPUnit_Smarty
    public function setUp(): void
    {
        $this->setUpSmarty(__DIR__);
+		$this->smarty->setTemplateDir(__DIR__ . '/templates');
    }

    public function testGetTemplateDir()
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -18,10 +18,6 @@ class UndefinedTemplateVarTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }
    /**
     * Test Error suppression template fetched by Smarty object
     */
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -21,10 +21,6 @@ class FilterTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

 	/**
 	 * test loaded filter
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -20,10 +20,6 @@ class GetterSetterTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test setter on Smarty object
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -24,10 +24,6 @@ class DefaultPluginHandlerTest extends PHPUnit_Smarty
    }


-    public function testInit()
-    {
-        $this->cleanDirs();
-    }
    public function testDefaultFunctionScript()
    {
        $this->assertEquals("scriptfunction foo bar", $this->smarty->fetch('test_default_function_script.tpl'));
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -21,10 +21,6 @@ class HttpModifiedSinceTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
     }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     *
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -25,11 +25,6 @@ class CacheResourceFileTest extends CacheResourceTestCommon
    }


-    public function testInit()
-
-    {
-        $this->cleanDirs();
-    }

    /**
     * test getCachedFilepath with configuration['useSubDirs'] enabled
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -32,10 +32,6 @@ class CacheResourceCustomMemcacheTest extends CacheResourceTestCommon
        $this->smarty->setCachingType('memcachetest');
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    protected function doClearCacheAssertion($a, $b)
    {
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -29,15 +29,11 @@ if (MysqlCacheEnable == true) {
                $this->getConnection();
            }
            $this->setUpSmarty(__DIR__);
+            $this->initMysqlCache();
            parent::setUp();
            $this->smarty->setCachingType('mysqltest');
        }

-        public function testInit()
-        {
-            $this->cleanDirs();
-            $this->initMysqlCache();
-        }
    }
 }

@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -28,15 +28,11 @@ class CacheResourceCustomPDOTest extends CacheResourceTestCommon
            $this->getConnection();
        }
        $this->setUpSmarty(__DIR__);
+        $this->initMysqlCache();
        parent::setUp();
        $this->smarty->registerCacheResource('pdo',
                                             new Smarty_CacheResource_Pdotest($this->getPDO(), 'output_cache'));
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-        $this->initMysqlCache();
-    }
 }

@@ -2,7 +2,7 @@

 use Smarty\Template\Cached;

-require_once __DIR__ . '/../../__shared/cacheresources/cacheresource.pdo.php';
+require_once __DIR__ . '/../_shared/cacheresources/cacheresource.pdo.php';

 class Smarty_CacheResource_Pdotest extends Smarty_CacheResource_Pdo
 {
@@ -27,16 +27,12 @@ class CacheResourceCustomPDOGzipTest extends CacheResourceTestCommon
            $this->getConnection();
        }
        $this->setUpSmarty(__DIR__);
+        $this->initMysqlCache();
        parent::setUp();
        $this->smarty->setCachingType('pdo');
        $this->smarty->registerCacheResource('pdo', new Smarty_CacheResource_Pdo_Gziptest($this->getPDO(),
                                                                                          'output_cache'));
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-        $this->initMysqlCache();
-    }
 }

@@ -2,7 +2,7 @@

 use Smarty\Template\Cached;

-require_once __DIR__ . '/../../__shared/cacheresources/cacheresource.pdo_gzip.php';
+require_once __DIR__ . '/../_shared/cacheresources/cacheresource.pdo_gzip.php';

 class Smarty_CacheResource_Pdo_Gziptest extends Smarty_CacheResource_Pdo_Gzip
 {
@@ -26,6 +26,7 @@ if (MysqlCacheEnable == true) {
                $this->getConnection();
            }
            $this->setUpSmarty(__DIR__);
+            $this->initMysqlCache();
            parent::setUp();
            if (!class_exists('Smarty_CacheResource_Mysqltest', false)) {
                require_once(__DIR__ . "/../_shared/PHPunitplugins/cacheresource.mysqltest.php");
@@ -34,11 +35,6 @@ if (MysqlCacheEnable == true) {
            $this->smarty->registerCacheResource('foobar', new Smarty_CacheResource_Mysqltest());
        }

-        public function testInit()
-        {
-            $this->cleanDirs();
-            $this->initMysqlCache();
-        }
    }
 }

@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -3,7 +3,7 @@
 use Smarty\Template;
 use Smarty\Template\Cached;

-require_once __DIR__ . '/../../../__shared/cacheresources/cacheresource.memcache.php';
+require_once __DIR__ . '/../cacheresources/cacheresource.memcache.php';

 class Smarty_CacheResource_Memcachetest extends Smarty_CacheResource_Memcache
 {
@@ -3,7 +3,7 @@
 use Smarty\Exception;
 use Smarty\Template\Cached;

-require_once __DIR__ . '/../../../__shared/cacheresources/cacheresource.mysql.php';
+require_once __DIR__ . '/../cacheresources/cacheresource.mysql.php';

 class Smarty_CacheResource_Mysqltest extends Smarty_CacheResource_Mysql
 {
@@ -20,10 +20,6 @@ class CompileCompilerPluginTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test compiler plugin tag in template file
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -17,13 +17,9 @@ class AutoliteralTest extends PHPUnit_Smarty
    public function setUp(): void
    {
        $this->setUpSmarty(__DIR__);
-        $this->smarty->addPluginsDir("../../__shared/PHPunitplugins/");
+        $this->smarty->addPluginsDir("./plugins/");
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test '{ ' delimiter
@@ -20,10 +20,6 @@ class DelimiterTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test <{ }> delimiter
@@ -24,10 +24,6 @@ class UserliteralTest extends PHPUnit_Smarty
        }
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    public function testUserLiteral()
    {
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -28,10 +28,6 @@ class ConfigVarTest extends PHPUnit_Smarty
    /**
     * empty templat_c and cache folders
     */
-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test number config variable
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -25,10 +25,6 @@ class CustomResourceAmbiguousTest extends PHPUnit_Smarty
        //        Smarty::$_resource_cache = array();
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    protected function relative($path)
    {
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -6,7 +6,7 @@
 * @author  Uwe Tews
 */

-require_once __DIR__ . '/../../../__shared/resources/resource.extendsall.php';
+require_once __DIR__ . '/resources/resource.extendsall.php';

 /**
 * class for demo resource plugin extendsall tests
@@ -22,10 +22,6 @@ class ResourceExtendsAllPluginTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test  extendsall
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -24,17 +24,9 @@ if (MysqlResourceEnable == true) {
                $this->getConnection();
            }
            $this->setUpSmarty(__DIR__);
-            $this->smarty->addPluginsDir("./PHPunitplugins/");
-        }
-
-        /**
-        *
-        */
-        public function testInit()
-        {
-            $this->cleanDirs();
            $this->initMysqlResource();
            PHPUnit_Smarty::$pdo->exec("REPLACE INTO templates (name, source) VALUES ('test.tpl', '{\$x = \'hello world\'}{\$x}')");
+            $this->smarty->addPluginsDir("./PHPunitplugins/");
        }

        /**
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -23,10 +23,6 @@ class DefaultTemplateHandlerTest extends PHPUnit_Smarty
    }


-    public function testInit()
-    {
-        $this->cleanDirs();
-    }
    /**
     * test error on unknow template
     */
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -21,10 +21,6 @@ class EvalResourceTest extends PHPUnit_Smarty
    }


-    public function testInit()
-    {
-        $this->cleanDirs();
-    }
    /**
     * test template eval exits
     */
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -20,10 +20,6 @@ class ExtendsResourceTest extends PHPUnit_Smarty
    }


-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    public function compiledPrefilter($text, Template $tpl)
    {
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -23,10 +23,6 @@ class FileResourceTest extends PHPUnit_Smarty
        $this->smarty->enableSecurity();
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    protected function relative($path)
    {
@@ -171,8 +167,7 @@ class FileResourceTest extends PHPUnit_Smarty
 		$tpl->fetch();
 		$timestamp = $tpl->getCached()->timestamp;

-
-		$this->smarty = new \Smarty\Smarty();
+		$this->setUpSmarty(__DIR__);
 	    $this->smarty->caching = true;
 	    $this->smarty->cache_lifetime = 1000;

@@ -271,8 +266,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        chdir(__DIR__ . '/templates/sub/');
        $dn = __DIR__;
-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array(
                                          __DIR__ . '/does-not-exist/',
                                      ));
@@ -292,8 +287,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        chdir(__DIR__ . '/templates/sub/');
        $dn = __DIR__;
-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array(
                                          __DIR__ . '/does-not-exist/',
                                      ));
@@ -348,8 +343,8 @@ class FileResourceTest extends PHPUnit_Smarty

        $cwd = getcwd();
        $dn = __DIR__;
-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array($dn . '/templates/relativity/theory/',));

        $map = array('foo.tpl' => 'theory', './foo.tpl' => 'theory', '././foo.tpl' => 'theory',
@@ -367,8 +362,8 @@ class FileResourceTest extends PHPUnit_Smarty

        $cwd = getcwd();
        $dn = __DIR__;
-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');


        $this->smarty->setTemplateDir(array(
@@ -399,8 +394,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        $dn = __DIR__;

-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        chdir($dn . '/templates/relativity/theory/');
        $this->smarty->setTemplateDir(array(
                                          $dn . '/templates/',
@@ -428,8 +423,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        $dn = __DIR__;

-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array($dn . '/templates/relativity/theory/einstein/',));

        $map = array('foo.tpl' => 'einstein', './foo.tpl' => 'einstein', '././foo.tpl' => 'einstein',
@@ -448,8 +443,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        $dn = __DIR__;

-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array(
                                          $dn . '/templates/relativity/theory/einstein/',
                                      ));
@@ -479,8 +474,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        $dn = __DIR__;

-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array('../..',));

        $map = array('foo.tpl' => 'relativity', './foo.tpl' => 'relativity', '././foo.tpl' => 'relativity',);
@@ -497,8 +492,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        $dn = __DIR__;

-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array('../..',));

        $map =
@@ -516,8 +511,8 @@ class FileResourceTest extends PHPUnit_Smarty
        $cwd = getcwd();
        $dn = __DIR__;

-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array(
                                          '../..',
                                      ));
@@ -549,8 +544,8 @@ class FileResourceTest extends PHPUnit_Smarty

        $cwd = getcwd();
        $dn = __DIR__;
-        $this->smarty->setCompileDir($dn . '/templates_c/');
-        $this->smarty->setCacheDir($dn . '/cache/');
+        $this->smarty->setCompileDir(self::getTempBase() . 'templates_c/');
+        $this->smarty->setCacheDir(self::getTempBase() . 'cache/');
        $this->smarty->setTemplateDir(array(
                                          '..',
                                      ));
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -14,16 +14,13 @@ class FileResourceIndexedTest extends PHPUnit_Smarty
    public function setUp(): void
    {
        $this->setUpSmarty(__DIR__);
+		$this->smarty->setTemplateDir(__DIR__ . '/templates');
        $this->smarty->addTemplateDir(__DIR__ . '/templates_2');
        // note that 10 is a string!
        $this->smarty->addTemplateDir(__DIR__ . '/templates_3', '10');
        $this->smarty->addTemplateDir(__DIR__ . '/templates_4', 'foo');
     }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    public function testFetch()
    {
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -26,10 +26,6 @@ class RegisteredResourceTest extends PHPUnit_Smarty
    }


-    public function testInit()
-    {
-        $this->cleanDirs();
-    }
    /**
     * test resource plugin rendering
     */
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -20,10 +20,6 @@ class ResourcePluginTest extends PHPUnit_Smarty
          $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test resource plugin rendering
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -27,10 +27,6 @@ class StreamResourceTest extends PHPUnit_Smarty
        fclose($fp);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }
    public function tearDown(): void
    {
        parent::tearDown();
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -21,10 +21,6 @@ class StringResourceTest extends PHPUnit_Smarty
    }


-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    protected function relative($path)
    {
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -20,10 +20,6 @@ class FunctionTest extends PHPUnit_Smarty
        $this->setUpSmarty(__DIR__);
    }

-    public function testInit()
-    {
-        $this->cleanDirs();
-    }

    /**
     * test unknown function error
@@ -20,10 +20,6 @@ class SecurityTest extends PHPUnit_Smarty
 		$this->smarty->setForceCompile(true);
 		$this->smarty->enableSecurity();
 	}
-	public function testInit()
-	{
-		$this->cleanDirs();
-	}

 	/**
 	 * test that security is loaded
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -1,2 +0,0 @@
-# Ignore anything in here, but keep this directory
-*
@@ -21,10 +21,6 @@ class AppendTest extends PHPUnit_Smarty
    }


-    public function testInit()
-    {
-        $this->cleanDirs();
-    }
    /**
     * test append
     */
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Simon Wisselink	b08a1d8332	add changelog	2026-04-13 21:35:41 +02:00
Simon Wisselink	a511a011cb	changed an incorrect doc and formatted some code.	2026-04-13 15:13:28 +02:00
Simon Wisselink	7cab1c0c24	remove useless resetting of static properties in tearDownAfterClass	2026-04-13 14:15:34 +02:00
Simon Wisselink	b7dac0306f	Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2026-04-13 14:08:08 +02:00
Simon Wisselink	e73aaf19b5	fixed the unit tests	2026-04-13 13:58:09 +02:00
Simon Wisselink	06c49acee4	cleanup of unused template files, non-shared files stored in __shared folder, no longer required calls to add template folders et cetera	2026-04-13 13:17:20 +02:00
Simon Wisselink	c22d109d17	Clean up each test class's unique temp dir in tearDownAfterClass() Add a private static removeDir() helper and call it from tearDownAfterClass() to recursively delete the per-class unique temp directory after each test class finishes. Cleanup failures are silently ignored (@ suppression) so they never cause test failures. Set KEEP_SMARTY_TEST_ARTIFACTS=1 in the environment to skip cleanup and keep the artifacts on disk for debugging.	2026-04-13 11:10:26 +02:00
Simon Wisselink	deb0b22976	Remove individualFolders dead code and spurious assertTrue from cleanDirs() - Remove the never-active individualFolders code path from setUpSmarty() (the constant was always true, making the branch unreachable) - Remove define('individualFolders') from Config.php and the constructor - Remove $this->assertTrue(true) from cleanDirs(): it existed solely to make testInit() count as a passing test; now that cleanDirs() is called from setUpSmarty() and from test methods directly, the assertion was spuriously inflating assertion counts - Add tests/**/templates_c/, cache/, templates_tmp/ to .gitignore to prevent stale test output from appearing as untracked files	2026-04-13 00:40:28 +02:00
Simon Wisselink	cc3e9c2a20	Isolate each test class in a unique temp directory getTempDir() now appends a per-class uniqid token to the temp path, so concurrent or sequential test runs never share compiled/cached output. The token is generated lazily on first use and reset in tearDownAfterClass(), giving every test class a fresh isolated directory. As a result, the Bootstrap.php pre-run cleanup of smarty-tests/ is no longer needed for correctness (stale paths are unreachable) and was harmful to concurrent runs, so it has been removed.	2026-04-12 23:53:51 +02:00
Simon Wisselink	760f4834b3	Redirect test temp dirs to system temp directory. Fixes #1178 Move all test-generated output (compiled templates, cache files, and temporary template sources) from per-test-directory folders inside the working tree to a parallel structure under sys_get_temp_dir()/smarty-tests/. This removes 215 boilerplate .gitignore files from the repo and ensures running the test suite leaves zero uncommitted files in the working tree. All 2296 tests continue to pass with identical behavior.	2026-04-11 00:05:42 +02:00
				`@@ -0,0 +1 @@`
				`- Moved all unit test-generated output from inside the working tree to tmp files [#1178](https://github.com/smarty-php/smarty/issues/1178)`