wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-07-10 23:50:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

tests: fix AUTHORITY_INFO_ACCESS leak under OPENSSL_EXTRA-only builds

Browse Source 
This branch widened test_wolfSSL_X509V3_EXT's guard from OPENSSL_ALL to
(OPENSSL_EXTRA || OPENSSL_ALL). The Authority Info Access sub-test frees its
aia stack with wolfSSL_sk_ACCESS_DESCRIPTION_pop_free(aia, NULL), relying on the
stack's type-based element free - but wolfssl_sk_get_free_func() only wires up
wolfSSL_ACCESS_DESCRIPTION_free for STACK_TYPE_ACCESS_DESCRIPTION under
OPENSSL_ALL. In an OPENSSL_EXTRA-only build (now reachable) the NULL callback
frees the stack nodes but leaks each ACCESS_DESCRIPTION (struct + method OBJ +
location GENERAL_NAME + URI string): 370 bytes, caught by ASAN/valgrind.

Pass wolfSSL_ACCESS_DESCRIPTION_free explicitly (available under OPENSSL_EXTRA);
correct under OPENSSL_ALL too. Verified leak-free under ASAN with the failing
config (--enable-opensslextra --enable-crl ... --disable-fastmath).
This commit is contained in:
Daniele Lacamera
2026-07-06 22:48:11 +02:00
parent e3a6d4a0e6
commit 27b1a40bdd
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/api/test_ossl_x509_ext.c
+5 -1
View File
@@ -1645,7 +1645,11 @@ int test_wolfSSL_X509V3_EXT(void)
ExpectNull(wolfSSL_sk_ACCESS_DESCRIPTION_value(NULL, 0));
ExpectNull(wolfSSL_sk_ACCESS_DESCRIPTION_value(aia, 1));
ExpectNotNull(wolfSSL_sk_ACCESS_DESCRIPTION_value(aia, 0));
wolfSSL_sk_ACCESS_DESCRIPTION_pop_free(aia, NULL);
/* Pass the element free explicitly: the stack's default (type-based) element
* free for ACCESS_DESCRIPTION is only wired up under OPENSSL_ALL, so with a
* NULL callback an OPENSSL_EXTRA-only build (this block now compiles there)
* frees the stack nodes but leaks each ACCESS_DESCRIPTION. */
wolfSSL_sk_ACCESS_DESCRIPTION_pop_free(aia, wolfSSL_ACCESS_DESCRIPTION_free);
aia = NULL;
#ifndef NO_WOLFSSL_STUB