wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-08-21 13:53:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10918 from MarkAtwood/fix/mldsa-gamma1-19-shift-ub

Browse Source 
fix: signed-shift UB in ML-DSA gamma1_19 encoder (32-bit path)
This commit is contained in:
David Garske
2026-08-06 12:11:43 -07:00
committed by GitHub
parent 9b6b8b1bc2 3298db3e23
commit 4a71db7bef
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wolfcrypt/src/wc_mldsa.c
+4 -4
View File
@@ -1979,10 +1979,10 @@ static void mldsa_encode_gamma1_19_bits_c(const sword32* z, byte* s)
/* Step 3. Get 20 bits as a number. */
for (j = 0; j < MLDSA_N; j += 4) {
sword32 z0 = MLDSA_GAMMA1_19 - z[j + 0];
sword32 z1 = MLDSA_GAMMA1_19 - z[j + 1];
sword32 z2 = MLDSA_GAMMA1_19 - z[j + 2];
sword32 z3 = MLDSA_GAMMA1_19 - z[j + 3];
word32 z0 = (word32)(MLDSA_GAMMA1_19 - z[j + 0]);
word32 z1 = (word32)(MLDSA_GAMMA1_19 - z[j + 1]);
word32 z2 = (word32)(MLDSA_GAMMA1_19 - z[j + 2]);
word32 z3 = (word32)(MLDSA_GAMMA1_19 - z[j + 3]);
/* 20 bits per number.
* 4 numbers become 10 bytes. (4 * 20 bits = 10 * 8 bits) */