wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-01-26 12:32:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9421 from SparkiDev/mlkem_to_bytes_fix

Browse Source 
ML-KEM to bytes C: not reducing all values
This commit is contained in:
David Garske
2025-11-13 08:57:31 -08:00
committed by GitHub
parent 082943649b b272f784ec
commit 4f3586fe58
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
wolfcrypt/src/wc_mlkem_poly.c
View File

@@ -4775,7 +4775,7 @@ static MLKEM_NOINLINE void mlkem_csubq_c(sword16* p)
for (i = 0; i < MLKEM_N; ++i) {
sword16 t = p[i] - MLKEM_Q;
/* When top bit set, -ve number - need to add q back. */
p[i] = ((t >> 15) & MLKEM_Q) + t;
p[i] = (sword16)((word16)(-((word16)t >> 15)) & MLKEM_Q) + t;
}
}
@@ -6021,11 +6021,11 @@ static void mlkem_to_bytes_c(byte* b, sword16* p, int k)
int i;
int j;
/* Reduce each coefficient to mod q. */
mlkem_csubq_c(p);
/* All values are now positive. */
for (j = 0; j < k; j++) {
/* Reduce each coefficient to mod q. */
mlkem_csubq_c(p);
/* All values are now positive. */
for (i = 0; i < MLKEM_N / 2; i++) {
word16 t0 = p[2 * i];
word16 t1 = p[2 * i + 1];