wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2026-08-22 03:23:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

tests: add pkcs12 container DecisionCoverage case

Browse Source 
The pkcs12 group was almost entirely wc_PKCS12_PBKDF_ex, which lives in
pwdbased.c, leaving pkcs12.c's container entry points to the KAT alone.
Drives the argument guards of wc_d2i_PKCS12, wc_i2d_PKCS12,
wc_PKCS12_parse and wc_PKCS12_free.
This commit is contained in:
Daniele Lacamera
2026-08-07 09:27:42 +02:00
parent 9ddb7ff5e0
commit 65ffd32f4c
2 changed files with 62 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/api/test_pkcs12.c
+59
View File
@@ -1080,3 +1080,62 @@ int test_wc_PKCS12_PBKDF_ex_sha512_256(void)
#endif
return EXPECT_RESULT();
}
/*
* MC/DC decision coverage for the PKCS#12 container API
* (wolfcrypt/src/pkcs12.c). The pkcs12 group's other tests are almost all
* wc_PKCS12_PBKDF_ex, which lives in pwdbased.c, so the container entry points
* are otherwise reached only by the pkcs12_test() KAT. This drives their
* multi-operand argument guards, each operand flipped independently.
*/
int test_wc_PKCS12DecisionCoverage(void)
{
EXPECT_DECLS;
#if defined(HAVE_PKCS12) && !defined(NO_ASN) && !defined(NO_PWDBASED) && \
!defined(NO_HMAC) && !defined(NO_CERTS)
WC_PKCS12* pkcs12 = NULL;
byte der[8];
byte* out = NULL;
int outSz = 0;
XMEMSET(der, 0, sizeof(der));
ExpectNotNull(pkcs12 = wc_PKCS12_new());
/* wc_d2i_PKCS12 "der == NULL || pkcs12 == NULL" */
ExpectIntEQ(wc_d2i_PKCS12(NULL, sizeof(der), pkcs12),
WC_NO_ERR_TRACE(BAD_FUNC_ARG));
ExpectIntEQ(wc_d2i_PKCS12(der, sizeof(der), NULL),
WC_NO_ERR_TRACE(BAD_FUNC_ARG));
/* both operands false: rejected by the parser, not the argument check */
ExpectIntNE(wc_d2i_PKCS12(der, sizeof(der), pkcs12),
WC_NO_ERR_TRACE(BAD_FUNC_ARG));
/* wc_i2d_PKCS12 argument guards; a container with no safe/signData
* exercises the "pkcs12->safe == NULL" half of the cascade. */
ExpectIntLT(wc_i2d_PKCS12(NULL, &out, &outSz), 0);
ExpectIntLT(wc_i2d_PKCS12(pkcs12, NULL, &outSz), 0);
ExpectIntLT(wc_i2d_PKCS12(pkcs12, &out, NULL), 0);
/* wc_PKCS12_parse on an empty container: the pkcs12 != NULL operand is
* false while the internal state operands decide the outcome. */
{
byte* pkey = NULL; word32 pkeySz = 0;
byte* cert = NULL; word32 certSz = 0;
WC_DerCertList* ca = NULL;
ExpectIntLT(wc_PKCS12_parse(NULL, "pw", &pkey, &pkeySz, &cert, &certSz,
&ca), 0);
ExpectIntLT(wc_PKCS12_parse(pkcs12, "pw", &pkey, &pkeySz, &cert,
&certSz, &ca), 0);
if (pkey != NULL) XFREE(pkey, NULL, DYNAMIC_TYPE_PUBLIC_KEY);
if (cert != NULL) XFREE(cert, NULL, DYNAMIC_TYPE_PKCS);
if (ca != NULL) wc_FreeCertList(ca, NULL);
}
wc_PKCS12_free(pkcs12);
/* wc_PKCS12_free tolerates NULL: the guard's true half. */
wc_PKCS12_free(NULL);
#endif /* HAVE_PKCS12 && ... */
return EXPECT_RESULT();
}
tests/api/test_pkcs12.h
+3 -1
View File
@@ -40,6 +40,7 @@ int test_wc_PKCS12_PBKDF_ex_sha224(void);
int test_wc_PKCS12_PBKDF_ex_sha384(void);
int test_wc_PKCS12_PBKDF_ex_sha512_224(void);
int test_wc_PKCS12_PBKDF_ex_sha512_256(void);
int test_wc_PKCS12DecisionCoverage(void);
#define TEST_PKCS12_DECLS \
TEST_DECL_GROUP("pkcs12", test_wc_i2d_PKCS12), \
@@ -57,6 +58,7 @@ int test_wc_PKCS12_PBKDF_ex_sha512_256(void);
TEST_DECL_GROUP("pkcs12", test_wc_PKCS12_PBKDF_ex_sha224), \
TEST_DECL_GROUP("pkcs12", test_wc_PKCS12_PBKDF_ex_sha384), \
TEST_DECL_GROUP("pkcs12", test_wc_PKCS12_PBKDF_ex_sha512_224), \
TEST_DECL_GROUP("pkcs12", test_wc_PKCS12_PBKDF_ex_sha512_256)
TEST_DECL_GROUP("pkcs12", test_wc_PKCS12_PBKDF_ex_sha512_256), \
TEST_DECL_GROUP("pkcs12", test_wc_PKCS12DecisionCoverage)
#endif /* WOLFCRYPT_TEST_PKCS12_H */