wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-29 18:27:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

BN_to_ASN1_INTEGER: fix handling of padding

Browse Source 
Incorrect calculation of when padding byte needed and consequently
adding byte manually when properly handled by SetASNInt().
This commit is contained in:
Sean Parkinson
2023-04-24 09:15:31 +10:00
parent 865581704e
commit 6634ec198e
2 changed files with 39 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/ssl_asn1.c
View File

@ -1333,15 +1333,11 @@ WOLFSSL_ASN1_INTEGER* wolfSSL_BN_to_ASN1_INTEGER(const WOLFSSL_BIGNUM *bn,
/* Get length in bits of encoded number. */
numBits = wolfSSL_BN_num_bits(bn);
/* Leading zero required if most-significant byte has top bit set. */
if ((numBits % 8) == 7) {
if ((numBits > 0) && (numBits % 8) == 0) {
firstByte = 0x80;
}
/* Get length of header based on length of number. */
length = SetASNInt(len, firstByte, NULL);
if (firstByte != 0) {
/* Add one for leading zero. */
length++;
}
/* Add number of bytes to encode number. */
length += len;
@ -1359,9 +1355,6 @@ WOLFSSL_ASN1_INTEGER* wolfSSL_BN_to_ASN1_INTEGER(const WOLFSSL_BIGNUM *bn,
a->data[idx] = 0;
}
else {
if (firstByte != 0) {
a->data[idx++] = 0;
}
/* Add encoded number. */
len = wolfSSL_BN_bn2bin(bn, a->data + idx);
if (len < 0) {

63
tests/api.c
View File

@ -31421,22 +31421,25 @@ static int test_wolfSSL_ASN1_INTEGER_BN(void)
int res = TEST_SKIPPED;
#if defined(OPENSSL_EXTRA) && !defined(NO_ASN)
ASN1_INTEGER* ai;
ASN1_INTEGER* a2;
BIGNUM* a;
ASN1_INTEGER* ai2;
BIGNUM* bn;
BIGNUM* bn2;
ai = ASN1_INTEGER_new();
AssertNotNull(ai);
bn2 = BN_new();
AssertNotNull(bn2);
/* Invalid parameter testing. */
AssertNull(a = ASN1_INTEGER_to_BN(NULL, NULL));
AssertNull(a2 = BN_to_ASN1_INTEGER(NULL, NULL));
AssertNull(bn = ASN1_INTEGER_to_BN(NULL, NULL));
AssertNull(ai2 = BN_to_ASN1_INTEGER(NULL, NULL));
/* at the moment hard setting since no set function */
ai->data[0] = 0xff; /* No DER encoding. */
ai->length = 1;
#if defined(WOLFSSL_QT) || defined(WOLFSSL_HAPROXY)
AssertNotNull(a = ASN1_INTEGER_to_BN(ai, NULL));
BN_free(a);
AssertNotNull(bn = ASN1_INTEGER_to_BN(ai, NULL));
BN_free(bn);
#else
AssertNull(ASN1_INTEGER_to_BN(ai, NULL));
#endif
@ -31447,8 +31450,8 @@ static int test_wolfSSL_ASN1_INTEGER_BN(void)
ai->length = 3;
#if defined(WOLFSSL_QT) || defined(WOLFSSL_HAPROXY)
/* Interpreted as a number 0x020403. */
AssertNotNull(a = ASN1_INTEGER_to_BN(ai, NULL));
BN_free(a);
AssertNotNull(bn = ASN1_INTEGER_to_BN(ai, NULL));
BN_free(bn);
#else
AssertNull(ASN1_INTEGER_to_BN(ai, NULL));
#endif
@ -31457,37 +31460,47 @@ static int test_wolfSSL_ASN1_INTEGER_BN(void)
ai->data[1] = 0x01; /* length of integer */
ai->data[2] = 0x03;
ai->length = 3;
AssertNotNull(a = ASN1_INTEGER_to_BN(ai, NULL));
AssertNotNull(a2 = BN_to_ASN1_INTEGER(a, NULL));
AssertIntEQ(ASN1_INTEGER_cmp(ai, a2), 0);
AssertNotNull(bn = ASN1_INTEGER_to_BN(ai, NULL));
AssertNotNull(ai2 = BN_to_ASN1_INTEGER(bn, NULL));
AssertIntEQ(ASN1_INTEGER_cmp(ai, ai2), 0);
AssertNotNull(bn2 = ASN1_INTEGER_to_BN(ai2, bn2));
AssertIntEQ(BN_cmp(bn, bn2), 0);
ai->data[0] = 0x02; /* tag for ASN_INTEGER */
ai->data[1] = 0x01; /* length of integer */
ai->data[2] = 0xff;
ai->length = 3;
AssertNotNull(a = ASN1_INTEGER_to_BN(ai, a));
AssertNotNull(a2 = BN_to_ASN1_INTEGER(a, a2));
AssertIntEQ(ASN1_INTEGER_cmp(ai, a2), 0);
ai->data[1] = 0x02; /* length of integer */
ai->data[2] = 0x00; /* padding byte to ensure positive */
ai->data[3] = 0xff;
ai->length = 4;
AssertNotNull(bn = ASN1_INTEGER_to_BN(ai, bn));
AssertNotNull(ai2 = BN_to_ASN1_INTEGER(bn, ai2));
AssertIntEQ(ASN1_INTEGER_cmp(ai, ai2), 0);
AssertNotNull(bn2 = ASN1_INTEGER_to_BN(ai2, bn2));
AssertIntEQ(BN_cmp(bn, bn2), 0);
ai->data[0] = 0x02; /* tag for ASN_INTEGER */
ai->data[1] = 0x01; /* length of integer */
ai->data[2] = 0x00;
ai->length = 3;
AssertNotNull(a = ASN1_INTEGER_to_BN(ai, a));
AssertNotNull(a2 = BN_to_ASN1_INTEGER(a, a2));
AssertIntEQ(ASN1_INTEGER_cmp(ai, a2), 0);
AssertNotNull(bn = ASN1_INTEGER_to_BN(ai, bn));
AssertNotNull(ai2 = BN_to_ASN1_INTEGER(bn, ai2));
AssertIntEQ(ASN1_INTEGER_cmp(ai, ai2), 0);
AssertNotNull(bn2 = ASN1_INTEGER_to_BN(ai2, bn2));
AssertIntEQ(BN_cmp(bn, bn2), 0);
ai->data[0] = 0x02; /* tag for ASN_INTEGER */
ai->data[1] = 0x01; /* length of integer */
ai->data[2] = 0x01;
ai->length = 3;
ai->negative = 1;
AssertNotNull(a = ASN1_INTEGER_to_BN(ai, a));
AssertNotNull(a2 = BN_to_ASN1_INTEGER(a, a2));
AssertIntEQ(ASN1_INTEGER_cmp(ai, a2), 0);
AssertNotNull(bn = ASN1_INTEGER_to_BN(ai, bn));
AssertNotNull(ai2 = BN_to_ASN1_INTEGER(bn, ai2));
AssertIntEQ(ASN1_INTEGER_cmp(ai, ai2), 0);
AssertNotNull(bn2 = ASN1_INTEGER_to_BN(ai2, bn2));
AssertIntEQ(BN_cmp(bn, bn2), 0);
BN_free(a);
ASN1_INTEGER_free(a2);
BN_free(bn2);
BN_free(bn);
ASN1_INTEGER_free(ai2);
ASN1_INTEGER_free(ai);
res = TEST_RES_CHECK(1);