wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-08-01 03:34:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for X509_add_ext and new test case.

Browse Source
This commit is contained in:
David Garske
2022-04-05 13:38:04 -07:00
parent 87dc197284
commit 80766566fc
3 changed files with 28 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/x509.c
View File

@@ -1079,14 +1079,17 @@ static int asn1_string_copy_to_buffer(WOLFSSL_ASN1_STRING* str, byte** buf,
int wolfSSL_X509_add_ext(WOLFSSL_X509 *x509, WOLFSSL_X509_EXTENSION *ext, int loc)
{
int nid;
WOLFSSL_ENTER("wolfSSL_X509_add_ext");
if (!x509 || !ext || !ext->obj || loc >= 0) {
if (!x509 || !ext || loc >= 0) {
WOLFSSL_MSG("Bad parameter");
return WOLFSSL_FAILURE;
}
nid = (ext->obj != NULL) ? ext->obj->type : ext->value.nid;
switch (ext->obj->type) {
switch (nid) {
case NID_authority_key_identifier:
if (x509->authKeyIdSrc != NULL) {
/* If authKeyId points into authKeyIdSrc then free it and
@@ -2348,16 +2351,19 @@ void wolfSSL_X509V3_set_ctx_nodb(WOLFSSL_X509V3_CTX* ctx)
#endif /* !NO_WOLFSSL_STUB */
#ifdef OPENSSL_ALL
static WOLFSSL_X509_EXTENSION* createExtFromStr(int nid, const char *value) {
WOLFSSL_X509_EXTENSION* ext = wolfSSL_X509_EXTENSION_new();
static WOLFSSL_X509_EXTENSION* createExtFromStr(int nid, const char *value)
{
WOLFSSL_X509_EXTENSION* ext;
if (value == NULL)
return NULL;
ext = wolfSSL_X509_EXTENSION_new();
if (ext == NULL) {
WOLFSSL_MSG("memory error");
return NULL;
}
if (value == NULL)
return NULL;
ext->value.nid = nid;
switch (nid) {
case NID_subject_key_identifier:

18
tests/api.c
View File

@@ -45191,7 +45191,7 @@ static void test_wolfSSL_X509V3_EXT_get(void) {
static void test_wolfSSL_X509V3_EXT_nconf(void)
{
#if defined (OPENSSL_ALL)
#ifdef OPENSSL_ALL
const char *ext_names[] = {
"subjectKeyIdentifier",
"authorityKeyIdentifier",
@@ -45213,23 +45213,31 @@ static void test_wolfSSL_X509V3_EXT_nconf(void)
"digitalSignature,keyEncipherment,dataEncipherment",
};
size_t i;
X509_EXTENSION* ext;
X509* x509 = X509_new();
printf(testingFmt, "wolfSSL_X509V3_EXT_nconf()");
for (i = 0; i < ext_names_count; i++) {
X509_EXTENSION* ext = X509V3_EXT_nconf(NULL, NULL, ext_names[i],
ext_values[i]);
ext = X509V3_EXT_nconf(NULL, NULL, ext_names[i], ext_values[i]);
AssertNotNull(ext);
X509_EXTENSION_free(ext);
}
for (i = 0; i < ext_nids_count; i++) {
X509_EXTENSION* ext = X509V3_EXT_nconf_nid(NULL, NULL, ext_nids[i],
ext_values[i]);
ext = X509V3_EXT_nconf_nid(NULL, NULL, ext_nids[i], ext_values[i]);
AssertNotNull(ext);
X509_EXTENSION_free(ext);
}
/* Test adding extension to X509 */
for (i = 0; i < ext_nids_count; i++) {
ext = X509V3_EXT_nconf(NULL, NULL, ext_names[i], ext_values[i]);
AssertIntEQ(X509_add_ext(x509, ext, -1), WOLFSSL_SUCCESS);
X509_EXTENSION_free(ext);
}
X509_free(x509);
printf(resultFmt, "passed");
#endif
}

3
wolfssl/ssl.h
View File

@@ -251,6 +251,7 @@ struct WOLFSSL_ASN1_STRING {
char strData[CTC_NAME_SIZE];
int length;
int type; /* type of string i.e. CTC_UTF8 */
int nid;
char* data;
long flags;
unsigned int isDynamic:1; /* flag for if data pointer dynamic (1 is yes 0 is no) */
@@ -333,7 +334,7 @@ struct WOLFSSL_ASN1_OBJECT {
WOLFSSL_GENERAL_NAME* gn;
#endif
struct d { /* derefrenced */
struct d { /* dereferenced */
WOLFSSL_ASN1_STRING* dNSName;
WOLFSSL_ASN1_STRING ia5_internal;
WOLFSSL_ASN1_STRING* ia5; /* points to ia5_internal */