wolfSSL/wolfssl
1
0
Fork 1
mirror of https://github.com/wolfSSL/wolfssl.git synced 2025-07-30 02:37:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leaks

Browse Source 
- Freeing the session object depends on the callback return
- The session object is malloc'ed when ssl->options.internalCacheOff
- wolfSSL_CTX_use_certificate needs to own the cert when KEEP_OUR_CERT because either it is up ref'ed or copied
This commit is contained in:
Juliusz Sosinowicz
2020-12-28 22:33:01 +01:00
parent 4280861af0
commit 8c07aafc43
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/ssl.c
View File

@ -13407,6 +13407,9 @@ int AddSession(WOLFSSL* ssl)
WOLFSSL_SESSION* session;
int i;
int overwrite = 0;
#ifdef HAVE_EXT_CACHE
int cbRet = 0;
#endif
if (ssl->options.sessionCacheOff)
return 0;
@ -13673,9 +13676,9 @@ int AddSession(WOLFSSL* ssl)
#ifdef HAVE_EXT_CACHE
if (error == 0 && ssl->ctx->new_sess_cb != NULL)
ssl->ctx->new_sess_cb(ssl, session);
if (ssl->options.internalCacheOff)
FreeSession(session, 0);
cbRet = ssl->ctx->new_sess_cb(ssl, session);
if (ssl->options.internalCacheOff && cbRet == 0)
FreeSession(session, 1);
#endif
return error;
@ -42157,7 +42160,9 @@ err:
}
#endif
ctx->ownOurCert = 0;
/* We own the cert because either we up its reference counter
* or we create our own copy of the cert object. */
ctx->ownOurCert = 1;
#endif
/* Update the available options with public keys. */